0007431: Too large images cannot be stored into tag - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update

0007431	MMW v4	Properties/Auto-Tools	public	2011-02-22 20:15	2011-03-15 23:29

Reporter	Ludek	Assigned To
Priority	urgent	Severity	major	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	3.2.4
Target Version	4.0	Fixed in Version	4.0

Summary	0007431: Too large images cannot be stored into tag
Description	During fixing of issue 0007414 I found that although MM is set by default to store images into file tags it has serious problems to store large images (e.g. 2000x2000px JPEG) into MP3 tag. The tagging operation freezes in such a case. I would suggest to use same solution as in 0007414, i.e. auto-resize large images to 256x256 px before storing into tag.
Tags	No tags attached.

Fixed in build	1351

Ludek 2011-02-22 20:18 developer ~0023322	Reminder sent to: jiri, rusty, ~~stephen_platt~~ Do you agree with the suggested solution or do you see a downside?

rusty 2011-02-22 20:34 administrator ~0023324	I think that some users might want to store larger images than 256x256, so we should set it to whatever the maximum size that MM can handle is. Ideally, the Max art size for a tag would be configurable up to that maximum. e.g. Resize tagged images larger than: _x_ x _y_ (pixels) Also, I assume that aspect ratios would be retained (e.g. for art that has a non-square aspect ratio)?

Ludek 2011-02-22 20:55 developer ~0023326	OK, we can set target to 4.1 and add appropriate UI then. The problem is there for years and strangely enough no complain?

jiri 2011-02-22 22:07 administrator ~0023329	First of all I'd like to find out what's the reason for the freeze, I don't see any technical reason for this. Ludek, let me know please, if you know more about it.

Ludek 2011-02-22 23:11 developer ~0023338 Last edited: 2011-02-23 00:59	It freezes in ID3Lib when calling ID3Tag_UpdateByTagType, I haven't relalized that we have sources for ID3Lib, we should try to fix ID3Lib.dll After debugging ID3Lib sources I found that it freezes in unit io_decorators.cpp when performing method io::UnsyncedWriter::writeChars that seems to be very ineffective.

Ludek 2011-02-23 13:31 developer ~0023342 Last edited: 2011-02-23 13:42	Fixed in build 1351. MP3 tagging is much more faster now.

peke 2011-03-15 23:29 developer ~0023727	Verified 1353