View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002528 | MMW v4 | Player | public | 2006-07-03 13:33 | 2013-12-10 00:41 |
| Reporter | jiri | Assigned To | |||
| Priority | high | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | no change required | ||
| Product Version | 2.5.3 | ||||
| Summary | 0002528: MM Not Compatible with latest Winamp 5.3+ Unicode Input plug-ins. | ||||
| Description | There are reports of problems with the latest WinAmp plug-ins, see http://www.mediamonkey.com/forum/viewtopic.php?t=10771. We should check out if there's really anything needed to change in MM. | ||||
| Additional Information | This Is referenced to all Winamp Input plugins from Winamp 5.3 and above that uses Winamp Unicode Structure Described in Winamp SDK 5.32 | ||||
| Tags | No tags attached. | ||||
| Fixed in build | |||||
|
|
I have localized the problem and it looks that it can be clearly reproduced in case of using in_!mpg123 plugin downloaded from this page http://otachan.com/in_!mpg123.html Version for Winamp 2 works perfectly and version for winamp 5.3+ do not work it just skips thru playlist due to use of this library http://www.win32lab.com/fsw/mp3infp/ More info: http://www.hydrogenaudio.org/forums/index.php?showtopic=18530&st=200 |
|
|
It Looks that we need to make support for new export Function winampGetExtendedFileInfoW which is used to gain info for decoder/in_plugin We should include check in MM for winampGetExtendedFileInfoW Function and make MM To Export/Import it in Case Input plugin sends _EXTENDED_ Msgs to MM (Check WA_IPC.H for descriptions). Most of Extended info is handled in Taginfo.cpp and MM do not use plugin features to write tag Filename is essential to be available to set thrum winampGetExtendedFileInfoW which should make those plugins work. I have uploaded sources to FTP, assigned to Jiri to determine what we shell do next and shell we proceed with change of WinampPlugins.pas, MP3Utils.pas, playlistmanage.pas |
|
|
Ok, can you try to make some simple implementation of winampGetExtendedFileInfoW support in WinAmpPlugins.pas, so that the plug-ins work fine in MM? |
|
|
Ok specs are, when I finish implementing of function itself I'll need your help Jiri to change APP MSGS handle accordingly so that MM could receive them correctly and all should work. |
|
|
I see something implemented in SVN Revision 2375, Peke please describe what it does, how well is it tested, etc. |
|
|
In Revision 2375 I have Updated SVN with updates that on plugin Loading MM test for Existence of Extended Input Plugin Functions exported and flag that plugin as extended. Also On play MM Fill info and calls That function to initiate and fill extended Info. I didn't closed this as it do not work completely, but SVN is updated as no changes to MM behavior/functionality is compromised. Maybe a debug of in_!mpg123 sources can revive something I missed in filling that info. |
|
|
If it doesn't do anything useful yet, then I'd prefer if you remove it from the sources for now and only add it back later when it fully works. Currently it can introduce bugs, without any positive effect... |
|
|
SVN Updated and Changes Commented to avoid introducing bugs. Will debug much closely with MSVC++ 8.0 to see why it didn't work like it should. |
|
|
It Looks that all problems relating to New Winamp plugins after though test of in_!mpg123.dll both for WA 5.32 (in_!mpg123_118ot112.1.7z Ver. 1.18y ot112.1 for WINAMP Ver. 5.3 or newer) and older version for WA 5.24 and less (in_!mpg123_118ot109.2.7z Ver. 1.18y ot109.2) All come to simple solution to detect and include this in MM for determine what type of plugin is used as input plugin. #define IN_UNICODE 0x0F000000 #ifdef UNICODE_INPUT_PLUGIN #define in_char wchar_t #define IN_VER (IN_UNICODE | 0x100) #else #define in_char char #define IN_VER 0x100 #endif After these changes winampGetExtendedFileInfoW referring to Unicode version of App.message 290 and need to be Unicode formated which current MM winampGetExtendedFileInfo will fail and plugin will not work. I'll update All needed Units and Add WAUnicode Property so that MM Will be compatible with WA 5.3x+ input plugins |
|
|
SVN Updated and tested with http://otachan.com/in_!mpg123_118ot112.1.7z that didn't worked in MM 3.0 Alpha 3 |
|
|
Just tested with in_mp3.dll from the latest WinAmp and it doesn't work, because it needs IPC_GET_API_SERVICE which we don't have implemented. It looks like they are making this too complicated, implementing this probably isn't a simple task and so I don't know whether we will be able to still support in_mp3.dll (and possibly some other native WinAmp input plug-ins) in the future. |
|
|
I get same conclusion, Winamp API in MM is too old and we need to think whatever we shell do if we want to support newer plugins, there is issues with Configuration, and with VIS_* that embed in Winamp UI. I looked WA 5.34+ SDK and tested few new features. |
|
|
Winamp will cease to exist as of December 20'th 2013 |
