View Issue Details

IDProjectCategoryView StatusLast Update
0020181MMW 5Syncpublic2024-03-25 12:12
Reporterlowlander Assigned To 
PriorityurgentSeverityminorReproducibilityalways
Status closedResolutionreopened 
Product Version5.1 
Target Version5.1Fixed in Version5.1 
Summary0020181: Convert Artwork problems with PNG files
DescriptionThere seem to be a few issues with Convert Artwork:

1) PNG > JPG doesn't resize to max. resolution according to user (for me it did).

2) PNG > PNG gives correct size, but instead of resizing original it crops the max resolution from original.

3) Convert Artwork does nothing without Sync all Artwork to file folders or Copy Artwork to file tags enabled. I'd expect Artwork to be Synced as-is (but converted) when neither option is chosen by user.

4) Cropping occurs on width, this is unclear from wording.

5) Max. resolution doesn't become disabled when Convert Artwork is disabled.

6) Remove Artwork and Convert Artwork can both be enabled. Remove Artwork will remove Converted Artwork if it doesn't match. This seems somewhat unexpected (technically correct though). It seems a these options should be presented in an OR scenario.
Steps To ReproduceI guess the following may be better:

Sync Artwork as (drop-down):
- As-is (which keeps Artwork as stored with the files on the PC)
- Copy Artwork to file folders
- Copy Artwork to file tags
- Copy Artwork to file folders and tags

Choosing either file folders option would enable a field below for filenaming.

Modify Artwork on Sync (maybe drop-down):
Remove Artwork if larger than file size
Remove Artwork if larger than resolution (this would have to meet both width and height criteria)
Convert Artwork

Choosing any option would then enable their settings below. The question is would anyone want to remove converted Artwork (maybe they do) if it's too large still.

Then with a bit more spacing the Genre and Artist/Composer options providing a separation between Artwork and other Tagging settings.
Additional Informationhttps://www.mediamonkey.com/forum/viewtopic.php?t=104714
TagsNo tags attached.
Fixed in build2823

Relationships

related to 0018241 closedLudek MMW 5 Device sync: add auto-conversion for artwork files 
related to 0019690 resolvedrusty MMA Artwork sometimes disappears / is missing 
related to 0020323 closedLudek MMW 5 Dimensions cut off on Add Cover with Material Design 

Activities

Ludek

2023-08-06 15:05

developer   ~0072549

Last edited: 2023-08-06 15:33

1) I also can't replicate, I'll ask user for sample files / settings

2) I can confirm cropping on PNG conversion
=> Fixed in 2812

3) This works fine for me, even with both 'Sync all Artwork to file folders' and 'Copy Artwork to file tags' disabled it still converts the artwork that is already in file tags of original files just fine.
Please re-test and share more details in case you are still seeing this.

4) Cropping shouldn't happen at all, just resizing, related to fix of item 2)
=> Fixed in 2812

5) Fixed in 2812

6) This is technically correct, I wouldn't change this

lowlander

2023-08-06 18:09

developer   ~0072550

3) Happens with external Artwork associated with file. It doesn't get Synced at all, embedded Artwork on the other hand does, and does get resized.

Ludek

2023-08-11 09:56

developer   ~0072568

3) Yes, external artwork isn't synced until 'Sync all Artwork to file folders' is checked, this has always been the case, the rationale is that user either wants _all_ or _none_ artwork in the file folders on the device.

lowlander

2023-08-17 15:35

developer   ~0072629

Confirmed fixed 2, 5 on 2812. 1 worked as well.

4) I meant resize. So if you have a 2000 width by 4000 height Artwork and set to 500 Max. resolution you get a 500 by 1000 Artwork. This is unexpected from wording as I'd expect neither height nor width to exceed 500 Max setting (so result should be 250 by 500). Unless wording is changed that Max. width is 500 px.

7) Sync all Artwork to file folders has filename + extension as user setting. This conflicts with the Convert artwork to setting which sets extension. Extension set does not affect outcome (ie. changing it to albumart.png did not create PNG files. Extension should be remove from user setting.

8) Convert artwork to seems to have extra space between label and drop-down.

9) Convert artwork to/Max. resolution are missing tooltip.

Ludek

2023-08-20 15:30

developer   ~0072665

Last edited: 2023-08-20 15:31

Re: 4) You are right, watching the blame function the resize logic has been changed by Michal in 2017 for some reason (to circumscribe square sz x sz)
I'll ask him for the reason(s)
image.png (18,922 bytes)   
image.png (18,922 bytes)   

Ludek

2023-08-20 15:32

developer   ~0072666

Last edited: 2023-08-20 16:48

4) Fixed in 2814

7) Fixed in 2814 (it auto-changes the extension now -- based on the convert settings)

8) Fixed in 2814

9) Tooltip wording to be suggested by Rusty

lowlander

2023-11-02 15:40

developer   ~0073276

10) (maybe related to 4) User file at Ticket 6453 does not resize when set to JPG 500, but does when set to JPG 300.

rusty

2023-11-02 20:25

administrator   ~0073279

3) 'Sync all Artwork to file folders _albumart.jpg_' is enabled by default for all Android/MMA devices, but if I'm understanding Ludek's comment 0020181:0072568, if this is disabled for some reason, then artwork that exists in MMW will not be synced _at all_ to their device. This would be unexpected (and I wonder if it's the root of some of the many complaints online about some artwork getting lost in MMA in certain cases [see 0019690] ).

Would it make sense to:
a) Always sync external artwork to the location described in 'Sync all Artwork to file folders', modifying the UI as follows:
[ ] Sync all Artwork to file folders
Filename for external artwork: _albumart.jpg_

OR

b) Change the string to 'Sync Artwork to file folders' (this was originally suggested at 0008478
AND Force the user to enable at least one of the options re. artwork location (i.e. 'Sync Artwork to file folders' or 'Copy Artwork to file tags' or both) so that tracks on the device don't get handled differently depending on the artwork storage approach?

9) Ludek, does 'Convert artwork to' always apply (i.e. for tagged images)? Or does it only work if 'Sync all Artwork to file folders' is enabled?

10) Reminder that this is still open

Ludek

2023-11-03 13:04

developer   ~0073290

3) I am checking the code and for the Android/MMA devices once user doesn't want to copy artwork to file folders then it is still copied to locations like
/storage/sdcard0/MediaMonkey/artworks/tc/i0/wvz6t5ak.jpg
because MMA cannot read AA from tags

9) Yes, it always applies (also for images in file tags)

10) This is being clarified via the ticket directly

------
Re-assigned to Rusty again to suggest the tooltip in tiem 9)

rusty

2023-11-07 16:54

administrator   ~0073324

3) OK, so iiuc, disabling 'Sync all Artwork to file folders' causes
a) albumart.jpg to not be synced to the album directory for _any_ tracks ?
b) artwork is only then synced to the 'internal' mma directories and is therefore not shared through the Android Media Scanner with other media apps ?

If my understanding is correct then:
i) the text should change to 'Sync artwork to file folders < location>' (since 'all Artwork' implies that if this isn't enabled, that some artwork is still being synced in that manner).
ii) the tooltip should be modified along the following lines:
Copies tagged artwork to folders for devices that don't read image tags
-->
Saves artwork to album folders, for devices and applications that can't read image tags. If disabled, artwork is synced to a location that only MediaMonkey can read.


9) Tooltip for convert artwork / resolution: Syncs all images using the specified format and size

Ludek

2023-11-07 18:19

developer   ~0073335

Fixed in 2823

peke

2024-03-25 12:12

developer   ~0074773

Verified 3007