View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0017858||MediaMonkey 5||Main Panel||public||2021-05-13 09:42||2021-06-25 19:45|
|Target Version||5.0.1||Fixed in Version||5.0.1|
|Summary||0017858: Columns widths are not restored correctly on "Metro M" skin|
|Description||1) Switch to "Metro M (Classic)" skin|
2) enabled all sub nodes for media tree to select idividual artists
3) switch to "List" view
3) whenever you select a different artist from the media tree, the columns get a few pixels wider.
This is reproducable every time I select a new artist and doesn't seem to stop.
Details here: https://www.mediamonkey.com/forum/viewtopic.php?p=481458#p481458
|Tags||No tags attached.|
|Fixed in build||2419|
||I can't reproduce the column widths getting *wider*, but I can reproduce the user's original issue where the column filter gets increasingly taller each time you switch artists.|
||Fixed in 2406|
UNable to replicate in Metro M and other skins.
Re-opened: this issue still exists on "Metro M" skin: https://www.mediamonkey.com/forum/viewtopic.php?p=483055#p483055
I can replicate this way:
1) Select a playlist with columns like this in the 'Media Tree' : https://www.dropbox.com/s/47ep8enwq7h0186/Screenshot%202021-06-24%2013.13.32.png?dl=0
2) Switch to another playlist: Columns get a few pixels wider
3) Switch to the original playlist: Columns gets a few pixels wide again etc.
I don't see this issue with other skins.
EDIT: The same issue is user reporting here: https://www.mediamonkey.com/forum/viewtopic.php?p=483349#p483349
As discussed offline with Michal: Probably the emToPx() and pxToEm() are responsible for that in GridView.storeColumns / GridView.restoreColumns
So assigned to him to verify and possibly to not do this conversion at all (and store the width always just in pixels rather than ems) ?
EDIT: It's combination of Math.round in emToPx and Metro M's @baseFontSize defined as 12.25px, ie. changing it to 12px solves the issue and should be low risk change as 5.0.1 fix
Fixed in 126.96.36.1999 by changing the Metro M's @baseFontSize: from 12.25 px to 12 px.
@drakinite: please review my change.
||Reviewed and verified from SVN source.|
||Tested on 2419 with Ludek's steps and no column width drift observed.|