View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0017183 | MMW 5 | Main Panel: Toolbars & Menus | public | 2020-12-07 13:54 | 2021-05-27 19:16 |
| Reporter | drakinite | Assigned To | |||
| Priority | urgent | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 5.0 | ||||
| Target Version | 5.0.1 | Fixed in Version | 5.0.1 | ||
| Summary | 0017183: Performance issue - Large popupmenus take up to a full second to open | ||||
| Description | Some context menus take a long time to open, especially on slow systems. The worst ones come from right-clicking music in grid view or list view. There doesn't appear to be a single culprit that causes lag; but there's a lot of looping code that causes quite a bit of delay on large menus with a lot of items. | ||||
| Additional Information | https://www.mediamonkey.com/forum/viewtopic.php?f=30&t=99126 | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 2408 | ||||
|
|
I'm not quite sure how I was able to test the context menu timing back when I reported this. Now, on build 2401, I'm finding that the *contextmenu event itself* has an enormous delay on large tracklists. I have no idea what causes it. |
|
|
Note: In the album grid view, clicking the ⋮ on a track causes the full menu to open almost instantly, further hinting that the original suggestion (lots of looping code when opening the tracklist menu) is not correct. The large menu creation itself is not slow, but something causes the right-click event to fire much slower in tracklists. (Additional note: It's also not due to sheer size of tracklists or lots of divs. I can recreate the delay on a collection that contains only three songs, even after completely restarting the interface.) Edit: Right-clicking in the empty space at the bottom of a tracklist results in the menu showing up immediately. The delay only occurs when clicking a tracklist ITEM. |
|
|
I agree that this needs to be debugged _asap_ (to find what is causing the lag) EDIT: The reason is usage disabled: notLocalMediaListSelected in many actions. For every action the 'notLocalMediaListSelected' is called again and it is causing the lag. Solution should be to cache the result of notLocalMediaListSelected function |
|
|
Further debugging shown that the lag was introduced while fixing 0014673 (SVN revision 30796) in popupmenu.js |
|
|
Fixed in 2408 |
|
|
Verified 2408. The performance improvement is VERY nice; feels much nicer to use MM now without that menu delay. :) |
|
|
Verified on 2408 |
