View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0015464 | MMW 5 | Tagging / organizing (properties / auto-tools) | public | 2019-02-15 04:54 | 2019-09-26 19:20 |
| Reporter | rusty | Assigned To | |||
| Priority | urgent | Severity | feature | Reproducibility | always |
| Status | closed | Resolution | reopened | ||
| Product Version | 5.0 | ||||
| Target Version | 5.0 | Fixed in Version | 5.0 | ||
| Summary | 0015464: Auto-tag: dialog can't be used effectively while lookups are in progress | ||||
| Description | Currently, when lookups are in progress, the auto-tag dialog can't be used because tracks are continually moving around (due to sorting/grouping) as tracks are looked up. This makes it difficult to: - know which tracks have been updated and which haven't - review tracks in their entirety because tracks get moved prior to the track that's being reviewed - edit/verify properties of tracks that have been looked up because they get moved around even as they're being edited Possible approaches discussed to solve this: a) don't auto-group tracks. Rejected because the result would be unfriendly for grouped tracks (albums). b) don't display the auto-tag editor until the metadata lookup is complete. i.e. just show a status bar indicating x/y lookups complete as the lookups progress) and then display the UI once the batch is looked up, but with placeholder artwork (artwork lookups should only begin _after_ metadata lookups are completed because they can be looked up even as the user starts performing edits since it doesn't affect grouping, and delaying the artwork until metadata is complete will speed the metadata lookups). This could have the additional benefit of keeping the user's focus on the still-useful MM UI (instead of the auto-tag dialog which isn't very useful as the lookups proceed). c) pause auto regroup when any combo is expanded ... so it will not regroup when you start editing (petr's suggestion--not sure I understand) This isn't critical--but if taking the approach of b) would also solve the problem and improve performance, it would yield a better experience. We should only include in 5.0 if this is easy/low risk. | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 2202 | ||||
|
|
Approach c is already implemented (there were regression in 2159). Simply when user click on any field to show editor (like title field or album field etc.) auto-tag lookups will continue BUT tracklist stops regrouping until editor will be closed. When editor will be closed without any change, then regrouping continue ... when user makes any change, then toast with info about manual regroup appear and auto-tag stop regrouping till user presses F5. |
|
|
Tested 2160 and it's better, though there are still issues. If the user edits tracks as lookups are happening: 1) then when they get to the 'bottom' there is a single album art image with e.g. 30 tracks, and the user may not realize why (it looks like a bug, even though F5 resolves it). 2) When the user then presses F5, the tracks are resorted/regrouped and so the user has to restart reviewing/editing tracks from the first one, and this ends up not saving much time. If we continue with this approach, then we can solve both issues by: a) showing the F5 popup again when the lookup is complete (assuming the user has editing tracks without pressing F5) b) when grouping/sorting is 'paused' don't group all tracks with a single album. Instead show the album art that's looked up for each track. That way the user can continue reviewing all of the tracks without having to press F5. |
|
|
Item a implemented. re b) but by default tracks are grouped by albums (including tracks with unknown album) and after edit we shouldn't regroup to all tracks without album are separated. |
|
|
In build 2186 it's still difficult to edit tracks as they're being looked up because as soon as a track is edited, newly looked up tracks don't appear sequentially in the list. See below to better understand: https://www.screencast.com/t/PfdDUOx8Czz |
|
|
auto grouping go suspend once you change any value ... you think auto grouping should be enabled once editing is done, but without resorting (so tracklist will not move) ? |
|
|
I'm saying that once the user starts making edits: - All tracks that are looked up should appear in the same order in which they appear - No additional tracks should be auto-grouped - Tracks that are looked up or manually edited to a new/different album should be removed from their existing group so that Album Art can be displayed for the track in question. In such cases the track should appear immediately following the current group within which it was contained. - No additional tracks should be auto-sorted (including tracks that are looked up or manually edited) - F5 (reset) would auto-group / auto-sort the list and re-enable auto-grouping/sorting until the user makes another edit afaik, this is the only way to make editing of the dynamically updating tracklist usable. |
|
|
Fixed |
|
|
Verified 2202. |
