View Issue Details

IDProjectCategoryView StatusLast Update
0009389MMAAction barpublic2012-09-13 04:09
Reporterjiri Assigned To 
PriorityurgentSeverityminorReproducibilityalways
Status closedResolutionfixed 
Target Version1.0.1Fixed in Version1.0.1 
Summary0009389: Consistent context action bars
Description1. Action bars usage should be consistent. They should always appear after a long-press on an item and kept on screen until either the selected items are deleted or user presses Done button.

2. Checkboxes states should be preserved while changing orientation of the phone (from horizontal to vertical and vice versa).
TagsNo tags attached.
Fixed in build29

Relationships

related to 0009578 closedmarek Jellybean: context menus don't display as expected 
parent of 0009674 closedjiri Properties function works differently from one category to another 

Activities

marek

2012-05-31 15:36

developer   ~0031267

implemented 2)

marek

2012-06-08 10:37

developer   ~0031328

Implemented unified delete dialog

rusty

2012-09-07 17:10

administrator   ~0031825

1) and 2) are working correctly in build 24, however:

3) the context menus don't seem to be displaying consistently across different views:
- the commands differ from view to view
- the order of the commands differ from view to view

For example:
Albums: Delete, Playlist, Add to Now Playing, Set as..., Properties
Album>Track: Delete, Playlist, Add to Now Playing, Share, Set as..., Properties
Artist: Delete, Playlist, Add to Now Playing, Set as..., Properties
Tracks: Playlist, Delete, Add to Now Playing, Set as..., Properties
Genres / Composer: Delete, Playlist, Add to Now Playing, Properties

I would suggest that we consistently use the following order (though I'm open to an alternative, as long as we use a single approach consistently):
Add to Now Playing, Add to Playlist, Delete/Remove, Set as..., Share, Properties

jiri

2012-09-07 22:31

administrator   ~0031841

Fixed in build 27.

rusty

2012-09-10 01:49

administrator   ~0031868

Tested build 27, and a few items remain:

4) Share isn't implemented for anything but Album > Track view!!
5) Properties function isn't implemented for several categories and is implemented incorrectly in various cases (described fully at 0009674)
6) Shouldn't functions that apply to only a single track (i.e. Set as...) be enabled for a category node if that category node only contains a single track?
7) Playlist entries' context menus have two 'Add to now playing' buttons
8) Is there a reason why UPnP tracks have both Play and Queue buttons, whereas local tracks only have a Queue button?

jiri

2012-09-10 13:50

administrator   ~0031882

Fixed in build 29.
 5) To be handled in 0009674.
 6) I think that it wouldn't be consistent.
 8) Removed. That said, we could consider adding Play button instead to all activities. This way, user could send to NP a selected set of tracks and start its playback immediately. Not sure whether it's worth of a new action and one place in the contextual menu though...

rusty

2012-09-12 01:45

administrator   ~0031939

Tested build 28
4) Kind of fixed. Now implemented for all Tracks (but not any higher level nodes). I assume that was intentional?
7) Fixed.
8) Not Fixed.

jiri

2012-09-12 07:53

administrator   ~0031943

Fixed in build 29.
 4) Although probably not too useful, it's possible to implement for other items as well. We can do it sometimes...
 8) Fixed.

rusty

2012-09-13 04:09

administrator   ~0031960

Verified 29.