View Issue Details

IDProjectCategoryView StatusLast Update
0007438MMW v4Install/Configpublic2020-11-19 05:37
Reporterrusty Assigned To 
PriorityimmediateSeverityfeatureReproducibilityalways
Status closedResolutionfixed 
Target Version4.0Fixed in Version4.0 
Summary0007438: Automated download of localization files
DescriptionIt should be possible for a user to install MM in any of the languages for which translations exist.

A possible mechanism for this would be to:
a) include the install.po files for all languages, so that users can choose whatever languages have been translated
b) upon completion of the installation process, the full .mmip file is installed and the appropriate language configured.

This would remove a barrier that exists for many non-English speakers who have trouble understanding how to install and subsequently configure the current .mmip files.
TagsNo tags attached.
Fixed in build1357

Relationships

related to 0006493 resolvedrusty MMW v4 Automated codec installation/purchase mechanism 
related to 0005314 closedpeke MMW v4 WebHelp: Switch to web-based help 
related to 0007541 closedpeke MMW v4 Transcription errors in installer strings (Regression) 
parent of 0007500 closedpeke MMW v4 Selected laguage in installer not shown in Options 
has duplicate 0005313 closedpeke MMW v4 Make languages downloadable via the installer 
related to 0007491 closedpeke MMW v4 Portable mode text is unclear 
related to 0007592 feedbackpeke MMW v4 Installer language string customizations should be translated automatically 
related to 0017116 closedpetr MMW 5 Installation / Config localization requirements 

Activities

rusty

2011-02-23 17:03

administrator   ~0023349

Last edited: 2011-02-23 17:05

Set to 'immediate' to determine if any new strings are required.

e.g.

'Downloading language files for:' <language>

'Failed to download language files for:' <language>

jiri

2011-02-28 11:16

administrator   ~0023447

Last edited: 2011-02-28 11:19

Since InnoSetup doesn't have any build http download features, the easiest way would probably be to add new features to MM.exe:
1. Add a new MM command line parameter /InstallLanguage=xx that would download and install a MMIP package from http://www.mediamonkey.com/sw/lang/xx.
2. MM.exe would return a non-zero error code in case of download failure - in which case the installer would show appropriate message.
3. Note that currently Addons installation supposes that MM is fully started with UI. This command line installation expects that no UI would be involved (including success or failure messages in MM). In case it would be too complicated to make the current code compatible with such a UI-less mode, we could make a simplified version targeted to languages installation only - it would disregard install.ini file and only unpack content of the .MMIP (i.e. ZIPped) package.


When this is completed we only need to:
4. Add a new sheet showing the 'Downloading...' message and calling the above functionality.
5. Modify MediaMonkey-Main.iss file so that it includes all the supported languages. Note that currently we use many ifdefs for this purpose, but since newer InnoSetup versions have CustomMessages section with multi-language support, we could significantly simplify all this.

Ludek, when 1-3 is done, feel free to assign 4-5 to Petr, who better knows InnoSetup (but you can do it yourself, if interested).

Ludek

2011-03-02 15:25

developer   ~0023496

Items 1-3 are done, assigning 4-5 to Petr

rusty

2011-03-02 18:37

administrator   ~0023498

Raising priority so that strings can be finalized.

petr

2011-03-03 15:47

developer   ~0023525

Installer functionality is implemented. Assigning to Peke to make isl files for installer (based on install.po files).

peke

2011-03-07 12:32

developer   ~0023591

All .isl created and I also corrected Serbian and Chinese according to http://msdn.microsoft.com/en-us/netframework/dd890508.aspx

peke

2011-03-07 12:35

developer   ~0023592

Note: Hungarian.isl is completely untranslated as install.po was missing.

jiri

2011-03-08 23:11

administrator   ~0023610

Last edited: 2011-03-08 23:15

Missing features:
1. Some languages aren't complete, e.g. "Chinese(Simplified).isl" contains custom messages only, not all of them (downloaded from InnoSetup web).
2. English.isl doesn't have all the custom messages. Actually, all of the .isl files should have them, so that they are properly shown even in case they aren't translated for the language yet.
3. Note that .isl files are in specific codepages (see LanguageCodePage=xxxx identifier), so we should make sure that our added messages are in the correct page.

peke

2011-03-08 23:15

developer   ~0023611

Assigning to Petr to clear what exactly is needed.

peke

2011-03-08 23:23

developer   ~0023612

Reassigning to me after IM talk with Jiri

jiri

2011-03-09 15:20

administrator   ~0023618

4. Some languages fail to download (requires further investigation--perhaps links are incorrect?)

jiri

2011-03-09 16:19

administrator   ~0023620

4. I found out the reason, it's because e.g. Finnish.mmip install script wanted to install Tips.mo file, but it is no longer part of the MMIP file. So the install failed. I fixed Finnish.mmip, but other languages need to be tested and fixed if necessary. Peke, please test all of them.

peke

2011-03-09 22:00

developer   ~0023628

Updated all languages, I have also moved [CustomMessages] to top part of file and surrounded MM custom Messages around:

; Start of MediaMonkey Custom Messages
; ---------------------------


; End of MediaMonkey Custom Messages
; ---------------------------

So that hey can be easily found and updated later.

peke

2011-03-09 22:44

developer   ~0023629

Added PortableModeTooltip= to MM custom messages for all languages.

peke

2011-03-09 22:56

developer   ~0023630

correct codepages are added to all isl files from http://www.mydigitallife.info/2007/08/12/ansi-code-page-for-windows-system-locale-with-identifier-constants-and-strings/ so that those that have localized windows will correctly switch codepage even for english.

peke

2011-03-09 23:34

developer   ~0023631

Last edited: 2011-03-09 23:34

all fixed.

peke

2011-03-17 23:11

developer   ~0023774

Last edited: 2011-03-17 23:14

Reoppen after IM talk with Petr that Original files that come with InnoSetup should not be included but our custom .isl files should be appended with translation within MediaMonkey-Main.iss script for each language.

Included and external .isl files for MM languages can be found here
http://www.jrsoftware.org/files/istrans/

petr

2011-03-23 18:17

developer   ~0023853

Gege's PTBR language file updated in 1357

peke

2011-03-24 21:27

developer   ~0023875

Corrected all languages and main iss script, InnoSetup folder was lacking original language files. Now all language isl files are contained in their respective folders

peke

2011-04-05 18:51

developer   ~0024062

Originally fixed in 1353 and fully corrected using unified folder structure and files in 1357
As of 1357 Setup uses new unified language folder structure and from now on it is much easier to manage and translate.

peke

2011-04-05 18:53

developer   ~0024063

Reminder sent to: petr

Can you please close it as you have confirmed that main iss script compile without problems as of 1357.

peke

2011-04-10 01:37

developer   ~0024168

Verified 1362