View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004410 | MMW v4 | Properties/Auto-Tools | public | 2008-02-19 22:49 | 2010-12-10 23:46 |
| Reporter | peke | Assigned To | |||
| Priority | immediate | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Fixed in Version | 4.0 | ||||
| Summary | 0004410: Tags (all attributes) are written even nothing is changed in Properties. | ||||
| Description | According to ticket http://www.mediamonkey.com/support/staff/index.php?_m=tickets&_a=viewticket&ticketid=140 which behavior I can confirm rating is updated in file (when the rating is set to 78 or 79 instead of 80, MM 'corrects' it to 80). But it should be ignored and not written. | ||||
| Additional Information | Also reported here: http://www.mediamonkey.com/support/staff/index.php?_m=tickets&_a=viewticket&ticketid=8148 | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1329 | ||||
|
|
Assigning to Rusty to confirm Bug. |
|
|
Jiri, any reason for this? (note: I haven't tried to reproduce this since Peke has already confirmed that the issue exists). |
|
|
I think that it has always been this way - i.e. if user clicks OK, all values in text boxes (even if nothing has been changed) are applied, stored in DB and updated in tags. Anything else would require more complex handling, and would probably rather be a source of problems. |
|
|
I think we've discussed this issue wrt album art and concluded that this is something that we should eventually fix. i.e. The only time that a field should be saved is when that particular field has changed. This implies that: -Tags shouldn't be updated when clicking Arrows on the property dialog -Tags shouldn't be updated when clicking 'Ok' unless specific attributes have changed |
|
|
This would be a nice to have for MM 4.0 - i.e. to compare the new and the old values and perform the save only in case there has been any change. Has to be thoroughly tested for regressions! |
|
|
Possible solution would be to Use one Boolean that will control/check if user Changed value of each Edit Field while user is focused on field instead of comparing all tag data on pressing arrows or OK. Like you said this needs to be toughly tested. |
|
|
Raised to immediate, because due to 0006382 this is quite annoying issue. |
|
|
I wonder we add brute-force Metadata length value along with edited boolean flag returned from properties dialog (in most cases it already catches when field is edited or checkbox is checked) could that be faster than comparing each field independently? |
|
|
Fixed in build 1329. |
|
|
Verified 1333 |
