View Issue Details

IDProjectCategoryView StatusLast Update
0003373MMW v4Synchronizationpublic2007-09-11 03:26
Reporterrusty Assigned To 
PriorityimmediateSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version3.0 
Fixed in Version3.0 
Summary0003373: Auto-sync list: cleanup in relation to support for multiple types of content & filters
Description1) Change Auto-Synchronization list to Auto-sync list

2) Add a new Audiobooks tab since these aren't music nor podcasts, and have special requirements for synchronization. Order is: Music, Audiobooks, Podcasts.
. . The Audiobooks tab will contain whatever Tracks first match a Filter that is considered an 'Audiobook' (i.e. Treat as Audiobook is enabled).

3) Fix the Music tab so that it doesn't contain tracks within other tabs. i.e. Currently user can accidentally select all podcasts even when the Podcast tab has nothing selected:
. . The Podcasts tab will contain whatever matches the Podcast filter(s) (see item 4 below)
. . The Music tab should contain whatever matches the active Music filter (Music filters are those that aren't treated as Podcasts or Audiobooks (see item 4 below)

4) The Filtering functionality (bug 0000553) will need to add a means to map between content type audiobook and the filter. i.e.
------------------------------------------------------------
Filter & View Options
------------------------------------------------------------
 Name: _______________________________
------------------------------------------------------------
| Criteria | View | [Rules] |
 -----------------------------------------------------------
 [ ] Enable Bookmarking
 [ ] Ignore Shuffle
 [ ] Disable Crossfading
 
 [x] Sync as _Music_^ ([Music], Audiobook, (Podcast) )
 ------------------------------------------------------------
------------------------------------------------------------
 [Import Settings] [OK] [Cancel]
------------------------------------------------------------

Note:
-If the user syncs as 'Music' then the content would appear under the Music tab, and the filter would be active under the music tab.
-If the user syncs as 'Audiobook' then it would appear under the audiobook tab (assuming it's the first match), and the filter wouldn't be listed in the list of filters in the music tab, and this info could be used to convert the tracks to m4b once we add that feature.
-If the user syncs as 'Podcast' then it would appear under the podcast tab (assuming it's the first match), and the filter wouldn't be listed among the filters on the music tab.

5) The counters need to be cleaned up so that it is clear what they are measuring (currently, the Music Tab counter shows '5 Files, 1.7 MB, 3:39' even when no music is selected, even if the user tries to see which tracks are checked). We should:
. i) on the music tab: only show counter for music; on the Audiobook tab: only show counter for audiobooks; on the podcast tab: only counter for podcasts
. ii) to the left of the OK/Cancel buttons, show 'Total: x Files, x MB, hh:mm' when on the Auto-Sync List tab

6) In the 'Music Tab', the sync random subset option needs to be clarified:
 [ ] Sync random subset of selected tracks up to device capacity

7) Optional: Filter:________^ _Show All_^ for Podcast/Audiobook tabs so that there's support for multiple filters. We've agreed to defer this for now.

Note: We'll leave CD Burning as is for now
TagsNo tags attached.
Fixed in build1071

Relationships

related to 0000553 closedpetr Enable Basic Tree / Column customization 
related to 0002908 closedLudek Remove buttons/clutter in Auto-sync list panel 
related to 0002937 closedLudek Auto-Sync: Isn't useful for selecting some types of Music (e.g. classical, unsubscribed podcasts) 
related to 0003374 closedLudek Autosync List Filters don't actually filter tracks 
related to 0003521 closedLudek Audiobooks handling needs to be changed also in iPod plugin. 
related to 0003559 resolvedLudek Podcasts don't sync if 'Random Subset' is used for a full device 

Activities

rusty

2007-08-10 04:13

administrator   ~0010088

Last edited: 2007-08-10 15:37

Comment from Jiri:
3) It could be quite problematic to 'somehow' implement this, I think that it should be accomplished without using any exceptions or so. The idea is to:
3a) Don't show 'none' filter in Music tab, so that there's no chance of seeing Podcasts, etc. there.
<RS> I actually disagree on this point. I think that 'none' is useful here, and that users would interpret it to mean None less Podcasts and Audiobooks.

3b) Show filters specified by user to be 'Music' filters, and rely on the fact that they won't contain Podcasts (by it can happen if user constructs a filter this way).
<RS> Agreed.

7) I'd rather see this implemented, but since it would take some time, let's suppose it won't be. In such case though, we should change some things a little:
7a) Podcasts sheet shouldn't be filtered at all, i.e. it would show content of the Podcasts node in MM tree. Otherwise, user would have to create some filters, just in order to see all Podcasts in synchronization dialog.
<RS> Agreed. As discussed this implies that Synch as 'Podcast' in 4) isn't needed for now.

7b) Audiobooks tab should probably contain the union of all filters designated as Audiobook. Otherwise, e.g. if user has two filters German Audiobooks and English Audiobooks, he would have to create a new super-filter Audiobooks in order to see all available Audiobooks for synchronization, even though he wouldn't need/use this filter at all.
<RS> Agreed.

rusty

2007-08-13 19:41

administrator   ~0010124

I just thought of a potential issue (a minor one though); The 'Advanced' functionality which allows for the creation of custom masks won't function for the Podcast and Audiobook nodes. This means that it will be impossible to set custom synch settings for Audiobooks and Podcasts.

Not a huge issue, but something to keep in mind...

Possible solution: A 'Synch to...' button

Ludek

2007-08-15 10:35

developer   ~0010136

Last edited: 2007-08-15 10:46

The items 1,2,3b,4,5,6,7a,7b have been implemented in build 1060.

Content type: ([General Music], Audiobook, Podcast )
changed to
Content type: ([General Music], Audiobook, None)

Ludek

2007-08-15 20:35

developer   ~0010141

Last edited: 2007-08-15 20:36

Finished also item 3) excluded Podcasts and audiobooks from music tab (Fix the Music tab so that it doesn't contain tracks within other tabs) as suggested by Rusty.

Build 1060.

jiri

2007-08-17 19:14

administrator   ~0010178

Leaving it resolved for Rusty's testing, some comments though:
1. Audiobook tab seems to be depandant on Music tab, e.g. expanding Artist tab there expands it on Music tab too. Even bigger problem is that Advanced checkbox isn't on AB tab, but has effects there! It would probably make sense to add this checkbox to AB tab?
2. I'd probably remove Playlists node from AB tab tree, since it already is in Music tab. Or, maybe even more logically, create a new tab for Playlists? However, it would probably introduce more new problems.

rusty

2007-08-20 16:07

administrator   ~0010209

Tested in 1061. It's generally good, but there are a fair number of major issues remaining (listed in order of priority, with Jiri's feedback embedded as well):

1. Filter on the Music tab is initially blank (which is fine as this implies no filter). However:
i) In addition to 'blank' filter, there is also a 'None (show all tracks)' option. We should probably only have the latter.
ii) When the 'None (show all tracks)' option is selected, the list of available nodes changes and removes some valid options from the list! (in my case it removed my C: drive!!)
iii) When switching to 'None (show all tracks)' the Music counter is sometimes inaccurate. I assume that this is just a side effect of item ii).

2. Audiobook tab seems to be depandant on Music tab, which has a couple of side effects--some of them very nasty:
i) Deselecting 'Album' (or other top level nodes) causes all audiobooks to be deselected!
ii) Expanding Artist tab there expands it on Music tab too
iii) Even bigger problem is that Advanced checkbox isn't on AB tab, but has effects there! Jiri indicated that it would probably make sense to add this checkbox to AB tab. (note: this might create conflicts between advanced rules from one tab to the other--we'll just have to decide on an order of precedence for now).

3. Jiri suggested removing Playlists node from AB tab tree, since it already is in Music tab. (Or, maybe even more logically, create a new tab for Playlists? However, it would probably introduce more new problems.)

4. In the AudioBooks tab, there is no checkbox next to Location, Artist, Album, Album. This works out well as it eliminates the biggest problem with the current implementation. I was wondering if it would make sense to do the same in the Music tab, and at the same time, add the following new nodes:
On Music tab: First node at the top: [ ] All Music
On Audiobooks tab: First node at the top: [ ] All Audiobooks

jiri

2007-08-20 21:13

administrator   ~0010218

Assigning to Ludek, items 1-3 seems to be clear and need to be fixed, let's discuss 4 over IM in case you have any idea about it.

Ludek

2007-08-23 16:40

developer   ~0010275

Last edited: 2007-08-24 09:20

Items 1-3 fixed in build 1063.

Re 4)
I like the idea and I think that it will be ok, because the tabs are mutualy exclusive now,
i.e.

On Music tab: First node at the top: [ ] All Music
On Audiobooks tab: First node at the top: [ ] All Audiobooks
On Podcast tab: First node at the top: [ ] All Podcasts

Ludek

2007-08-27 12:35

developer   ~0010374

Last edited: 2007-08-27 12:42

News in build 1066:

Added Playlists as a single tab, fixed an AVs and a critical bugs,
added
On Music tab: First node at the top: [ ] All Music
On Podcast tab: First node at the top: [ ] All Podcasts

The only that remains to do is:
On Audiobooks tab: First node at the top: [ ] All Audiobooks

Marked as resolved for testing by Rusty, in case of need assign back to me to implement the last thing that remains to do ([ ] All Audiobooks)

rusty

2007-08-27 20:16

administrator   ~0010394

Tested 1066: everything is looking good except for the fact that when the user selects All Music with any Particular filter active, it causes all the checkboxes to be enabled, and then when it is unselected, it causes the checkboxes to be disabled--even those from other filters!

I would suggest that the behaviour of the 'All Music' node be a bit non-standard and that it be treated independently of what is selected elsewhere in the tree (that was my intent of using an "All music" node instead of the other nodes). If the user enables all music:
--> The checkboxes in the rest of the tree are greyed out, but there's no change in selection status.
If the user disables all music
--> User can edit the selection of the subnodes

This is kind of how MM 2.5 operates. That way the user has the option of enabling/disabling the node, without compromising selections across filters.

Ludek

2007-08-27 21:22

developer   ~0010398

Last edited: 2007-08-27 22:02

I guess that you are trying to do a regression. I think that current behaviour is much better:

1. User can deselect all nodes at once (it replaced previously used [Uncheck all] button - bug 0002908)

2. User can select all artists at once and then only unticked the artists that he wouldn't like to synch (same for albums and locations). - some users requested this feature on a forum (see http://www.mediamonkey.com/forum/viewtopic.php?t=16322 ).

It was the intend, isn't it??

jiri

2007-08-27 22:38

administrator   ~0010399

I tend to agree with Ludek, I think that it works well. I'd say that the only minor glitch is if I select an item (e.g. some Artist), then All Music node should get into that middle state - like e.g. C:\ node does when C:\mp3 folder is ticked.

Ludek

2007-09-02 16:11

developer   ~0010438

Fixed in build 1068:

1. Fixed the 'All Music node should get into that middle state'

2. Added 'Show checked/All' box also to Playlists tab.

3. Moved 'Synch random subset' checkboxes under Synchlist tabs, because it is common for all the tabs.

rusty

2007-09-07 15:44

administrator   ~0010575

 Re. 3. Moved 'Synch random subset' checkboxes under Synchlist tabs, because it is common for all the tabs.' Can you explain--'random subset' is only supposed to apply to the 'Music' tab, isn't it?

i.e. it doesn't make sense to sync a random subset of audiobook or podcasts since they're usually sequential...

rusty

2007-09-07 20:39

administrator   ~0010596

Discussed further with Jiri and we agreed that 'Sync random subset' should only apply to Music and Playlists.

==>
'Sync random subset of selected Music and Playlists up to device capacity' should appear as a single setting.

(A second possibility that was rejected (possibly too complex) is to include 'Sync random subset of selected Tracks up to device capacity' on both the Music and Playlists tabs, and ensure that synchronization occurs in a round robin fashion between the contents of any tabs that are set to sync randomly. )

Ludek

2007-09-09 12:36

developer   ~0010623

Fixed in build 1071.

rusty

2007-09-11 03:26

administrator   ~0010668

Verified 1071