View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002954 | MMW v4 | Properties/Auto-Tools | public | 2007-03-27 20:43 | 2008-11-27 05:30 |
| Reporter | rusty | Assigned To | |||
| Priority | immediate | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 3.0 | ||||
| Fixed in Version | 3.0 | ||||
| Summary | 0002954: FLAC: some fields aren't saved to tags / saved incorrectly | ||||
| Description | The following fields aren't saved to the tag. They should be, in a standards-compliant manner (where possible): Disc# Lyrics Album Gain Release Date (update from Year) -- did not test this BPM Involved People Original Artist Original Album Title Original lyricist Tempo Mood Occasion Quality Custom1 Custom2 Custom3 | ||||
| Additional Information | Please clearly document in the bug: 1) Any changes being made 2) A complete list of all MM Fields with associated Tag(s) being used in MM (this will be used to update user documentation) | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1050 | ||||
|
|
re. Album Gain - Users would like the same standard as in Foobar to be used. |
|
|
Assigning to Peke to: 1) Suggest where to store fields described here (based on 'standards' made by other applications - like Foobar). 2) Document the current mapping of fields to tags. |
|
|
1) Please Document CONST Values missing in Above mentioned Fields so that I can update Plugin. 2) Current list And Changes To F_FLAC Can Be found in \F_FLAC\constants.pas, but here is List for easier documentation: Strings: -------- 1. (FF_Title) = 'TITLE' 2. (FF_Artist) = 'ARTIST' 3. (FF_Album) = 'ALBUM' 4. (FF_Genre) = 'GENRE' 5. (FF_Comment) = 'COMMENT' 6. (FF_Publisher) = 'ORGANIZATION' 7. (FF_CopyRight) = 'COPYRIGHT' 8. (FF_ISRC) = 'ISRC' 9. (FF_Encoder) = 'ENCODER' 10. (FF_Composer) = 'COMPOSER' 11. (FF_Lyricist) = 'LYRICIST' 12. (FF_Conductor) = 'CONDUCTOR' 13. (FF_Band) = 'ENSEMBLE' 14. (FF_Subtitle) = 'PART' Integers: --------- 15. (FF_TrackNumber) = 'TRACKNUMBER' 16. (FF_Year) = 'DATE' (In case it is in format yyyy-MM-DD only year is read) 17. (FF_Rating) = 'RATING' Doubles: -------- 19. (FF_RGtrackPeak) = 'REPLAYGAIN_TRACK_PEAK' (According to Footbar2000 and Replay gain) 19. (FF_RGtrackgain) = 'REPLAYGAIN_TRACK_GAIN' (According to Footbar2000 and Replay gain) Extended: --------- 20. (FF_Band) = 'ALBUM ARTIST' (Compatibility Issue) |
|
|
As FLAC uses Vorbis structure we should make is same as for OGG? |
|
|
Yes, it should work pretty much as OGG does (see 0002951 for description of all mappings or look directly in f_ogg.cpp source). For all field names check out FormatsHeader.pas. Also don't forget to properly split/join mutli values fields, i.e. if MM wants to store Artist as 'Artist1;Artist2', they should be split as ARTIST=Artist1 and ARTIST=Artist2 and then again joined when the field is read from tag. |
|
|
I have made Multi artist support like you suggested, but it looks that it has problems with Cowon players (tested on friends Cowon D2) which picks up only last ARTIST= written in tag. Will have Cowon D2 again on Monday to test with reversed Artists where First Artist will be written last in tag. |
|
|
Another issue: Album Gain tags don't seem to be saved to the tag. |
|
|
I'll update SVN Later Today, as I extended testing little bit more to ensure everything is OK with Implementation. |
|
|
SVN Updated and Tested with these additional metadata fields. MM3 Fields: ------------ 21. (FF_DiskNumber) = 'DISCNUMBER' 22. (FF_DiskNumber) = 'DISC' Compatibility Issue 23. (FF_RGalbumgain) = 'REPLAYGAIN_ALBUM_GAIN' (According to Footbar2000 and Replay gain) 24. (FF_Lyrics) = 'LYRICS' 25. (FF_BPM) = 'BPM' 26. (FF_OrigYear) = 'ORIGINAL YEAR' 27. (FF_OrigArtist) = 'ORIGINAL ARTIST' 28. (FF_OrigTitle) = 'ORIGINAL TITLE' 29. (FF_OrigLyricist) = 'ORIGINAL LYRICIST' 30. (FF_InvolvedPeople) = 'INVOLVED PEOPLE' 31. (FF_Tempo) = 'TEMPO' 32. (FF_Mood) = 'MOOD' 33. (FF_Occasion) = 'OCCASION' 34. (FF_Preference) = 'QUALITY' 35. (FF_Custom1) = 'CUSTOM1' 36. (FF_Custom2) = 'CUSTOM2' 37. (FF_Custom3) = 'CUSTOM3' 38. (FF_Custom4) = 'CUSTOM4' 39. (FF_Custom5) = 'CUSTOM5' |
|
|
It seems that regular Track Gain tags are being saved instead of Album Gain tags. Here's what happens: 1) Analyze Volume for an Album --> Track gain is calculated and set for each track --> All Tracks are calculated with an Album Gain of -1.1 2) Remove tracks from the DB 3) Rescan the tracks -->The Album Gain field for all of the tracks shows a value identical to the Track gain value. |
|
|
Fixed in build 1050. |
|
|
Need to add support for 'Grouping' (see 0003258) |
|
|
Need to add support for 'Grouping' (see 0003258) |
|
|
This has already been resolved some time ago, now all tagging fields are covered by automatic regression testing. |
|
|
Verified 1195. |
