View Issue Details

IDProjectCategoryView StatusLast Update
0002370MMW v4Otherpublic2007-10-14 23:51
Reporterrusty Assigned To 
PriorityimmediateSeveritytweakReproducibilityalways
Status closedResolutionfixed 
Fixed in Version3.0 
Summary0002370: Rationalize Masks implementations across the product
DescriptionThe new mask implementation used for CD Buring (see 0002062) is cleaner and should be used across the product. This involves a couple of changes:

1) Improve the reference implementation for CD burning as follows:
a) Whenever the cursor is active within a mask, the list of masks should be shown. (i.e. the '>>' button should be pressed and stay pressed automatically as long as the cursor is in the mask combo box). This way the user can see all available masks, grouped, with explanations, whenever they are needed.
b) Add a splitter above 'Help'

2) For the dialogs that have both a 'Directory chooser' and a 'Format chooser' (i.e. for Auto-organize, Rip, & Convert), split the mask in the same manner as has been done for the Virtual CD. i.e.
Destination:_.\_____________^ [Browse]
Format: ____________________^ [>>]

Alternatively, embed 'Choose directory...' as the first entry within the 'Mask Selector' (which would slightly change item 3) below).

3) For Disc Format (in burn dialog), Auto-organize, Rip & Convert, Use:
 <Title>
 <Filename>
 <Track#>
 <Auto Number>
 <Random>
 -----------
 \ (directory)
 - (splitter)
 -----------
 <Artist>
 <Album Artist>
 <Album>
 <Genre>
 <Year>
 <Composer>
 <Bitrate>
 <BPM>
 <Folder>
 <Custom1>
 <Custom2>
 <Custom3>
 ----------
 Help

4) For 'CD Playlist format' & 'Synchronize Tracks to' use the same as above but with <Playlist> added:
 <Title>
 <Filename>
 <Track#>
 <Auto Number>
 <Random>
 -----------
 \ (directory)
 - (splitter)
 -----------
 <Playlist>
 <Artist>
 <Album Artist>
 <Album>
 <Genre>
 <Year>
 <Composer>
 <Bitrate>
 <BPM>
 <Folder>
 <Custom1>
 <Custom2>
 <Custom3>
 ----------
 Help

5) For Auto-Tag from Filename (remove filename, folder, random, auto number):
 <Title>
 <Track#>
 -----------
 \ (directory)
 - (splitter)
 -----------
 <Playlist>
 <Artist>
 <Album Artist>
 <Album>
 <Genre>
 <Year>
 <Composer>
 <Bitrate>
 <BPM>
 <Custom1>
 <Custom2>
 <Custom3>
 ----------
 Help

6) For Virtual CD and Preview, add a '>>' button and use the following (remove Auto Number and Random):
 <Title>
 <Filename>
 <Track#>
 <Auto Number>
 <Random>
 -----------
 \ (directory)
 - (splitter)
 -----------
 <Artist>
 <Album Artist>
 <Album>
 <Genre>
 <Year>
 <Composer>
 <Bitrate>
 <BPM>
 <Folder>
 <Custom1>
 <Custom2>
 <Custom3>
 ----------
 Help
TagsNo tags attached.
Fixed in build1089

Relationships

related to 0002547 closedpetr New 'Unorganized tracks' node / Library Automation 
related to 0003711 closedLudek Needless mask tool bars on many dialogs. 
related to 0004035 closedpetr Regression: toolbar buttons like <artist> is missing from destination wizard 

Activities

jiri

2006-08-03 12:25

administrator   ~0007653

Generally I'd agree with the proposed solution, but I don't like the fact that mask is divided into two fields. It requires more actions particularly from advanced users. A small example: Let's say I rip either to folder A with a mask B or to a folder C with a mask D. In the proposed solution I'd have to switch between A and C and also B and D, while now I simply switch between a combination of A/B and C/D.

I'd say that a clear solution would be to make the control as:

Mask : __________________[v] [...]

Where [...] would open a 'mask building' dialog where user could build the mask in an understandable way similar to the suggestion in this issue, i.e. target folder as one part and a mask as the second part.

rusty

2006-08-07 16:12

administrator   ~0007690

I'm not sure why this is the case. The 'Destination' is just for selecting a non-relative directory on the disk.

As far as setting directory masks, the user could still set them in the Format area.

i.e. the suggested design gives advanced users the functionality that they're used to, but simplifies things for less advanced users who expect to set a directory and a (filename) format independently.

jiri

2006-08-08 07:26

administrator   ~0007691

An IM discussion between Jiri and Rusty didn't have a clear winner, it seems that one field solution (the current one) is better for a little more advanced users while two fields solution could be better for beginners.

What I would currently prefer most (for several reasons as discussed over IM) is:

Destination: __________________[v] [...] [Mask builder]

Where:
[v] is a standard dropdown arrow to list MRU values
[...] would show a list of all possible mask values (as originally described in this issue)
[Mask builder] (wording could be different) would show a dialog (in a wizard form?) that would help particuarly beginners to create even complex masks in an easy and understandable way.

One good point raised by Petr: It should be possible to easily enter masks using keyboard (without mouse). Suggested implementation would show a list of all masks in a pop-up menu after pressing Ctrl+Space and insert selected mask into the current cursor position.

rusty

2006-08-14 16:51

administrator   ~0007727

The main problems with putting the 'Simple' configuration one level deeper is that:
-Users can see immediate feedback re. the effect of a mask on the file structure
-Beginner users are forced into extra clicks

Here's a way of getting the best of both worlds:

Destination: __________________^ [>>] [Browse] [Options >>]

If the user clicks [Options >>] then the state of this dialog changes to:

Directory: __________________^ [Browse] [Options <<]
Format: ____________________^ [>>]

As far as giving the users a means of setting the masks using the keyboard, I like the idea, though I wonder if there's any way to do this user the standard <tab> functionality.

jiri

2006-08-18 08:33

administrator   ~0007740

From the first look it doesn't look bad. On the other hand, from users' perspective, I would wonder why would I split one field into two fields.

Then, from developers point of view, we would have to implement repositioning of controls of any dialog containing a mask field (so that it looks good both with single or double line).

I'd consider this as a not too serious issue and let the idea mature a little.

rusty

2006-08-18 16:23

administrator   ~0007742

Last edited: 2006-08-21 15:08

So are you saying we'll make masks work consistently across the various dialogs using the following approach?

Destination: __________________^ [Set Directory]
                                 [Define format]


(i.e. do everything but split the mask?)

jiri

2006-12-18 13:31

administrator   ~0008312

Yes, I think it makes most sense this way (given all the scenarios described), i.e.:

Destination: __________________^ [Set Directory] [Define format]

Because space is precious in some dialogs, [Set Directory] button would probably be represented by some kind of Browse folder icon, and [Define format] would look like '...' or '>>'.

rusty

2007-01-09 22:15

administrator   ~0008402

Last edited: 2007-01-17 21:06

I would modify this as follows:

Destination: __________________^ [Browse icon] [>>] [Options]

Clicking 'Options' (or alternatively 'Wizard') would result in a dialog along the lines you proposed earlier. i.e.:

------------------------------------------------------------------------
Title Bar: Set Destination Wizard

Main Directory: _______________________ [Browse icon]
Subdirectories: ______________^ / ______________^ / _______________^
Filename: ______________^ - ______________^ - _______________^

Sample:
 C:/Local settings
      /My Documents
          /My Music
              /U2
                 /The Joshua Tree
                     U2 - Where the Streets Have No Name.mp3

-------------------------------------------------------------------------
Alternative:
Title Bar: Set Destination Wizard

Main Directory: _______________________ [Browse icon]
Subdirectories: ______________^ (Album Artist then Album, First Letter of Album Artist then Album Artist then Album, Album Artist then Year - Album, Year then Album Artist, Year - Album, Genre then Album Artist then Album, Album Artist)
Filename: ______________^ (Artist - Title, Track# - Title, Artist - Track# - Title, Track# - Artist - Title)

Sample:
 C:/Local settings
      /My Documents
          /My Music
              /U2
                 /The Joshua Tree
                     U2 - Where the Streets Have No Name.mp3

jiri

2007-01-15 12:06

administrator   ~0008435

I'd prefer the second approach to the dialog, it isn't fully flexible, but is probably significantly easier to use - and that's the point of this dialog, full flexibility can user get on the single 'mask' line without this dialog. I'd just add some more mask choices to the Subdirectories (Year - Album, Year - Album Artist, Genre \ Album Artist \ Album, ...) and Filename dropdowns (Track# - Title, Track# - Artist - Title).

Please assign to Petr if you agree.

rusty

2007-01-17 21:07

administrator   ~0008447

Sounds reasonable. I've updated the spec in comment 8402 accordingly.

rusty

2007-10-12 19:44

administrator   ~0011299

Wizard
-------
1) Change 'Options' button --> 'Wizard'

2) Get rid of the buttons and implement the options directly in the radio dropdowns e.g.
   Subdirectories: ____________________________________^
   Filename: ____________________________________^

3) Align the Sample text box with the other text boxes and move the [OK]/[Cancel] buttons below it.

4) The wizard is missing the Sample text box in:
  -Burn Playlist tracks
  -Add Auto-organize rule
  -Virtual CD / Previews

5) The Wizard in the Virtual CD/Previews config replicates the directory config but:
 -Is disabled
 -Doesn't display the directory config


Mask Config
-----------
4) a) Add missing masks to all dropdowns: <Conductor>
   b) Add missing directory splitter to the Auto-tag from Filename mask list

5) Clicking the '>>' button should hold the mask list open until the user clicks it again to close it.
   That way the user can just click the various mask elements without having to continually re-open the list.

6) Add the 'wizard' button to the following mask config dialogs that are missing one:
   Device configuration sync mask

7) Default directory at first-time startup for Rip / Convert / Auto Organize should be
 . the current user's My Music directory (instead of C:/My Music).

rusty

2007-10-12 21:11

administrator   ~0011307

Per discussion 2) could be problematic if the user first configures a mask in the main UI. Thus here's a proposed revision for item 2:

   Main directory: ____________________________________[browse]
   Subdirectories: ____________________________________^
   Filename: ____________________________________^

                   ___[greyed out but editable text____ >>
   Sample:

petr

2007-10-13 17:49

developer   ~0011308

Fixed all except :

Wizard 5) it's because Virual CD and Previews has defined it's own folders to where Virtual CD/Preview will be saved.

Mask Config 5) I'm not sure if it will be useful, because user can't define order of the selected masks (user will select some masks and will need to change order to any other than in which user selected these items). I think CTRL+Space support is enough for fast typing of the masks.

rusty

2007-10-14 14:38

administrator   ~0011342

5) (Wizard) The Wizard in the Virtual CD/Previews config replicates the directory config & Doesn't display the directory config. This is a bit confusing since the Wizard shows a sample directory that is incorrect. I would suggest either:
a) Showing the directory greyed out
b) Just getting rid of the directory config in the main UI and leaving it in the wizard

Testing Note: Didn't test 7 yet

petr

2007-10-14 14:49

developer   ~0011343

Fixed 5 using solution A. Will be in 1089.

rusty

2007-10-14 23:51

administrator   ~0011353

Verified 1089.