View Issue Details

IDProjectCategoryView StatusLast Update
0020635MMW 5Skinning frameworkpublic2024-03-25 12:57
Reporterzvezdan Assigned To 
PrioritynoneSeverityminorReproducibilityalways
Status closedResolutionfixed 
Fixed in Version5.1 
Summary0020635: Visualization color cannot be skinned
DescriptionVisualization is using color properties of .textColor and .highlightColor classes from basic skin, not from custom skin.

By the way, the waveform is now working fine after you resolved it (0020430), so you should use the same thing with visualization.
Tagstodoc-dev
Fixed in build3001

Relationships

related to 0020430 closedmichal Waveform is hard to be skinned properly 

Activities

michal

2024-02-25 10:19

developer   ~0074353

Fixed in build 3001. Visualizations have "basevis" class now and use "color" and "--visPeaksColor" properties.

peke

2024-02-28 23:28

developer   ~0074408

Verified 3001

zvezdan

2024-03-11 07:43

updater   ~0074551

This still doesn't work. The color of lines in visualization is the one from the basic skin, not from my skin:
.textColor {
    :not(.basevis) > & {
        color: inherit;
    }
    .basevis > & {
        color: red; //example
    }
}

This doesn't work either:
.basevis * {
    color: red; //example
}

michal

2024-03-11 08:02

developer   ~0074552

There are two visualizations.
1) the one in preview window - for Basic bars, Line fade, Basic oscillator you can simply use:
.basevis {
    --visPeaksColor: blue; // color of peaks in visualization
    color: orange; // color of lines and bars
}

2) the small one inside player. Usage is similar, only there is no assigned special class, as Player control is mostly created by skins and they could contain any class they want. You can use e.g.
[data-player-control="visualizer"] {
    --visPeaksColor: blue; // color of peaks in visualization
    color: orange; // color of lines and bars
}

zvezdan

2024-03-11 08:54

updater   ~0074555

Thanks. I though you are still using a color from the canvas element and its class.

peke

2024-03-25 12:57

developer   ~0074797

Verified 3007