View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0020118 | MMW 5 | Codecs | public | 2023-06-25 14:47 | 2023-07-03 21:11 |
| Reporter | peke | Assigned To | |||
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Target Version | 5.1 | Fixed in Version | 5.1 | ||
| Summary | 0020118: Converting AIFF files to FLAC result in file write permission fail | ||||
| Description | Converting AIFF files from 0020117 to FLAC result in file write permission fail. | ||||
| Steps To Reproduce | 1. Start Playback of AIFF file 2. Right click on file -> Convert format 3. Select FLAC 4. OK 5. File Can't written dialog show 6. Stop Playback with hotkey or stop with media keyboard stop key 7. Press retry -> ALL OK | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 2810 | ||||
|
|
I cannot reproduce, tried on all 3 files. Please retest and generate debug log, thanks. |
|
|
It happens for any format, if converting with replacing original file is selected. The original is played, so cannot be deleted. Possible solutions: 1) wait for playback end and schedule delete on playback stop 2) correctly stop playback and then delete I would prefer 2), as it is more safe, user wanted to delete currently playing file - it couldn't be played anymore - so stop playback and user decides what to do next. It is quite probable, that he/she converted whole album in NP list, so the rest of the files are already also not playable anyway. |
|
|
Jiri, what do you think? |
|
|
Personally I would modification of 1) eg. 3) Rename current playing tracks to .XXXXXX and after conversion is finish Crossfade/Playback of converted track into playing one and delete .XXXXXX Reason as users complained in the past dialog Stopped further batch conversion and this case would do less notable transitions. TEST Note: In Current Behavior if User click OK TO ALL and then Folder monitor or Re-scan would result in duplicate file because original source file was not deleted. I think that dialog in this case is not needed at all and just confuse user. |
|
|
I think that it could be as intrusive as possible, i.e. : 1. If the new filename is different (.wav => .flac), the playback could continue and the source file could be deleted after the end of playback (and DB updated). 2. If the conversion replaced the current file, again the playback continues and the file gets replaced replaced and DB updated after. In both cases, we might consider to show a toast message, something like 'The operation will be finished after the end of playback of the current track.', so that it's clear why there's something unfinished. |
|
|
Fixed in build 2810. Used solution 1 - deleting/replacing is postponed till the end of the playback of affected file. The file waiting to delete/replace is ignored during scanning, so should not be rescanned. |
|
|
Verified 2810 Work very well. |
