| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0019959 | MMW 5 | Skins | public | 2023-04-24 19:10 | 2023-11-06 23:23 |
| Reporter | zvezdan | Assigned To | |||
| Priority | high | Severity | minor | Reproducibility | N/A |
| Status | assigned | Resolution | open | ||
| Target Version | 5.1 | ||||
| Summary | 0019959: None native skin is visualy acceptable with Windows 11 high Contrast themes | ||||
| Description | I believe that many users are using high Contrast themes of Windows and I think that the program should have at least one skin that is optimized for such view. The icons are almost invisible with the Desert light contrast theme and all native MM skins, and the selected tracks/nodes are not highlighted with any contrast theme. The borders of dialog boxes are also indistinguishable from the main window, especially with the dark Contrast theme. | ||||
| Tags | No tags attached. | ||||
| Fixed in build | |||||
|
|
Actually, I have two related suggestions: 1. as I said, the program should have built-in skins optimized for Windows Contrast themes, light and dark, just as is the case with VS Code that has them included with it; 2. display and visual appearance of the existing skins should not depend on the Contrast theme set in Windows. Again, as it is the case with VS Code with which you could choose any of its themes and it will stay the same no matter which Windows theme you have set. As you may know, VS Code GUI is based on Chromium, just as your program. Or, the program should detect when the Contrast theme is turned on in Windows and automatically modify some of its GUI elements, as is the case with Opera and Vivaldi that are both also based on Chromium. Opera - Night Sky.png (14,757 bytes) Opera - None.png (15,816 bytes) Opera with dark theme - Night Sky.png (14,622 bytes) Opera with dark theme - None.png (15,616 bytes) |
|
|
Thanks for bringing this up. I think Dark Monkey would be a good basis for a high contrast theme but I understand some elements may need to be tweaked in order to guarantee good visibility. Any thoughts on how Dark Monkey works with Windows high contrast? https://www.mediamonkey.com/addons/browse/item/black-monkey/ |
|
|
On the first look, I don't see any difference between Dark Monkey and Metro M skins, it has the same mentioned problems. The indistinguishable selected tracks/nodes are especially troublesome preventing any normal use of the program. Actually, I just saw one difference and I think Dark Monkey is even worse than Metro M because the thumbnail on the scrollbars is indistinguishable from the rest of the scrollbar (tested with Night Sky theme), so you don't have any visualization which part of the long list is currently displayed. By the way, you could test Contrast themes very easily in Windows by yourself (Settings / Accessibility / Contrast themes or just Left Shift + Left Alt + Print Screen). I think Windows 10 has that similar. |
|
|
Thanks for the info. I'm away from home for a while so I don't have access to a Windows PC, so I figured I'd ask for your thoughts first - so now, when I get back home, I'll have the context necessary to get started testing � |
|
|
note to self: https://blogs.windows.com/msedgedev/2020/09/17/styling-for-windows-high-contrast-with-new-standards-for-forced-colors/ |
|
|
Interesting. I just started to analyze MM skinning trying to do that high contrast modification by myself. Do you have any plan about it, so I could stop my efforts and spend my time on something else? By the way, I still think that my second suggestion mentioned in https://www.ventismedia.com/mantis/view.php?id=19959#c71636 is more important and, since it is independent of the creation or modification of any particular skin that I initially mentioned in the Description, I think I will open a new issue for it. |
|
|
We have a problem, LESS color functions don't support system color keywords (https://www.w3.org/TR/css-color-4/#css-system-colors, https://developer.mozilla.org/en-US/docs/Web/CSS/system-color). For example, this causes the error: @popupBgColor: mix(Highlight, @baseColor, 20%); Which is really strange since they support named colors like red, green... I am trying to modify Metro M and in its skin_base_add.less I replaced: @highlightBgColor: #8a724e; with @highlightBgColor: Highlight; However, when I try to start the program with that modified file, I get the error dialog saying "(LESS) Error evaluating function 'mix': Argument cannot be evaluated to a color". Problematic code is: @popupBgColor: mix(@highlightBgColor, @baseColor, 20%); which is in the skin/skin_listview.less that is your default skin file. It worked when I changed that line to: @popupBgColor: @baseColor; but that file is supplied with the program and cannot be overridden by skin. I tried to add that line to the skin's file skin_listview_add.less instead of modifying skin_listview.less, but I get the same error. And I got the same error when I added that line to the skin's skin_base_add.less file. It seems the only solution to implement support for Contrast themes is that your default skin doesn't use any LESS color functions. |
