View Issue Details

IDProjectCategoryView StatusLast Update
0019869MMADBpublic2023-04-14 17:27
Reporterrusty Assigned To 
PriorityurgentSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version2.0.0 
Target Version2.0.0Fixed in Version2.0.0 
Summary0019869: Tracks can't be deleted if folder permissions haven't been granted
DescriptionI) If the user skips granting folder access as described at 0019831, and syncs content to the MediaMonkey-specific folder that is used in such cases, then attempts to delete the file result in the following error:
'MediaMonkey requires write permission to some folders. [Cancel] [Grant access]
This doesn't seem to make sense since MediaMonkey _does_ have full access to MediaMonkey-specific folders!

II) What is even worse is that the error still occurs even if the user then grants access to the folders!
TagsNo tags attached.
Fixed in build1072

Relationships

related to 0019831 closedmartin Wi-Fi Sync doesn't work if the user skips granting folder access 
related to 0019875 closedmartin Tracks can't be deleted (regression) 

Activities

martin

2023-03-10 14:22

developer   ~0071339

Last edited: 2023-03-10 15:34

I) There are three options for how to solve it.
A) Do not show Grant dialog, but in this case, the deletion fails on tracks without access permission. (As was in 1.4.X no notification of why deletion failed)

B) Always show Grant dialog when write permission is missing
(current solution)

C) Add some kind of detection of whether Grant dialog is needed
MMA can delete a collection of tracks, albums, composers, etc.
The detection of write permission file by file is too complex and too slow.
However, I suggest including to next build:
1)a simple detection
a) If all tracks are in App-Specific folder do not show Grant dialg
b) if at least one track from read-only folder is in the library, then show Grant dialog (improved by filtration by type music, video, audiobooks...)

2) Maybe change wording like:
There can be tracks located in folders without write permission. Such tracks will not be deleted.
 [Cancel][Grant access]

II)Fixed in build 2.0.0.1072

rusty

2023-03-10 16:23

administrator   ~0071342

Per discussion:
1C) sounds reasonable
2) We can continue with the existing wording "MediaMonkey requires write permissions to some folders." i.e. given the context (that the user tried to delete content) it's clear that the reason for the permission to be granted is so that the file can be deleted.

martin

2023-03-10 19:29

developer   ~0071344

Fixed in build 2.0.0.1072

rusty

2023-03-14 18:10

administrator   ~0071360

Tested 1073 and everything is working except that if I attempt to delete a single track that has been synced to the MMA-internal directory, MMA still prompts to grant access. Is this intended?
i.e. in the above case, there are other tracks in the library stored to the shared /Music directory, but my understanding of the proposed fix was that if the user only attempts to delete tracks and all of them are stored to MMA-internal directory, then the prompt to grant permissions shouldn't appear. Please clarify.

martin

2023-04-11 11:47

developer   ~0071474

That's the correct behavior.
If a user attempts to delete tracks that are in a writable folder (e.g. MMA-internal) but there is also a read-only folder on the same storage, permission will be requested. This is due to the fact that MMA does not analyze the file location for each selected track for the reasons described above.