View Issue Details

IDProjectCategoryView StatusLast Update
0018795MMW 5DB / Backuppublic2022-09-14 14:39
Reporterpeke Assigned To 
PriorityhighSeveritytweakReproducibilityalways
Status feedbackResolutionopen 
Target Version5.2 
Summary0018795: Restore DB: Restoring DB should Automatically clean MM cache
DescriptionRestoring DB (File -> Manage Database -> Restore) should Automatically clean MM cache as there is a risk that cached online Album art be assigned to different track.

I have seen it only once or twice before today, but users never been able to disclose that fact and I saw it today where tracks that were looked for AA online and point to unsaved Image in preview window actually have embed AA in Tag.

Only other thing that could happen is that MM pulled Image from iTunes even there was already AA in Tag (can't confirm, strange issue).
TagsNo tags attached.
Fixed in build

Relationships

related to 0018794 feedbackrusty Cache: Clear cache within MM 

Activities

Ludek

2022-02-01 12:58

developer   ~0066814

Last edited: 2022-02-01 13:36

Revising what should be cleaned on database change and found that:

1) /Temp/Thumbs/ are saved per image data hash, so shouldn't be related to DB track ids
2) /Temp/Waveforms/ are per track id and thus might need to be cleaned once the restored database is totally different database (with different track ids)
3) /Temp/Transcoded_Media_Files/ are per track id, but currently are auto-cleaned per settings in Options > Media Sharing > Cache
4) /Temp/Cached_Cloud_Files/ currently aren't track id dependent and are auto cleaned per settings in Options > Player > Streaming > Maximum cache size
5) /Temp/AlbumImages/
6) /Temp/ImageCache/

So potential candidates to clear once DB is replaced are 2, 3, 5, 6
But this should happen only once the DB is replaced by different DB (with another DB id)

So my suggestion is to write last used DB id into persistent.json and once MM finds that the DB differs then it could run background task to clean the cache.

But I don't think that this should be done automatically, but rather ask user something like:
"MediaMonkey detected that different library database file is used, do you wish to clean cached files for the old database?"
[Yes][No]
image.png (11,978 bytes)   
image.png (11,978 bytes)   
image-2.png (4,473 bytes)   
image-2.png (4,473 bytes)   

Ludek

2022-02-01 13:03

developer   ~0066816

Assigned to Rusty for review/wording suggestions.