View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0018162 | MMW 5 | Other | public | 2021-07-23 10:24 | 2022-02-15 00:38 |
| Reporter | Ludek | Assigned To | |||
| Priority | urgent | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | reopened | ||
| Product Version | 5.0 | ||||
| Target Version | 5.0.3 | Fixed in Version | 5.0.3 | ||
| Summary | 0018162: Clean up performance warnings | ||||
| Description | Currently in the DbgView there are several performance warnings like Performance warning: doOnChange is called too often, consider using beginUpdate/endUpdate (OT: sharednodelist, id: -1) Performance warning: Class TSharedUIList doesn't implement its own createInstance Performance warning: TSongListData.doOnChange took 16ms This former performance warning was added by me to catch possible performance leaks. It is no issue if you see just one or two lines of this in a row, but seeing this multiple times in a row means that someone is performing multiple operations (e.g. in a loop) on a list without using list.beginUpade() / list.endUpdate() Typically if you are using list.add(item) in the loop. This results in multiple calling of 'change' event (and thus performance leak). | ||||
| Additional Information | [Tickets # 2181, # 2182, # 2243] | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 2607 | ||||
|
|
Some of the performance warnings fixed in 5.0.2.2500 , more TBD... |
|
|
While reviewing this we should probably clean also debug messages like Locking file, Unlocking file (ticket # 2243) |
|
|
Majority of performance warnings + performance optimizations added in 5.0.2.2501 |
|
|
Made some improvements in 2505, but still more to do... |
|
|
Further performance warnings fixed in 2607. |
|
|
Verified 2607 No regressions found. |
