View Issue Details

IDProjectCategoryView StatusLast Update
0018162MediaMonkey 5Otherpublic2021-09-11 17:00
ReporterLudek Assigned To 
PriorityurgentSeverityminorReproducibilityalways
Status feedbackResolutionreopened 
Product Version5.0 
Target Version5.0.2Fixed in Version5.0.2 
Summary0018162: Clean up performance warnings
DescriptionCurrently in the DbgView there are several performance warnings like
Performance warning: doOnChange is called too often, consider using beginUpdate/endUpdate (OT: sharednodelist, id: -1)
Performance warning: Class TSharedUIList doesn't implement its own createInstance
Performance warning: TSongListData.doOnChange took 16ms

This former performance warning was added by me to catch possible performance leaks. It is no issue if you see just one or two lines of this in a row, but seeing this multiple times in a row means that someone is performing multiple operations (e.g. in a loop) on a list without using list.beginUpade() / list.endUpdate()

Typically if you are using list.add(item) in the loop. This results in multiple calling of 'change' event (and thus performance leak).
Additional Information[Tickets # 2181, # 2182, # 2243]
TagsNo tags attached.
Fixed in build2501

Activities

Ludek

2021-07-23 10:53

developer   ~0064279

Some of the performance warnings fixed in 5.0.2.2500 , more TBD...

Ludek

2021-07-28 19:47

developer   ~0064318

While reviewing this we should probably clean also debug messages like Locking file, Unlocking file (ticket # 2243)

Ludek

2021-09-03 13:21

developer   ~0064474

Majority of performance warnings + performance optimizations added in 5.0.2.2501