View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0017898||MMW 5||Skinning framework||public||2021-05-20 22:12||2023-08-22 12:04|
|Target Version||5.1||Fixed in Version||5.0.4|
|Summary||0017898: Add a method to only reload window, to facilitate faster skin switching & addon installation without interrupting playback|
|Description||Some users have pointed out that switching skins is very slow in MM5 compared to in MM4, because the entire app reloads instead of just reloading the HTML+JS+LESS. When switching skins and installing most addons, the entire app does not need to reload; only just the window. Adding a second, "light" reload method for switching skins and installing addons would facilitate faster reloads, without having to stop audio playback.|
|Tags||No tags attached.|
|Fixed in build||2814|
|has duplicate||0019010||closed||drakinite||Install / uninstall of add-ons without restart|
|related to||0017291||closed||petr||Problems with app restart/reload|
|related to||0017432||feedback||peke||Skin change in some cases creates double Tray icon|
|related to||0018997||closed||Ludek||Method to add menu item to the context menus of all displayed tracklists needed|
|related to||0019450||closed||petr||player.isPlaying always returns true after soft reload|
||Implemented ... second parameter of doReload do soft reload of the app|
||Does this need to implemented in Skins themselves. Switching from Material Design to Black Monkey (and later back) did a full restart of MediaMonkey on 2658.|
Updated skin switching code to use the new soft reload. Skins now switch much faster.
The new soft app.loadLayout mode doesn't seem to work reliably, however.
If you switch app.loadLayout(layout); to app.loadLayout(layout, true); in actions.js -> function layoutChanged(layout), then:
1. switch from Desktop to Touch Mode
2. allow window to reload
3. navigate to View > Mode -> the radio button will still say Desktop
4. Close and restart MM, or use Refresh Skin Shortcut > Full app reload -> Layout switches back to Desktop
Seems like there's also a memory leak...
If you use Refresh Skin Shortcut -> Quick window reload over and over, MediaMonkeyEngine.exe's memory usage seems to increase by about 20-30 MB each time.
The change is now causing a crash:
1) Play a YouTobe video
2) Switch sking
=> crash 'isYouTubeTrack is not defined'
||The crash is fixed in 2814|