View Issue Details

IDProjectCategoryView StatusLast Update
0017166MMW 5Install/Configpublic2020-12-16 17:53
Reporterrusty Assigned To 
PriorityurgentSeveritymajorReproducibilityalways
Status closedResolutionreopened 
Product Version5.0 
Target Version5.0Fixed in Version5.0 
Summary0017166: Upgrade to 5.x from 4.x: Artwork may fail to shown on first run
DescriptionWhen I install MMW5 2278 to a machine that already has MMW4 installed, and agree to migrate the database
--> Artwork fails to display in the Preview window!

1 Install MM5 (regular install) to a machine with MM4 (regular install)
2 Run MM5 and agree to import the MM4 DB
--> DB appears to import successfully
3 Select a track that is known to have artwork
--> The Preview window doesn't show any artwork!
4 For the selected track, click Properties > Artwork
--> the artwork _does_ display (albeit after half a second)
5 Select a different track and then reselect the original track
--> Preview window still fails to show artwork!
Additional InformationTest note: once this is fixed, upgrade scenarios (already tested in #14890), should probably be retested in greater detail (i.e. making certain that _all_ fields are correctly migrated).
TagsNo tags attached.
Fixed in build2282

Relationships

related to 0014505 closedLudek MMW v4 Network Playback: Non Accessible tracks block Playback 
related to 0017070 closedLudek MMW 5 Locate Moved/Missing files performance is slow 
related to 0014594 closedLudek MMW v4 Wi-Fi sync fails in some cases (related to temporal network dead links) 
related to 0016914 closedLudek MMW 5 Portable: Portable install should ignore Temp Setting 

Activities

Ludek

2020-12-04 12:19

developer   ~0060552

Last edited: 2020-12-04 12:20

I cannot replicate. For me the thumbs in the Preview window are shown immediatelly and just fine.

Note that during the import the entire database file (MM.DB) is copied, so there isn't a reason for certain data not to be imported.

From the description it sounds to me that the artwork file was somehow temporarily unavailable (e.g. for files on NAS ?) and thus it failed to generate the thumbs for the Preview window.
Later you opened Properties > Artwork and it was able to read the artwork file finally and generate the thumbs.

To confirm please:
1) generate DbgView from MM5 (i.e. DbgView started before the first MM5 start)
2) If you subsequently restart MM5 -> Is the artwork thumb in the preview window shown finally or not ?

Ludek

2020-12-04 15:38

developer   ~0060554

Last edited: 2020-12-04 15:41

Rusty is unable to replicate, but confirmed that numerous files in the DB were inaccessible / not playable.
So this confirms my speculation with network accessibility timeout (currently 5 seconds, but configurable via MM.ini , details in 0014505:0049091 )

Anyhow, I don't believe that there is a data loss during the migration.
So resolving...

rusty

2020-12-04 18:40

administrator   ~0060558

Closing. I'm unable to replicate the issue even with many tracks artificially inaccessible and many tracks unplayable.

rusty

2020-12-06 04:28

administrator   ~0060568

Re-opening. To replicate this consistently, MM5 must be installed in _Portable_ mode and import the settings from MM4 (regular install). And to answer your question, after restarting MM5, the artwork does appear.

See: https://www.screencast.com/t/zaTYGfIsMB59 (sorry it's a bit long).
Debug log associated with the video above posted (along with a second debug log of MM5 (regular) running after install and not experiencing the bug).

rusty

2020-12-06 04:28

administrator   ~0060569

bug17166_build2280.7z (250,524 bytes)

Ludek

2020-12-07 16:34

developer   ~0060609

Last edited: 2020-12-07 17:20

Based on the logs the thumbs are cached to
C:\Users\Russell\AppData\Local\Temp\Thumbs\79\1HIB37TZP1RNI54X-200px.jpg
but subsequebtly MM5 tried to read them from
D:\My Documents\Temp\MediaMonkey 5\Portable\Temp\Thumbs\79\1HIB37TZP1RNI54X-200px.jpg

And after the restart it reads the thumbs exclusivelly from
C:\Users\Russell\AppData\Local\Temp\Thumbs\...

I see two issues here:

1) it imported temporary directory location from MM4 regular to MM5 portable
I guess MM5 portable should always use the default portable temp dir location (inside of portable folder) ?
EDIT: I am not sure about this as reading 0016914 some users uses custom temp location like F:\Cache\MediaMonkey\ (e.g. Barry), so it is probably OK to preserve the temporary directory location from MM4 (can be changed anytime in Options > General)

2) After settings import from MM4 the newly imported temp location wasn't sent from MME.exe to MM.exe ('b_settings' message)
=> Fixed in 2282 (this is fix for the original issue of artwork thumbs not showing on the first run after import)

peke

2020-12-13 04:02

developer   ~0060748

2) Verified 2283

peke

2020-12-13 04:06

developer   ~0060749

Assigned for feedback on 1) I agree with Ludek there Custom Temp should be preserved, but maybe for Portable Cache should be copied to Portable Temp (in background During First start wizard?

Ludek

2020-12-16 17:53

developer   ~0060809

I don't think that a change is needed atm