View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0017025||MediaMonkey 5||Extensions framework||public||2020-10-23 21:00||2020-10-27 13:13|
|Status||closed||Resolution||no change required|
|Summary||0017025: MMIP: Installation of MMIP fail if MMIP install Info is in subfolder|
|Description||Installation of MMIP fail if MMIP install Info is in subfolder|
Uploaded same MMIP, but one is in subfolder and one is normal one.
Expected behavior is that Installation do not fail like in MM4.
|Tags||No tags attached.|
|Fixed in build|
Bug17025 Bad hotkeyAction.mmip (901 bytes)
bug17025 OK hotkeyAction.mmip (893 bytes)
Having files within a sub-folder is unexpected:
- MM4 reports such a scripts as "Invalid product installation package" (see BAD.mmip)
- MM5 reports this as "Invalid extension" (your 'Bug17025 Bad hotkeyAction.mmip' example)
I don't think that a change is required.
BAD.mmip (26,338 bytes)
Sorry maybe I was not fully clear. The change I was referring to is that when MMIP file contain only subfolder and no files in MMIP root. eg. If no files in root and only one subfolder consider that subfolder is root and check if it contains installation files.
It can be pushed to 5.1 if too complicated.
Yes, exception like this just complicates the install process, I don't see point of adding this especially when this has never worked in MM4 too (and MM4 has hundreds of addons -- unlike MM5) and such a extension has been always considered as invalid.
It is up to the extension creator to keep the correct form.
BTW: There is already automatic MMIP packer (created by user drakinite) here: https://www.mediamonkey.com/forum/viewtopic.php?f=27&t=97536
I haven't tested the packer myself yet, but sounds promising and should minimalize the risk of creating an invalid extension by accident.
||Good point. Closing|