View Issue Details

IDProjectCategoryView StatusLast Update
0016872MMW 5Tagging / organizing (properties / auto-tools)public2020-08-14 20:58
Reporterpeke Assigned To 
PriorityurgentSeveritytextReproducibilityalways
Status closedResolutionreopened 
Target Version5.0Fixed in Version5.0 
Summary0016872: Alternative Lookup changes tags irreversibly and immediately which can result of metadata loss
DescriptionAlternative Lookup changes tags irreversibly and immediately which can result of metadata loss if user is quickly browsing library.

I would suggest that we change its behavior to not be a default but that user is presented with Update dialog on focus change.

Views affected are:
Album
Artist
Album Artist

NOTE: This option is not available anywhere else and it can be easily overlooked.
Additional Informationhttps://www.mediamonkey.com/forum/viewtopic.php?f=30&t=97005
TagsNo tags attached.
Attached Files
bug16872.jpg (609,237 bytes)
Fixed in build2264

Activities

rusty

2020-08-07 17:14

administrator   ~0059261

This is intentional--In earlier builds, these lookups weren't synced with property's metadata and it resulted in confusion (it's very strange to have a given view displaying a different Artist, Album Artist, Album than the one that is contained in the tag). The current terminology here is 'Lookup alternate (<property>' which is pretty much the same as Lookup image, Lookup lyrics, etc. which also lookup metadata of the given property.


rusty

2020-08-07 18:29

administrator   ~0059263

Possible alternative approaches discussed:
1) Change 'Lookup alternate (<property>) --> Choose alternate (<property)
2) Display the revised lookup in a confirmation dialog (change the workflow so that it's similar to to how 'Lookup image...' works
3) Move the '[x] Update tracks' option above the list of alternate options

I don't love any of these, but 1) may be the best if we feel that a change is required.

We should change 'Update tracks' --> 'Update properties' (since the tracks aren't necessarily updated--that depends on tag update settings).

peke

2020-08-07 19:18

developer   ~0059264

2) as pointed Main difference with Lookup image, Lookup lyrics etc is that each time user selects new info confirmation is asked eg. Dialog (2)

3) both Lookup image, Lookup lyrics have own space in options under metadata lookup and this not and it is tied to Update tags option in Tags and playlists, so I would move it to first position and make it gray if Update tags on edit is disable (Current behavior that in case Update tag on edit is disabled [ ] Update tracks is not shown at all and changing to alternative album do not have any effect on Metadata eg. preview change)

peke

2020-08-07 19:20

developer   ~0059265

Last edited: 2020-08-08 15:51

I also noticed that if Update Tags on Edit and Update Tracks are enable Immediately after selection in some cases Album art is also tagged into files based on selected alternative release which is also risky without user confirmation.

Note: Unless explicitely enabled to update tags in options both image and lyrics show Save icon.

Ludek

2020-08-10 09:40

developer   ~0059307

Fixed in 2263

i.e. text changes
 'Lookup alternate (<property>) --> Choose alternate (<property)
 'Update tracks' --> 'Update properties'

peke

2020-08-13 02:38

developer   ~0059371

Verified 2263

Word changes clears its function so user can't misinterpret it as Lookup.

rusty

2020-08-13 19:51

administrator   ~0059394

I tested 2263, and the text is still the old text ('Lookup Alternate'). Peke how did you test this (I looked at the Artist and Album [Browser] view?

Ludek

2020-08-14 16:59

developer   ~0059402

Last edited: 2020-08-14 17:00

I can confirm that 2263 includes the _old_ strings for some reason.
We changed SVN server from CloudForge to our server and there have been some issues resulting in problems like this.

Solving with Petr and he has deleted his source directory for creating builds and done a clean SVN checkout -- so should be ok in 2264.
i.e. please re-test in 2264

rusty

2020-08-14 20:58

administrator   ~0059405

Verified 2264.