View Issue Details

IDProjectCategoryView StatusLast Update
0016618MMW 5Otherpublic2020-05-28 01:07
Reporterpeke Assigned To 
PriorityurgentSeveritytweakReproducibilityalways
Status closedResolutionfixed 
Product Version5.0 
Target Version5.0Fixed in Version5.0 
Summary0016618: Masks: Better wording for mask <Skip> and clarification of uses.
DescriptionAs we now have Skip counter in track properties using <Skip> in masks can be confusing I would suggest to rename it to <Ignore>:

1. Auto Tag from Filename and other places where <Skip> was used to exclude parts of string in detection of metadata (eg. "C:\Music\<Artist> - <Skip>\<Album> (<Year>)\<Track #> <Title>" it would be more clear to look like "C:\Music\<Artist> - <Ignore>\<Album> (<Year>)\<Track #> <Title>"). In Context eg. >> we should rename "Skip" to "Ignore" and under "Played History" we should rename "Skip" with "Skipped #" to be consistent with "Played #"


2. Auto-Organize, Sunc Paths where <Skip> was used for "Skip Counter" I would suggest to rename it to <Skipped #> as it is more clear. In Context eg. >> under "Played History" we should rename "Skip" with "Skipped #" to be consistent with "Played #"

It would also make translation more easier and clear.
TagsNo tags attached.
Attached Files
bug16618.png (106,871 bytes)   
bug16618.png (106,871 bytes)   
Fixed in build2252

Activities

rusty

2020-05-15 23:04

administrator   ~0058057

The change sounds reasonable, except that it probably makes more sense to do so for 5.1, but I'll leave it up to Ludek.

Note: if we make this change, the old mask format should continue to work--otherwise users will complain about masks that no longer work.

peke

2020-05-16 01:25

developer   ~0058061

Re Note: I think that change is low risk as MM keeps masks in ini with our own mapping eg. https://www.mediamonkey.com/wiki/index.php?title=Scripting_Resources#Internal_Mask_Fields so it should not make any difference in current User setups, MM4 setting Import.

Ludek

2020-05-19 12:58

developer   ~0058110

Last edited: 2020-05-19 13:00

Fixed in 2251

i.e. renamed 'Skip' to 'Ignore', but left accepting of <Skip>, i.e. MM5 accepts both <Ignore> and <Skip> now (both mapped to %X )

peke

2020-05-22 22:55

developer   ~0058215

Last edited: 2020-05-22 22:57

Reopen Play History Shows "Ignore" instead "Skipped #" (Img attached) it affect both Auto tag from filename and Auto Organize

Functionality of Mask verified 2251

Ludek

2020-05-23 15:05

developer   ~0058222

Last edited: 2020-05-23 15:37

Mask for <Skipped #> does not exist at all yet, and someone previously added <skipped> to play history.

Fixed in 2252 by adding mask for <Skipped #>

peke

2020-05-28 01:07

developer   ~0058326

Verified 2252

All is in their place, mask is working OK.