View Issue Details

IDProjectCategoryView StatusLast Update
0014348MMW 5Generalpublic2018-06-23 00:32
Reporterpetr Assigned To 
PriorityurgentSeverityfeatureReproducibilityhave not tried
Status closedResolutionreopened 
Product Version5.0 
Target Version5.0Fixed in Version5.0 
Summary0014348: MicroPlayer implementation
DescriptionImplement micro player same as is in MM4. Improvements can be done when finished.
TagsNo tags attached.
Attached Files
mini-player.jpg (21,193 bytes)   
mini-player.jpg (21,193 bytes)   
mini-player_2.jpg (26,525 bytes)   
mini-player_2.jpg (26,525 bytes)   
mini-player_3.jpg (16,076 bytes)   
mini-player_3.jpg (16,076 bytes)   
microplayer_build_2099.jpg (9,998 bytes)   
microplayer_build_2099.jpg (9,998 bytes)   
Mini_and_micro_players.jpg (18,377 bytes)   
Mini_and_micro_players.jpg (18,377 bytes)   
Fixed in build2112

Relationships

related to 0014760 closedpetr MicroPlayer: Check If MM5 MicroPlayer is registered 

Activities

petr

2018-02-28 22:38

developer   ~0049657

Last edited: 2018-03-13 19:52

Basic micro-player and mini-player implemented.

rusty

2018-03-14 20:29

administrator   ~0049713

Last edited: 2018-03-14 20:35

1) Tested Micro-Player and:
a) it doesn't work with the MD skin:
- Enabled Minimize to Micro-Player
- Pressed Minimize button
--> MM5 disappears from the taskbar and system tray.
--> Rectangular white box appears on the desktop
--> Only way to get to the UI is by force-closing MM
Note: it works with the Monkey Groove skin

b) The implementation takes up too much space. I would suggest:
- make it more similar to MM4, i.e. limit it to Back/Play-Pause/Next; seekbar below; maximize)
- display popup metadata on hover
- ideally integrate more cleanly with the taskbar. i.e. if the taskbar is dark, it should also be dark so the whole thing doesn't stand out so much

c) Ideally, automatically enable the Tray > Toolbars > MediaMonkey Player, but if that's not possible, change messaging so that users are aware that it is supposed to be used via the tray. e.g. change the name to 'Tray Player' and/or add a message "Enable the 'MediaMonkey Player' via the System Tray Toolbars menu to use".

2) Tested mini-player and
a) With the Monkey Groove and MD skins, it's quite ugly, appearing non-centered with a strange purple background (and not really looking like the skin upon which it is based). I think that this might be related to the fact that it also dynamically resizes within the purple background depending on the width of the metadata (see attached images).
b) It should be more compact. I would suggest removing the visualization and using a layout as follows:

[ .A. ] . . [Track metadata (time)] . . . |[]
[ ./. ] ----o---------------------------------|
[ .A. ] * * * * * [Back] [Pl/P] [Next] . |[NP]

It should minimally contain: Maximize; AA; Back/Play-Pause/Next, Metadata/Seekbar; NP toggle. Currently it's missing AA and NP toggle. Re. volume, I'm not sure whether it's needed, but I've retained it on the right above.
 
c) When moving the cursor over the mini-player, the Maximize button moves

d) MM should have a minimize to MiniPlayer button

petr

2018-03-28 14:55

developer   ~0049822

Items 1a, b, 2a, b, c fixed

petr

2018-03-30 09:30

developer   ~0049826

Last edited: 2018-03-30 09:31

Implemented 2d. Switch is in title area for borderless skin, bot for bordered next to search button (because of some technical issues it's not in title area as well).

Assigned to Rusty for a test and feedback.

rusty

2018-04-19 20:40

administrator   ~0050040

1a) Minimizing to the microplayer still fails with various windowing issues
1 Pressed 'microplayer' button while a video was playing
--> MicroPlayer appeared in the upper left corner of the screen, but the main MM window continued to display as well! (see attached)
2 Hover over the MicroPlayer
--> Metadata displays at the bottom left corner of the screen! Could it be that there's an invisible mm entry at the leftmost portion of the taskbar??
3 Press the Maximize button (to exit the MicroPlayer)
--> Nothing happens! Presumably because the main MM window is still displayed.
4 Switch to MicroPlayer via the main MM window that still displays
--> Both MiniPlayer and MicroPlayer display! (see attached)
5 Maximize the MiniPlayer so that the main MM window appears again (with the MicroPlayer). Attempted to enable the MediaMonkey Player toolbar so that it would display the MicroPlayer correctly in the system tray
--> MicroPlayer disappeared entirely!
--> MM crashed soon after! It wasn't possible to generate a debug log as even the crash dialog terminated on crash
--> Windows Explorer crashed as well

As a consequence of this, I was unable to test 1b) c)

d) The microplayer seekbar displayed incorrectly, with the seekbar handle drawn on top of the buttons (see attached)

2)
a) MiniPlayer still has purple display artifacts and it's unskinned-i.e. it doesn't look at all like the MD skin that is displayed!
d) There's still no minimize to miniplayer button
e) The lower left corner of the Artwork displays outside the margin of the window. Is this on purpose? Also the artwork obscures the lower margin of the window.
f) If the user enables NP:
. i) it shouldn't appear as a completely separate Window with it's own Title Bar
. ii) it should have a window margin that's contiguous with that of the MiniPlayer i.e. the two functions should be integrated rather than separate windows.
. iii) Upon scrolling through NP, the content of the NP window disappears (opening and closing NP causes it to reappear).

rusty

2018-04-20 18:48

administrator   ~0050050

Last edited: 2018-04-20 19:03

Tested build 2100 and I discovered something interesting re. 1a): if I enable the Toolbar > 'MediaMonkey Player' immediately after installing MM5 i.e. prior to minimizing to the MicroPlayer, then the MicroPlayer works correctly, consistently.

But then if I:
2 Switch back to the MM main Window
3 Disable the Toolbar > 'MediaMonkey Player'
--> MM crashes (sometimes)
4 Minimize to MicroPlayer
--> MM crashes (always)! Debug log: 26F90000

Moreover, if MM doesn't crash at step 3, then taking alternate steps
4a Re-enable Toolbar > 'MediaMonkey Player'
5a Minimize to MicroPlayer
--> MM crashes or disappears from the UI

The reason why I've never seen the MM5 microplayer working until now is because I've always minimized to MicroPlayer without _first_ enabling the Toolbar > 'MediaMonkey Player' .

EDIT: added video and log https://www.screencast.com/t/zDGGd4GQ1M69

petr

2018-04-23 14:10

developer   ~0050064

Microplayer and Miniplayer frame fixed. Resolving to feedback.

rusty

2018-04-24 20:10

administrator   ~0050100

Tested build 2101.

Minimizing to microplayer has no effect (see attached log around line 33xx) despite the fact that I enabled the Toolbar > MediaMonkey Player in advance.

Minimizing the miniplayer worked, but the purple background artifacts still displayed (identical to build 2100).

petr

2018-04-25 21:03

developer   ~0050115

Fixed

rusty

2018-05-01 00:11

administrator   ~0050145

Tested 2102 and several issues remain:

1) MicroPlayer
a6) If a video is playing and the user minimizes to the microplayer, the video displays in a small window but theres no way to move the window!
a7) After a video completes playing with the microplayer minimized, an empty white video window continues to display, even after maximizing back to the main MM window! Once this occurs, MM is no longer able to play video!
d) The seekbar no longer displays in the microplayer. I assume this is intentional? Btw, you could have it appear at the bottom of the popup
e) Upon minimizing to the microplayer, the 'Maximize' button appears in blue (as if the cursor is hovering on it)
f) Moving the cursor within the microplayer causes the Artwork in the popup to flash

2) MiniPlayer
a) Purple artifacts continue to display around the 4 corners of the player
f) If the user enables NP:
. ii) it should have a a single border that's contiguous with that of the MiniPlayer i.e. the two functions should be integrated rather than separate windows. This probably implies that the miniplayer (at least the two bottom corners) needs to be squared.
. iii) Upon scrolling through NP, the content of the NP window disappears (opening and closing NP causes it to reappear). This is easy to trigger by loading e.g. 100 tracks into NP.

petr

2018-05-20 19:54

developer   ~0050333

Last edited: 2018-05-22 09:05

Items 1 a6, a7, d, e, f, 2f are fixed

michal

2018-05-31 11:24

developer   ~0050445

2a) is gone (i.e. no purple corners), when compatibility mode "Window 8" is set for MediaMonkeyEngine.exe... seems to be similar issue and cause as 0014748

petr

2018-06-12 08:05

developer   ~0050520

Fixed

peke

2018-06-23 00:32

developer   ~0050593

Verified 2113