View Issue Details

IDProjectCategoryView StatusLast Update
0013745MMW 5Generalpublic2019-04-01 17:50
Reportermichal Assigned To 
PriorityurgentSeverityminorReproducibilityN/A
Status closedResolutionfixed 
Fixed in Version5.0 
Summary0013745: Add possibility to rename artist
DescriptionWe should add possibility to rename artist, so user could easily fix e.g. typos in the artist name. In MM4 it is done by "Rename" context menu item on artist node in the tree (or F2 on selected artist node), in MM5, we could add "Rename" item to the context menu in the header of Artist view. Maybe we could add it also on doubleclick on artist name in the header. Both in "My Library" mode. After the change (i.e. pressing Enter or clicking elsewhere after inplace edit), all relevant tracks should be retagged.
1) should be artist name changed also after selecting different artist in "Wrong artist" menu?
2) should we display some confirmation dialog or some toast message like "X track(s) are going to be tagged", before retagging?
3) should the rename option be also in Artists view, e.g. in context menu, after pressing F2, or in the popup header?
TagsNo tags attached.
Fixed in build2073

Relationships

related to 0015576 closedmichal Renaming title of artist/album after selecting it from Wrong artist/album menu should be optional 

Activities

rusty

2016-12-14 05:15

administrator   ~0046500

o) I agree--if an artist appears as 'The Beetles' in Artists view it should be possible to edit it (or if an Album appears as 'The Wite album' in Albums view it should be possible to edit that, etc.).

Note: I think that this is part of the same discussion re. whether simple lists should be editable. i.e. if users are able to edit simple lists, then it would follow that there should also be a means of editing their superior attribute, and vice versa.

1) The current UI would imply to most users that the Artist is going to be changed. So yes--I would agree (note: applies to Albums as well).

2) The tag update dialog should appear always whenever > x tracks are modified (unless the user disables it).

3) As to the mechanism for editing:
i) it could be by clicking the Artist name in artist view (or Album name in Album view). Downside is that this would only work for the main field (other fields function as links), so it might not be obvious that this is even possible.
ii) F2 could be used, but in doesn't work in tablet mode.
iii) 'Rename' context menu could work, but it could be confusing to see both 'Rename' and 'Wrong Artist?'
iv) another possibility could be 'Edit Properties' --> Properties editor opens in reference to all of the tracks.
My feeling is that options i) or iv) make the most sense, i) probably being the most practical approach at the moment, iv) possibly being a better approach once the Preperties dialog appears docked within the view.

jiri

2016-12-14 10:20

administrator   ~0046506

1) Agreed.

2) The question was related to the fact that even if it's only 1 track, it will be tagged after an operation that doesn't necessarily imply tagging (i.e. changing Artist name by using 'Wrong Artist?' menu item). I'm not sure, a Toast message might be useful, but we probably can live without it as well.

3) What about integrating the 'Rename' command to 'Wrong Artist'? I.e. Wrong artist submenu would look like:
Artist1
Artist2
-------
Enter name...

If implemented this way, iii) makes most sense to me. I don't like i&ii much, but I suppose that iv) could be implemented anyway, as it might be an easy way how to e.g. change Classification fields for all Artist's or Album's tracks.

rusty

2016-12-14 17:08

administrator   ~0046518

2) Agreed. If a tag isn't being modified, no warning is needed. But if a tag is being modified, the standard/existing logic should apply.

3) OK, so we'll go ahead with iv) 'Edit Properties' and v) Jiri's suggestion.

michal

2017-07-11 09:49

developer   ~0048355

Fixed in build 2073.

peke

2017-08-08 01:28

developer   ~0048479

Verified 2073