View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0013458 | MMW 5 | Track Browser | public | 2016-08-11 02:02 | 2019-12-20 15:19 |
| Reporter | rusty | Assigned To | |||
| Priority | high | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Summary | 0013458: Popups open slowly | ||||
| Description | This was originally raised at 0012451:0045221, but appears to have been overlooked: Artist and Album popups open slowly (e.g. clicking an Album causes the popup to open about .5s later. It should be immediate. | ||||
| Tags | No tags attached. | ||||
| Fixed in build | |||||
|
|
Works pretty much immediately for me. Could you please provide a debug log and possibly also a video? Or do you mean online content, which depends downloading tracklist from our MB server? |
|
|
Cannot replicate. Resolving. |
|
|
So in normal circumstances, it seems that performance isn't that bad, though it isn't as responsive as one would expect of a modern app, particularly when there are a lot of tracks on an album. See: http://screencast.com/t/nHt9mNMJWibD I suspect, however, that the bug originally occurred largely because of some issue with the MediaMonkeyEngine.exe process (possibly #13427) which occasionally uses 50% of CPU utilization and results in the following: http://screencast.com/t/4DeKduwvv6 Unfortunately, I've not yet been able to capture a log of the second case, but if I do, I'll enter a separate bug. |
|
|
Assigning to Michal to review whether there's anything to be improved. |
|
|
Made several changes that result in a very significant improvement, particularly for repeated showing of popups. Leaving assigned to Michal to further review: 1. setPopupListColors() - Could be simplified? Does it need to modify CSS rules, can't it be just local style of the LV? 2. updatePopupSize() is quite slow, can it cache some values? At least calls to getOuterHeight() would better be limited/eliminated. 3. setVisibility(UI.albumImageSquare, true) could be made without layoutchange attribute? 4. Should we consider colorThief to be implemented outside JS? Leaving as Urgent, but feel free to lower to High after a review, to process lower priority items later. |
|
|
1)2)3) improved |
|
|
Leaving at High priority for future consideration of item 4). |
|
|
Verified 2219 For me it is almost immediate especially if it is already opened and only content/color is changed. Note if it is not already open Animation takes 0.2s and is fluent. |
|
|
Closing, I think 4 is not needed, as it is fast enough now. |
