View Issue Details

IDProjectCategoryView StatusLast Update
0012280MMANow Playingpublic2015-01-16 05:46
Reporterrusty Assigned To 
PriorityurgentSeveritymajorReproducibilityalways
Status resolvedResolutionwon't fix 
Product Version1.1.0 
Target Version1.1.0 
Summary0012280: 'Play all random' is broken -- for UPnP (regression)
DescriptionIn build 327, the Play all randomly button is broken:

1) The icon is the regular playback icon rather than the play random icon
2) The functionality doesn't work. A toast appears indicating that the tracks are being added to the NP list, but playback never initiates.
TagsNo tags attached.
Fixed in build

Relationships

related to 0009480 closedmartin Some views need 'All tracks' item 
related to 0011625 feedbackrusty Shuffle mode: play order isn't displayed or retained 

Activities

martin

2014-11-03 11:52

developer   ~0040868

I agree, icon is wrong, because it should be "Play Next" icon since 0011626 when PLAY NEXT overrided SHUFFLE ALL. "Shuffle all" in action bar was duplicate action to shuffle button in NP art view, so it's ok. But the "play next" action doesn't initiate playback, so maybe there should be simple "Play Now" action instead? Also "play next" action doesn't make sense in all views where content is not filtered like "Albums", because all albums are added to "NP list". "Play next" makes sense only in views like "Playlist/items", "Album/item" and so on, I guess. What do you think?

rusty

2014-11-03 14:06

administrator   ~0040869

Last edited: 2014-11-03 14:20

When I wrote that 'Play Next should override Shuffle' I meant that if 'Shuffle mode' is enabled, Play Next should add the track in such a manner that it'll actually Play Next and not randomly.

As far as the 'Shuffle All' button in the action bar, it serves a different purpose than Shuffle Mode in NP Art view:

1) It serves as a quick means of playing all tracks in a view randomly without having to go through multiple button presses (see 0009480 where we'd decided to go this route rather than having Play all / Shuffle all functionality within the list views). Note: I would be very happy to reverse our decision from 0009480 and add an entry to 'Shuffle <current view>' (e.g. 'Shuffle artists', 'Shuffle albums', 'Shuffle tracks', 'Shuffle genres', etc.).
 
2) It shuffles tracks in a way that doesn't have the problems described at 0011625 :
a) it's possible to see the order in which tracks play
b) it's possible to go back and forward in the list while maintaining the play order

I would suggest that in the short term, we revert the button to how it worked, and perhaps add a new bug re. my comment 1) (about reversing 0009480).

p.s. re. where 'Play next' should appear, we can discuss that at 0011626

comments?

martin

2014-11-03 17:27

developer   ~0040873

Fixed in build 1.1.0.328, but unfortunately, for UPnP it's not implemented yet (with with new Tracklist/PlayerManager). I have removed "Shuffle All" button from UPnP section until it will be implemented.

martin

2015-01-15 17:05

developer   ~0041718

Unfortunately upnp doesn't support to get folder items randomly. I was talking to Marek about it and we think that implementation on client side isn't suitable with much work.So we should't support this action in upnp browser.

rusty

2015-01-16 05:46

administrator   ~0041736

OK. Resolving.