View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0010651 | MMA | Synchronization | public | 2013-03-14 21:09 | 2013-08-29 19:46 |
| Reporter | rusty | Assigned To | |||
| Priority | urgent | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.0.4 | ||||
| Target Version | 1.0.4 | Fixed in Version | 1.0.4 | ||
| Summary | 0010651: Deselection of Collections and Parent directories doesn't work | ||||
| Description | 1) If the user has previously selected a couple of Artists in the Auto-sync list, deselecting the Music collection doesn't work. e.g. 1 Click 'Auto-sync server content' --> Auto sync list is displayed, with '[O] Music' showing a filled yellow square to represent the fact that some child content within the music collection has been selected. 2 Click the checkbox twice to deselect '[ ] Music' 3 Click 'back' 4 Click 'Auto-sync server content' again --> 'Auto sync list is displayed, with '[o] Music' showing a filled yellow square!! i.e. the action from step 2 failed to take effect. The solution is to have Checkbox selection at the collection level to work exactly as it does with MMW. i.e. only allow the user to switch between 'Select all' and 'Select selected children' states. 2) If the user then decides to try to deselect the content by navigating to and delecting the '[O] Artist & Album Artist' node, they'll find that the node is greyed out and can't be deselected. In other words, the only way to deselect selected items is to slowly navigate the tree and deselect every item individually! Possible approaches to dealing with this: a) display all selected content within a node at the top of the list. e.g. if Artist > ZZ Top is the only selected item in the auto-sync list, display it at the top of the Artist & Album Artists sync list, rather than at the bottom. This makes it easier for users to manually deselect selected items, though it's still a fair bit of effort. b) Add a Select all items function to the auto-sync list (below the level of a Collection). This lets users select/deselect all items, but limits the possibility of accidentally deselecting items. We could even allow the user to switch between three states when the 'select all items' function is open 'Select all'/'Select none'/'Select previously selected'. c) allow deselection of content at 1st level nodes of a Collection (e.g. user can select/deselect the 'Genres' or 'Artist&Album Artist' node. Downside is that this could be risky--users might select/deselect content and there's no confirmation dialog. I think that a) makes most sense from a strictly usability perspective. | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 157 | ||||
|
|
1) Is clear. 2) I think that c) would be fine, even though I agree that it might be a little risky. However, we could adjust this later in case we have some negative feedback here. |
|
|
We discussed it over IM with Ludek and we agreed that it should behave in the same way as in MMW, i.e. when some subnode is checked: 1. on first level ([ ]Music, [ ]Audiobook, etc.) allow only switching between "checked" and "partly-checked" states 2. on second level ([ ]Albums, [ ]Artists, etc.) allow only deselection of node, i.e. node can be clicked only if it is checked or partly-checked and cannot be re-checked 3. on lower levels - allow switching between all states : "partly-checked", "checked" and "unchecked" I assign it to Ludek to implement on MMW side. |
|
|
I think that both 1&2 should behave same as in MMW, i.e. solution c) in case of 2) Assigning to me as it needs to be fixed on MMW side |
|
|
I fixed it on MMW side in build 1653, but there are some issues that needs to be fixed on MMA side: 1. Switching between "checked" and "partly-checked" states works, but the expand state is not updated: i.e. - if collection is "partly-checked" and user changes it to "checked" then it still can be expanded although MMW correctly sends that it shouldn't be possible - and vice versa if collection is "checked" and user changes it to "partly-checked" then it still cannot be expanded although MMW correctly sends that it should be possible 2. Deselection of "partly-checked" second level node ([o]Albums, [o]Artists, etc.) results in MMA crash (debug logs have been sent) New MediaMonkey.exe and UPnP.dll uploaded to /staff_files/forMarek/ |
|
|
Note that item 2. was finally problem on MMW side, fixed in build 1653. |
|
|
1. fixed in build 157 |
|
|
Verified 158 |
|
|
Tested 159, and this doesn't seem to be fully resolved: 1. On first level ([ ]Music, [ ]Audiobook, etc.) allow only switching between "checked" and "partly-checked" states. -- WORKS. 2. on second level ([ ]Albums, [ ]Artists, etc.) allow only deselection of node, i.e. node can be clicked only if it is checked or partly-checked and cannot be re-checked. -- FAILS-- 'Unable to connect to remote server' error always occurs |
|
|
Should be fixed by Ludek on MMW side. MMA doesn't receive from MMW new state. |
|
|
Fixed in MMW build 1656. |
|
|
Verified MMA 162 / MMW 1656 |
