View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0010558 | MMA | General | public | 2013-02-22 16:24 | 2013-10-28 11:20 |
| Reporter | jiri | Assigned To | |||
| Priority | urgent | Severity | minor | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Target Version | 1.0.2 | Fixed in Version | 1.0.4 | ||
| Summary | 0010558: Lyrics search | ||||
| Description | We implemented a nice lyrics lookup in MM8 (#10445). The same should be added to MMA as well. | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 127 | ||||
| related to | 0010853 | closed | martin | MMA | Lyrics Search: Unknown Artist search is invalid |
| related to | 0010862 | closed | martin | MMA | Playing some tracks triggers search for lyrics for multiple tracks |
| related to | 0000692 | new | MMW v4 | Add Lyrics Lookup (like Evil Lyrics) to MM | |
| related to | 0010616 | closed | Ludek | MMW v4 | Lyrics lookup |
| related to | 0010687 | closed | martin | MMA | Edit properties of track do not reflect on playing track |
| related to | 0010863 | closed | martin | MMA | Lyric editing |
|
|
Fixed in build 107 |
|
|
It's a great start, however, there are a few items missing that are present in the MM8 implementation, that are quite useful, especially on a tablet: 1) Lyrics metadata (e.g. source info) are saved with the lyrics (instead of being displayed separately). 2) No option to 'Save' / 'Search alternate' in cases where the lyrics that are found aren't a good match 3) If the user choose to 'Search alternate', they should be given the ability to edit the search term 4) No ability to edit the search results 5) No option to 'Search for missing lyrics automatically' (+ suboption to 'Save missing lyrics automatically') |
|
|
2)3)4)5) done in build 116 |
|
|
1) done in build 116 |
|
|
Not Working: No Lyrics are found even they exists like http://www.justsomelyrics.com/31829/bruce-springsteen-streets-of-philadelphia-lyrics.html http://letras.mus.br/bruce-springsteen/37986/ or http://www.justsomelyrics.com/4683/deep-purple-soldier-of-fortune-lyrics.html It could be also interesting to use more APIs https://www.google.com/search?q=lyrics+search+API |
|
|
Peke, to clarify, do you mean that it doesn't work at all for you, or is it that it just doesn't find some specific tracks? If so, we should open new a new issue for addition of new APIs... |
|
|
Android version should use the same servers as Metro now. I've tried both songs and both are found without problems in MM8. I think, we use enough lyrics servers, no need to add another, it seems, there is some problem elsewhere. |
|
|
It happens on all search Lyrics using Nexus 7. Lyrics search never ends, but on the other hand it works on both LG and Sony Tipo (Both ICS). Uploaded DDMS Log File from Nexus 7. |
|
|
Fixed in build 117 |
|
|
Tested 117--looking very good. A couple of problems I noticed: 6) When lyrics are looked up, the ending lyrics are displayed instead of the lyrics at the beginning of the track! I understand the rationale (the buttons are at the end) but it would be preferable to have a means of showing the buttons without forcing the user to not see the beginning of the lyrics. 7) When the screen turns off, and the user turns it back on, any lyrics that were displayed are lost and the lyrics must be looked up again. |
|
|
6) Why not moving Buttons on the beginning? 7) This only happens if user do not make selection, like it switched back to Album artwork and than back to lyrics. NOTE: Lyrics search works on all of my devices using 117 |
|
|
8) Search Alternate always uses the first available server, i.e. there's no way to get results from the second one, etc. |
|
|
Fixed in build 118 |
|
|
Tested 118, and noticed another issue: 9) When Lyrics 'Auto Search' is enabled, if the user is playing music, lyrics are looked up automatically and the UI switches to the NP Lyrics view even if the user isn't in that view! This is an annoyance--the user wouldn't expect this UI to appear unless they are in the lyrics view to begin with. i.e. - if 'Auto Search' is enabled but 'Auto save' isn't, then lyrics should only be looked up automatically when the user is in or switches to the lyrics view, and this configuration shouldn't trigger automated switches to lyrics view. - if 'Auto search' and 'Auto save' are enabled, then lyrics should be looked up and saved regardless of what view the user is in. But again, this configuration shouldn't trigger automated switches to the lyrics view. |
|
|
Fixed in build 119. |
|
|
Generally it works with one small issue. 10) Alternative search should loop results and let used decide which one better suites 11) It is very annoying on My LG phone (little bit less on Nexus 7 due to its screen res. in landscape view) that wen you click on Search Alternative On screen keyboard is show immediately, in most cases user would only needed to click on SEARCH and Search criteria is correct. 12) When doing Search Alternative there should be an check box to not repeat search Metadata prompt for this session (until view is changed) 13) Even track have lyrics it could be useful to have search Lyrics in context menu |
|
|
10) I think that's a nice to have to consider for the future. Not needed for 1.0.4. 11) In my tests, the keyboard doesn't show unless you click in the textbox to edit the artist/title. i.e. no change required. 12) I don't understand. 13) Good point. If the user is in lyrics view, it would make sense that if the user taps the lyrics, then the 'Search alternate' and 'Edit' buttons should appear. |
|
|
To clarify: 11. It happens every time on Nexus 7 12. Each time user clicks Alternative search Dialog shows, with this option user could set that alternative search shows only first time for that song. |
|
|
So 11. is to be reviewed, the rest to be discussed as future improvements. |
|
|
Fixed in build 127 |
|
|
Can you please elaborate what points are fixed? |
|
|
The point 11 should be fixed. |
|
|
Verified 11. in 127 But I have found that if incorrectly tagged tracks (users complain on downloaded MMW tracks) which contain incomplete Lyrics tag there is no way to manually start search like explained for 13. by Rusty in 0010558:0035594 which would be a long term solution. |
|
|
Ok, leaving 13) open as a lower priority item. |
|
|
Can you please triage 13. as in case of Auto search/save 0010853 gets really serious. |
|
|
Tagging as resolved, and opened a new issue re. Lyrics Editing at 0010863 |
|
|
Verified 177 |
