0010105: Sync list fails to update to reflect changes to metadata - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update

0010105	MMA	Synchronization	public	2012-11-30 17:57	2021-04-01 02:32

Reporter	rusty	Assigned To
Priority	immediate	Severity	major	Reproducibility	always
Status	resolved	Resolution	suspended
Product Version	1.0.1
Target Version	1.0.1

Summary	0010105: Sync list fails to update to reflect changes to metadata
Description	If the user chooses e.g. an Album for the server-side sync list and then changes the album name --> the Album is no longer selected!! This leads to unexpected behaviour such as an album being deleted from the device because it's no longer on the sync list.
Additional Information	http://www.mediamonkey.com/forum/viewtopic.php?f=21&t=69102 Tested build 70
Tags	No tags attached.

Fixed in build

Ludek 2012-12-01 02:22 developer ~0033549 Last edited: 2012-12-01 10:13	Rusty, I understand your point of view and the reasons why you see this as a bug, but imagine these cases: CASE A: - User has selected "album 1" to sync to MMA, there are 10 tracks from "album 1" synced to MMA - User renamed 5 tracks of "album 1" to "album 2", i.e. half of tracks are now in "album 1" and 5 tracks are in "album 2" Do you think that both "album 1" and "album 2" should become selected on sync-list without a user interaction? I don't think so... CASE B: - User has selected "album 1" t sync to MMA, there are 10 tracks from "album 1" synced to MMA, but there is another 10 tracks unsynced (only in MMW) from "album 2" - User renamed _all_ 10 tracks of "album 1" to "album 2", i.e. 10 tracks in MMA - Do you think that "album 2" should become selected including all 20 tracks ? i.e. it would add 10 tracks from "album 2" that were previously de-selected to sync?? I don't think so... CASE C: - User has selected node Music->Rating->5 Stars to sync to MMA - all 5 stars tracks are synced to MMA - user changed rating of one track from "5 stars" to "4 stars" Do you think that _all_ "4 stars" tracks should be selected to sync without a user interaction? I don't think so... i.e. I want to say that by changing properties you can always accidentally de-select the edited tracks from sync-list, but this is not a bug. Nice example is CASE C. AFAIK this has been always the case also for USB sync.

jiri 2012-12-03 08:40 administrator ~0033562	I think that case C as described by Ludek is a little different situation, but cases A&B illustrate quite well some tough decisions we have to make. That said, I agree with Rusty, that this could be considered as a bug. Given the fact that it has always worked this way and also that it isn't easy to solve, I'd defer for a later decision...

rusty 2012-12-03 23:04 administrator ~0033589	My point of view is that this should work consistently whether sync is initiated from MMA or MMW. Re. CASE A, currently, in MMW, this works as follows: 1 Select Artist1 and Playlist1 to sync list 2 Rename Artist1 and Playlist1 to Artist2 and Playlist2 -->Sync list shows Artist2 and Playlist2 as selected 3 Rename half the tracks in Artist2 to Artist3 -->Sync list shows Artist2 as selected (BUT there is a bug in that Artist 2 still seems to contain the tracks that were renamed to Artist3!) Outside of the bug described above, this is how I think that MMA should work as well. Re. CASE B, currently in MMW, it works as you described--i.e. all the tracks get selected. Whether this is the most desirable behavior or not is debatable, but I think it probably makes sense. Re. CASE C, MMW doesn't currently work this way (although I suspect it might if only a single 5 star track existed and it was re-rated to 4 start). Summary: It seems that in MMW, in cases where all tracks of a given attribute are modified, the selection in the Sync list is also modified.

rusty 2012-12-04 18:32 administrator ~0033639	Wouldn't it make sense (long term) that if all tracks with an attribute (that is selectable in the sync list) of a given value are modified, that the value for the attribute on the sync list is also modified? If not, just resolve\|suspended.

jiri 2012-12-04 21:59 administrator ~0033644	Yes, that's along the lines of a hack needed. Due to complexity and unclear consequences - Suspending, to be re-evaluated sometimes later if needed.

peke 2012-12-08 23:50 developer ~0033776	I have tested this with 75 using Delete tracks not in Sync list and like pointed I do not think this as bug, but rather complex tweak for improved guessing. For example I initially set that I sync all tracks form Queen with 0 , 5 Star Rating Sync to Device. I listened tracks and few were tagged as 5 star but few were tagged as 3 Stars, making them not wanted on Sync anymore and they should not be synched, but those that are now 5 stars should be synched. Problem arise if there is multiple criteria that can influence change.