View Issue Details

IDProjectCategoryView StatusLast Update
0019253MMW 5Tagging / organizing (properties / auto-tools)public2023-12-20 16:17
Reporterpeke Assigned To 
PriorityurgentSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version5.0.3 
Target Version5.0.4Fixed in Version5.0.4 
Summary0019253: Album art lookup is still executed on album nodes even it is disabled in Options
DescriptionAlbum art lookup is still executed on album nodes even it is disabled in Options.
Steps To Reproduce1. Disable all auto lookup in Tools -> Options -> Library -> Metadata lookup
2. Navigate Music -> Albums
3. Start playback of Album that do not have Lyrics and Album Art
4. Album Image is looked up and presented with Save button. Expected to Show Lookup icon

After that In preview Lyrics show "Lookup" link which is OK, But Album art show searched searched. Expected it should still show "Lookup" Link, so bug in that Music -> Albums override auto Lookup settings.
Additional Informationhttps://www.mediamonkey.com/forum/viewtopic.php?t=102235
TagsNo tags attached.
Attached Files
image.png (2,581 bytes)   
image.png (2,581 bytes)   
image-2.png (43,633 bytes)   
image-2.png (43,633 bytes)   
image-3.png (12,975 bytes)   
image-3.png (12,975 bytes)   
image-4.png (45,034 bytes)   
image-4.png (45,034 bytes)   
Fixed in build2665

Relationships

related to 0017638 closedLudek Allow non user-initiated traffic to be disabled 
related to 0019210 feedbackmichal Album Art lookup: Like Save Icon when there is no album art there should be Search icon 
related to 0020489 feedbackrusty Option to disable online accesses 

Activities

michal

2022-07-13 15:52

developer   ~0068813

This is by design, we always search for image in Album view, as it fetches online data anyway. Assigning to Jiří to decide, whether leave it as it is.

peke

2022-07-13 19:38

developer   ~0068816

I agree, but we should unify this across MM, so that it is clear for users where you can turn off Auto-Lookup and where that option is overridden, like user pointed in Forum

peke

2022-07-15 17:04

developer   ~0068841

Additional consideration posted in Forum under https://www.mediamonkey.com/forum/viewtopic.php?p=499238#p499238

jiri

2022-07-18 14:34

administrator   ~0068849

This really looks like an inconsistency and it seems to be a good point that automatic lookup can occur then for users who don't want it and also that it can show artwork for tracks that don't have any (perhaps intentionally). I guess that the artwork could remain empty until a 'Lookup' button is pressed in case the auto-lookup is disabled? Assigning to Rusty for an opinion.

rusty

2022-09-13 19:04

administrator   ~0069228

Last edited: 2022-09-22 16:58

I agree with Jiri/Peke and the user: if artwork / lyric lookup is disabled it should be prevented from entering the library in any way (even as unsaved artwork/unsaved lyrics). This clearly applies to Artist & Album nodes, & the Preview window. The following cases are a bit more complicated:

a) The Info panel in Browser views: by definition, it should always lookup artwork/metadata regardless of the lookup settings. It might be confusing if artwork is shown in the info panel even when there's none in the library, but the fact that the artwork is associated with an article makes it clear that the info panel consists of looked up data and isn't part of the library. That said:
i) the looked up artwork in the info panel shouldn't automatically appear in the library (Preview/Properties) as unsaved artwork (although it should have a 'save' button to add it to the library).

b) Lyrics panel: shouldn't automatically look up lyrics, but it should be modified to use the same approach/UI as is used for Artwork in the Preview panel when artwork lookup isn't enabled. i.e. include Lookup functionality, and the ability to save 'unsaved lyrics'.

c) It can be unclear how to configure Lookup settings for both the Preview and Lyrics panels. We may want to consider adding the '[gear] Lookup...' option to the Preview panel & Lyric Panel (though I'm not sure that this is necessary).

rusty

2022-09-22 16:58

administrator   ~0069486

Last edited: 2022-09-22 17:45

Update re. a)i):
Per discussion, the suggestion (of loading the artwork to the info panel, but not caching it as 'unsaved artwork') might be as annoying to users of the info panel as artwork being looked up in the info panel and being cached as 'unsaved artwork'.

An alternate approach would be to:
ii) Make the Info Panel work like the Preview window when artwork lookup is disabled. i.e. show Artwork: Lookup if Artwork lookup is disabled. But as pointed out by Michal, this could be annoying to anyone who enables an Info Panel view, since by using that view, they expect it to be populated.

So for 5.0.4 we probably shouldn't make any changes re. info panel artwork handling, and collect more feedback on this issue.

michal

2022-09-22 17:54

developer   ~0069488

Last edited: 2022-09-22 17:55

Fixed in build 2665. Info panel still uses search, all other places not (including lyrics window).

rusty

2022-09-23 01:56

administrator   ~0069498

Last edited: 2022-09-23 15:20

Here's a summary that I'd written for Martin outlining how we got to the current decision (to save someone in the future the hassle of trying to decipher the thread above):
If the user looks at an Album with the Info Panel enabled, then the Artwork will display in the view, and will be cached as 'unsaved artwork'.

We'd originally planned on just not caching the artwork in that case, but that would have resulted in:
- unnecessary lookups each time the art/article are looked up
- discrepancy between the Info Panel and preview
Which we thought might be an even worse outcome.

So then we thought about making the process manual (via an Artwork: Lookup link), but decided that if users enabled the Info Panel, they probably did so in order to see the Artwork/Articles, and prompting manually download each image might not be desirable.

So we left things as is for now with respect to Artwork in the Info Panel.

lowlander

2022-09-23 18:55

developer   ~0069511

Verified on 2665 that Artwork and Lyrics lookup isn't happening in the Preview, Lyrics and Filelisting (NP and file lists with Artwork/Lyrics display).

Wiki has been updated.