View Issue Details

IDProjectCategoryView StatusLast Update
0004711MMW v4Main Panel/Toolbars/Menuspublic2009-02-21 04:47
Reporterrusty Assigned To 
PriorityurgentSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version3.1 
Fixed in Version3.1 
Summary0004711: In-place Edits of Artist field do not work correctly for case changes
DescriptionThere's a bug in which in-place edits of the Artist field are not updating correctly. Note that in contrast to the original bug report in the forum, I don't believe that there is any problem with auto-organize functionality. The bug consists of 2 issues:

1) Change case in Artist field (e.g. 'ABC' --> 'abc' --> Field updates, but Tree fails to update (Auto-organize works correctly)!

2) Change case in Artist field back to what it was originally (e.g. 'abc' --> 'ABC' --> Field appears to update briefly but then reverts to its previous form (and auto-organize appears to fail even though it's working correctly, because it appears to the user that Artist has changed to ABC, but the mask generates 'abc' instead because the change is somehow reverted). OR, the field fails to update altogether (e.g. it shows 'abc' despite the user's edit). The only way to get around this is to make the edit in the Properties dialog.

Note that these types of issues don't occur with other fields eg.:
-change case in title and auto-organize --> appears correctly in MM DB and Explorer
-change case in Album field and auto-organize --> Tree updates correctly auto-organize works correctly
Additional Informationreported at:

http://www.mediamonkey.com/forum/viewtopic.php?t=28477
TagsNo tags attached.
Fixed in build1185

Activities

rusty

2008-05-21 15:36

administrator   ~0014049

Upon further testing, I noticed a third issue:
3) When performing steps 1/2 in the Album Art view and then attempting to Find more from same > Folder (Explorer), MM sometimes cannot seem to find the track in question and can't open the folder. Switching nodes/refreshing seems to solve this particular issue, but that shouldn't be necessary.

petr

2008-05-21 17:51

developer   ~0014051

Fixed in 1176

rusty

2008-05-22 04:03

administrator   ~0014059

Tested build 1176. Items 1,2,3 are fixed, but a new item 4 seems to have been introduced:
4) If the user edits the Artist in Album Art view, and Album Artist is identical, then the change isn't applied to the Album Artist. We should apply the heuristic for keeping Artist & Album Artist in sync across all views.

petr

2008-05-22 10:20

developer   ~0014066

It's more complex issue. Main problem is that artist change reflects only selected track(s), but this kind of change should reflect in all tracks with this artist in memory and in DB too. For 3.1 we're supposed to make a better in-memory management for songs data and using this management these changes should be easier to manage.

Anyhow we're agreed with Jiri that it's very high risk to fix it now and we should postpone it to 3.1.

rusty

2008-05-26 16:43

administrator   ~0014102

5) When changing the Artist field, Artist nodes in the tree are updated, but Album nodes are not. e.g.

Change: Artist=Allman Brothers, Album=Best of --> Artist=Allman brothers, Album=Best of
-->
Artist node in tree --> 'Allman brothers'
Album node in tree --> 'Best of (Allman Brothers)'

I'm not sure if this is another example of case 4 or not.

jiri

2008-05-26 21:24

administrator   ~0014106

5) Fixed in build 1179 by Petr.

petr

2008-08-20 21:29

developer   ~0014458

Last edited: 2009-04-27 16:27

This issue should be fixed in 1185.

[Edit by Rusty based on feedback from Petr:
Problem in 1183 and older was that all tracks in memory weren't updated (only currently loaded tracks in tracklist). For 1185 Petr made a change in functionality which manages only one instance of the track in memory.

Prior to 1183, functionality was:
- one instance of the track in tracklist
- another one instance of the track in burning queue
- another one instance of the track in syncing queue
- another one instance of the track in auto volume analysis
...

Now every part of MM uses a single instance of the track, so updates of the track in tracklist reflect in other places where the track appears.

For example ... user currently syncing the track while a field is being edited (e.g. change artist from 'queen' to 'Queen') in tracklist. This mechanism automatically updates track in syncing queue and every other place, where the track is used.

btw: this issue was originally introduced as a problem with auto volume
analysis, where user changes track's field while the track is being analyzed and once analysis completed, the modified field was reverted. ]

stephen_platt

2009-02-21 04:47

developer   ~0016839

verified 1224