|
|
OK, the question is what should happen in such a case.. By default there is Retain backups: [3] and currently the old backups are deleted only once the new backup is created.. We could solve it by deleting all but one backup despite the value configured, or (better case) add a warning --> which would require new strings to translate, so probably something for 2026 ? In either case whenever there isn't enough space to make a single backup then a message is needed anyhow, something like: There isn't enough space to backup database/settings, please clear space in the backup location: C:\... [OK] Assigned to Rusty for review.. |
|
|
1) Regardless of whether we add any new strings, MMW shouldn't crash in this case. 2) We can re-use existing strings for a generic message that applies to either 1 or multiple backups. e.g.: Backup FAILED! Insufficient space available. Please free up space for MediaMonkey to function properly. (Path: <backup path>) [Settings] [Cancel] |
|
|
Fixed in 3168 |
|
|
Set backup to a new full drive and created backup. MediaMonkey goes through the motions, and seems to successfully backup, however no backup is created and no error to the user. |
|
|
I needed to add more debug messages to see why this happened for you, please download this MediaMonkeyEngine.exe : https://www.dropbox.com/t/x9XnFgrHQpZIoNzp and replace it over your existing C:\Program Files (x86)\MediaMonkey\MediaMonkeyEngine.exe and generate new DbgView log.. |
|
|
New log uploaded. |
|
|
hmm, seeing in code that when the directory to be backed up does not exist then it tries to create the directory and if that also fails then it is using the standard DB path, anyhow I can replicate now, thanks! EDIT: Actually there was an error in code and whenever you set up non-existing directory then it used the default location.. => fixed in 3169 |
|
|
3169 crashes when doing a backup to a full destination, Copy/Paste becomes disabled and AV log can't be send. Log added. 3169 also crashes when doing backup to a non-existent location. In this case I just appended /Test to the normally used Path (and without it backup works). The Test folder doesn't exist. Note that this issue prevents MediaMonkey from starting if auto-backup is selected. |
|
|
image-5.png (15,167 bytes) |
|
|
Note that MM does warn on backup failing when drive is full, but it leaves a 0kb backup zip file. |
|
|
Fixed in 3171 Test note: trailing backslash needs to be missing to replicate the issue |
|
|
All AV's resolved on 3171. However I think it would be better if MediaMonkey auto-applies missing \ at end of Path, instead of providing error to user. Particularly because the error doesn't inform user of actual issue (the error has the missing \ in the Path). Cancel did not stop the backup as expected, pressed Cancel a second time and backup proceeded. At the end showed error again and then stated backup completed. Log supplied. (Ignore did basically the same thing). No backup was found. image-7.png (11,074 bytes) image-8.png (48,860 bytes) |
- Anonymous
