View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0020757 | MMW 5 | General | public | 2024-03-24 18:33 | 2024-04-25 10:32 |
| Reporter | zvezdan | Assigned To | |||
| Priority | none | Severity | minor | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Fixed in Version | 5.1 | ||||
| Summary | 0020757: attributePopup lvPopup is very hard to skin | ||||
| Description | You should not set colors in JavaScript. These colors are very hard to be overridden in custom skins, especially when you use !important after color value. Well, I think that I managed to override your colors for popups, but I spent several hours on that. Why don't you use CSS custom variables to set these popup colors (and other colors set in JS)? You are already using them to set colors for Visualizer. | ||||
| Tags | todoc-dev | ||||
| Fixed in build | 3016 | ||||
|
|
Fixed in build 3016. Skinning of popups reworked, so they can be defined a lot easier, standard skins adjusted, so they better correspond to other parts of each skin. JS prepares variables during opening popup bound to this popup, so skins can display colors derived from the artwork colors, they may use them at their own discretion. They are used by default by all standard skins. Prepared colors from artwork are saved to these variables. Clr = for color/fill, BClr = for background color, Hover = for hover state, Text = for text, Icon = Icon, Select = for selected state. Nowplaying = special color for nowplaying state, Filter = contains default drop shadow for icon on hover: --lvPopup-Clr-Text --lvPopup-Clr-Hover-Text --lvPopup-Clr-Hover --lvPopup-BClr-Hover --lvPopup-Clr-Select --lvPopup-BClr-Select --lvPopup-Clr-Hover-Select --lvPopup-BClr-Hover-Select --lvPopup-Clr-Hover-Icon --lvPopup-BClr-Hover-Icon --lvPopup-Filter-Hover-Icon --lvPopup-Clr-Nowplaying |
|
|
Great! |
|
|
Verified 3016 |
