View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0020630 | MMW 5 | General | public | 2024-02-22 20:29 | 2024-03-22 02:42 |
| Reporter | zvezdan | Assigned To | |||
| Priority | none | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Fixed in Version | 5.1 | ||||
| Summary | 0020630: Rows on Details page in Properties dialog have inconsistent height | ||||
| Description | There are three rows on the Details page for audio files that have smaller height than rest of the rows on that page: Start time/Stop time, Play c. / Skip c. and Track v. / Album v. You should use uiRows class for the table data-id="section3", just like you use it for section4. I resolved that with my skin, but I think it should be done in general. | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 3005 | ||||
|
|
Fixed in build 3002. |
|
|
Verified 3003 |
|
|
Sorry, my suggestion is not the best solution. Now, the first row with Grouping/BPM has inconsistent height. It seems that the section3 should have uiRowCenter class instead. |
|
|
Fixed in build 3004. |
|
|
1) Details seems to be using different spacing between rows than Classification and Custom, the latter having less height. 2) Labels on Basic are inconsistent with labels on all other tabs. We should use the same throughout Properties. My vote would go to in front like Details. 3) Lyrics label is not aligned with Lyrics field (label is more to the left than the field). 4) Classification checkboxes (on multi-file edit) have large space between field and checkbox. Either make the field widths (best, as they can have large values) full window width or move checkboxes. |
|
|
1) It depends on skins, but I agree - all these sections should have uiRows class (unless section3, that is already resolved); 2) I am not sure that understand about what inconsistency do you mean. If you are talking about their position, MM4 had similar design with most labels on the Basic page above their fields. I agree with your suggestion and I would prefer them to be on the same line with their fields as on the Details page, but such implementation would require significant design changes. 2 a) Why the labels on the Details page above Title, Artists, ... fields have fieldHeading class with a smaller font in Material Design and Flat Monkey? I know, that is your design choice, but that is inconsistent. 3) It seems that this depends on skin. With those that I have that label is a bit more to the right than the field, not to the left. Also, all other labels that are above their fields: Basic / Comment, Custom / Extended tags. 4) I agree. 5) All rightmost checkboxes (on multi-file edit) have large space after them, i.e. they are not right aligned with the right margin / the right side of the Cancel button. 6) There is an empty space after rightmost fields on single-file edit Properties dialog, i.e. the right side of these fields are not right aligned with the right margin, e.g. Genre dropdown, Track # textbox and so on. 7) Comment label and check box (on multi-file edit) are too close to the field, unlike Lyrics. |
|
|
Most fixed in build 3005. I will not redesign layout of Basic tab in this phase (2), it is done this way for ages and was in MM4 too. It was even before I merged MM team, I guess it is because of saving space and have enough space for fields, so the dialog is not too large. It is quite complex tab, which has to display different fields based on track type. But you can design new layout for next main release, insert as issue and assign it to Rusty or Jiri to discuss. |
|
|
Verified 3006. |
