View Issue Details

IDProjectCategoryView StatusLast Update
0017421MMW 5Now Playingpublic2021-01-29 21:20
Reporterrusty Assigned To 
PriorityurgentSeverityminorReproducibilityalways
Status closedResolutionreopened 
Product Version5.0 
Target Version5.0Fixed in Version5.0 
Summary0017421: MiniPlayer / MicroPlayer mode is broken by video playback (regression 2296)
DescriptionThe miniplayer/microplayer functionality is broken in build 2296 by the attempted fix #15675

Before describing the issue, let's remember the point of these modes:
- MiniPlayer: exists so that the user has an always-on portal from which they can see/control their playing media/playlist while they're doing something else.
- MicroPlayer: exists so that the user can control their currently playing content even a they're doing something else

Let's also remember that in MMW5, Music collections consist of audio files, music videos, and youtube videos.

What's broken:
1) Attempts to minimize to miniplayer/microplayer do nothing when a video is playing (for regular video and youtube video). Note that removing the UI to minimize isn't a good solution either as it would be very strange for the functionality to appear/disappear depending on what is playing.
2) Mini/MicroPlayer modes get disabled without user intervention. When playing such music, using the miniplayer/microplayer, MediaMonkey will suddenly switch from these modes to a full MM Window when a video starts playing, and then fail to revert to the selected playback mode.
2b) As a consequence, once these modes are disabled, the user also loses the persistent 'always-on' interface to see their content and control it.
See: https://www.screencast.com/t/9KeJsAWUO

A much cleaner that doesn't break the functionality would be to revert this regression and:
i) In the MiniPlayer: display video within a Window inside the miniplayer, scaled to the width of the player.
ii) In the MicroPlayer: don't display video (this is reasonable since the microplayer is really just a set of buttons to control playback when MM is minimized).
TagsNo tags attached.
Fixed in build2302

Relationships

related to 0017407 closedpetr MiniPlayer: Minimize video breaks video playback 

Activities

petr

2021-01-28 11:10

developer   ~0061586

Last edited: 2021-01-28 15:03

Based on internal discussion with other devs we've descided to always use main window to video playback.

Fixed

rusty

2021-01-29 02:57

administrator   ~0061623

This is working quite well in 2300. The only issue I noticed was:
1) MM switches from mini-player to MM window by itself if the miniplayer Video is minimized e.g.:
1 Play Video followed by Audio
2 Switch to MiniPlayer while Video is playing, and resize the Video window as small as possible
3 Minimize the Video window
4 Click NEXT
--> MiniPlayer switches to regular mode!
--> and the MM window is shrunk to the size of the Video window at Step 3!

petr

2021-01-29 11:30

developer   ~0061628

Fixed

peke

2021-01-29 21:16

developer   ~0061653

Verified 2302

I am unable to replicate using 2302 (2301 observe behavior) and steps from 0017421:0061623

rusty

2021-01-29 21:20

administrator   ~0061658

Verified 2302. Closing.