View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0016454 | MMW v4 | Framework: Tagging | public | 2020-03-25 01:19 | 2020-04-01 22:42 |
| Reporter | rusty | Assigned To | |||
| Priority | immediate | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 4.1.27 | ||||
| Target Version | 4.1.28 | Fixed in Version | 4.1.28 | ||
| Summary | 0016454: Tagging nonMP3 files with ID3 Tag may cause file corruption | ||||
| Description | It seems, some users have sometimes M4A/FLAC/WAV files with MP3 extension and such files are corrupted, when used tagging (it adds non-standard ID3 tag at the beginning of such files). It would be better to check files before ID3 tagging, that they are really MP3s, to avoid this. In addition, clean ID3 functionality should be updated so that it can be used for non-MP3 files so that users can easily fix any corrupted files regardless of file extension. | ||||
| Additional Information | VBC-218-20493 EFC-805-56756 https://www.mediamonkey.com/forum/viewtopic.php?f=26&t=91430 http://forum.mediamonkey.com/viewtopic.php?f=2&t=30217 | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1900 | ||||
|
|
Fixed in 4.1.28.1898 and merged to 5.0.0.2235 |
|
|
Verified. In Order to test this there should be mass number of corrupted files and then test Clean ID3 on them. To fully test I have used these steps: 1. Selected 300Files in MM library random Formats (MP3, MKV, M4A, ....) 2. Drag and drop them to temp Folder (Windows explorer) 3. User Bulk Rename to Appent Extension .mp3 to all of them 4. Tagged Any ID3 Tag onto them and added Album art to be sure (MMW 1897 as it is unclear what is removed in MM5 2235 and if MM5 can tag such files 0016436:0057355 ) 5. used Bulk rename to revert added extension and get them to original state with added ID3 Tag 6. Verified that few files are not playable from each format (excluding those that we already fixed for skipping ID3) 7. Selected them -> Tools -> Advanced Tags -> Clean ID3 8. Try to play them again -> Confirm they are playable 9. Quick Skip After 10+ tracks various formats. 10. Select all And Used convert to MP3 (Excluded Video files playback means they are OK) 11. Checked if they are converted without error. Only thing Missing is that MM 2236 do not re-read tags after Fix is applied for non Library tracks, which makes possible tag overwrite. Steps to reproduce: 1. Drag and drop non-library corrupted file to MM5 Now Playing 2. Play File 3. Correct tags are not read 4. Update Tags 5. Correct tags are overwritten |
|
|
Fixed in build 1899. |
|
|
Re-opened: according to user from VBC-218-20493 the auto-fix works when playing the first corrupted file , but it freezes on the second, details and log in the ticket. |
|
|
Verified. The update: - Prevents id3 tags from being written to files that have an MP3 extension that aren't MP3s - Removes malformed ID3 tags on non-MP3 files if they cause problems. - Allows the Tools > Advanced tag management > Clean ID3 V1 and V3 function to clean non-mp3 tracks that have the problematic tags. Note: it should only be used on MP3 files if the user doesn't mind losing album art (which is included in ID3 tags for MP3 files). |
