View Issue Details

IDProjectCategoryView StatusLast Update
0016121MMW 5Main Panel: Toolbars & Menuspublic2019-11-22 01:21
Reporterpeke Assigned To 
PriorityurgentSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version5.0 
Target Version5.0Fixed in Version5.0 
Summary0016121: Play now: Tweaking play now options --> Poor performance with large number of tracks
DescriptionIf User have setup Play Now to "Selected + subsequent tracks" and double click to play now on Music library that lists Large number of tracks (160k+ in this user case MediaMonkey.M3U8 file was 25MB) MM UI is locked for prolonged time.

For this user I presented him with two solutions:
a) Always use Context menu to start playback of selected tracks (it adds two or more mouse clicks)
b) Change playback rules for Music to "Clear list + Play selected" and in player change Play now options to: While not playing -> Play now, While Playing -> Play last

He opted for b) as when start MM it either start playback and then just add new tracks to now playing by double clicking or double click on some track to start new now playing list and then fill it with double click.

This is not first time users reported this. So I would suggest that we show warning dialog about when more than 10000k (or even less number of tracks) tracks are added into now playing in order to warn user it can slow down MMW along with Options "[ ] Do not ask again [OK] [CANCEL] [SETTINGS]" Where settings would point to Playback rules settings in Options.
Additional InformationPoint 3 in Notes of Ticket MDO-861-35643
TagsNo tags attached.
Attached Files
Fixed in build2214

Activities

rusty

2019-11-19 02:57

administrator   ~0055398

Last edited: 2019-11-19 14:00

The issue faced by the user is that the default MM settings can result in delays for large libraries when the user clicks a track resulting in 160000 tracks being added to the Playing list (and the associated .m3u file). I'd prefer to actually solve this rather than give a warning.

Possible approaches that I can think of:
1) Fix the problem via performance improvements. I'm not the expert, but e.g.
- Initiate playback immediately
- Use the DB rather than a file operation
- If the file operation is required (e.g. for compatibility with other players), only use it if other players are enabled
- etc...

2) Short term hack: In the Default 'Play now' Action section, add a limit for the 'Clear list & play selected + subsequent setting e.g.
 _Clear list & play selected + subsequent_v_ . . Limit: _10000_ tracks

3) Worst solution: change the default setting for the Default Play Now action to 'Clear list and play selected'. But I don't like this--I think the solution is worse than the problem.

Ludek, what do you think? We can push if 1/2 aren't quick fixes.

Ludek

2019-11-19 17:16

developer   ~0055406

Last edited: 2019-11-19 17:16

I have just tried on user database with more than 1 million of tracks and I have not observed any slowdowns.
Playback started immediately after the double-click and the files were added into Playing panel without any UI freeze.

@Peke, from the ticket MDO-861-35643 it sounds to me that user has tested on MM4 and not on MM5 ?

1 million tracks.png (254,594 bytes)   
1 million tracks.png (254,594 bytes)   

peke

2019-11-20 02:55

developer   ~0055414

Last edited: 2019-11-20 02:56

I can easily replicate on my 200k library after faster browsing and playing tracks with double click.

I kept Now Playing Open, but user could simply hide right panel as it uses main track view to start playback.

My Now playing m3u8 was 122MB and on MM5 restart loading it also crashed MM5 after some time. I was trying to play some tracks

Uploaded Video File, My mediamonkey.m3u8 and full log file from mm5 restart that in the end resulted in CB5975CC LOG file

To answer your question yes user was using MM4, but there we can't do much, but we can make needed changes in MM5 and improve this.

Ludek

2019-11-20 11:37

developer   ~0055419

Fixed in 2214

peke

2019-11-22 01:21

developer   ~0055441

Verified 2214

Much Better performance.