0004412: Fixed failed rips should generate a single error message after rip operation - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update

0004412	MMW v4	Conversion/Leveling	public	2008-02-20 18:07	2008-12-07 18:33

Reporter	jiri	Assigned To
Priority	urgent	Severity	minor	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	3.0
Fixed in Version	3.1

Summary	0004412: Fixed failed rips should generate a single error message after rip operation
Description	This was reported by a user: ---------- When ripping CDs with media monkey that have many CD reading error it is a real pain to have to go back and forth to click "ignore" on the pop up. It would make more sense for you to add an "ignore all" option so that I only have to click once and not be interrupted on my computer a zillion times. I've wasted so much time on this issue I was forced to make this request. Now, I am real upset about this issue. Not only did I have to wait around and click the ignore about 30 times, but then after if finally got over the bad spot the error pop up window popped up while I was typing and took one of my keystrokes as a termination command and ended the ripping. All that effort was completely wasted. A simple "ignore all" option would solve this common issue. ---------- It would really make sense to add Ignore all button, so that further errors are ignored. This should persist for all errors on given ripping session (i.e. for all tracks being ripped). Therefore, ErrHandlers.pas approach should probably be used.
Tags	No tags attached.

Fixed in build	1186

Ludek 2008-03-18 21:32 developer ~0013367	Fixed in build 1143.

rusty 2008-03-19 21:30 administrator ~0013392	Minor issue: button says 'Ignore to all' instead of 'Ignore all'. Note: this still isn't the 'full' solution to this problem. The 'full' solution would allow the user to set the desired behaviour once (e.g. prompt once, don't prompt and generate log), and if desired to simply show a log at the end of the burn operation indicating which tracks failed.

Ludek 2008-09-04 14:53 developer ~0014532 Last edited: 2008-09-04 15:06	ok, I have fixed the minor issue: i.e. 'Ignore to all' -> 'Ignore all' in build 1186. Re: the 'full' solution - where should this be situated? Somewhere in Options? Options\|CD Ripping?

rusty 2008-09-09 17:33 administrator ~0014551	I think that no additional options need to be configured if we take the following approach: When an error is encountered, a dialog along the following lines appears: ------------------------------------------- Error: ------------------------------------------- There was a problem ripping the following Track(s): \|------------------------------------- \| Artist \| Title \| File \| U2 \| Desire \| U2-The Joshua Tree-Desire.mp3 \| .. \| \| \| \|------------------------------------- [Continue] [Cancel] -------------------------------------------- If the user: a) Doesn't do anything, then the ripping operation i) re-attempts the problem track once ii) continues onto the next track iii) shows subsequent errors in the same dialog b) Clicks [Cancel], then the operation is halted completely I think that this approach would work for all items in bug 0000051

rusty 2008-09-09 17:34 administrator ~0014552	Reminder sent to: jiri Jiri, please review my comments in this bug--we should take an approach that would work for all items described in bug 0000051, and I'd like you to review before Ludek goes ahead with this.

jiri 2008-09-09 18:33 administrator ~0014555	Ok, I'd suggest to try to implement this issue only and based on how are we satisfied with the result, we could include 0000051 (So the dialog should be implemented with this intention in mind, i.e. with a possibility to modify messages, etc.). I'd propose some small changes: ------------------------------------------- Error: ------------------------------------------- There was a problem ripping the following Track(s): \|------------------------------------- \| [x] Retry \| Problem \| [x] \| Error ripping track #3 (U2 - Desire) - 5 read errors \| .. \| \| \|------------------------------------- [Save as Playlist] [Continue] [Cancel] -------------------------------------------- The intention of the changes is as follows: 1. Retry column - user can easily select which actions to retry, or all/none of them. 2. Problem column - one general column instead of several showing a detailed description of the problem. This will be better usable in 0000051. 3. Save as Playlist - user can save all tracks having problem to a Playlist and handle them as necessary later. Btw, the workflow should be: At the moment a read error occurs, MM should automatically retry the failed read several times (10?) - I think that this is already implemented. In case all attempts fail, it's considered as a read error and MM continues (i.e. Ignores the problem and continues ripping this track). Then, in the end, this dialog is shown listing all failed tracks, including the # of read errors.

rusty 2008-09-09 18:58 administrator ~0014556	Sounds good.

Ludek 2008-09-16 13:54 developer ~0014590 Last edited: 2008-09-16 20:01	I have taken a joint of the both approaches. i.e. First time an error appear then this dialog is shown with indicating a time to close this dialog (10 seconds) - if the user didn't click cancel within the 10 seconds then the [Continue] button is automatically selected and the rip process continues: ------------------------------------------- Error ------------------------------------------------------ There was a problem ripping the following Track(s): \|---------------------------------------------------- \| Problem______________________ \| Errors \| Error ripping track D:\Track01.cda \| 1 \| \| \| \| \|----------------------------------------------------- Remaining time 8 seconds______[[Continue]] [Cancel] -------------------------------------------- ...and the dialog is shown at the end of the whole rip process again in order to show whole log, but only one [OK] button is there instead of the two buttons ([Cancel], [Continue]) and the timer is also off. In addition there is the "Retry" column. i.e. The log is waiting for a user interaction: ------------------------------------------- Error ------------------------------------------------------ There was a problem ripping the following Track(s): \|---------------------------------------------------- \| [ ] Retry \| Problem______________________ \| Errors \| [ ] ____ \| Error ripping track D:\Track01.cda \| 5 \| [x] ____ \| Error ripping track D:\Track08.cda \| 2 \| \| \| \|----------------------------------------------------- ___________________________________[[Ok]] -------------------------------------------- I think that such a approach should satisfy most of user needs in this "error handling" area. Try to review in build 1186.

rusty 2008-11-20 21:37 administrator ~0015036	Verified 1193.