View Issue Details

IDProjectCategoryView StatusLast Update
0006996MMW v4Synchronizationpublic2011-09-17 22:58
Reporterstephen_plattAssigned To 
PriorityurgentSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Product Version4.0 
Target Version4.0Fixed in Version4.0 
Summary0006996: Allow to reserve / limit sync space on portable devices
DescriptionUsers should be allowed to specify X number of MB to leave free on their device after sync. Sometimes extra space is needed for picture-taking, apps, etc.
Additional Informationhttp://www.mediamonkey.com/forum/viewtopic.php?f=4&t=8017
TagsNo tags attached.
Attached Files
Fixed in build1380

Activities

rusty

2011-01-20 21:22

administrator   ~0022505

As pointed out by users, this would solve a major problem for transcoding from lossless. A small UI change could be:

[ ] Sync random subset of selected files up to device capacity
-->
[ ] Sync random subset of selected files up to ___ ( ) MB (o) GB

jiri

2011-01-25 13:24

administrator   ~0022613

Last edited: 2011-01-25 13:25

Ludek, please implement as suggested. I'd just leave out that MB vs GB selection in order to make it easier, I suppose that MB should be enough? Also I'd use opposite wording (since the free space is more useful info) as
[ ] Sync random subset of selected files and leave ____ MB free.

or
[ ] Sync random subset of selected files up to device capacity
  [ ] Leave at least ____ MB free.

Btw, after some source code review, it seems to me that we don't have the feature implemented correctly - we make a random selection of all the files that are about to be synchronized. However, we should sync all the Videos, Podcasts, etc. selected for syncing and only make a random selection of the remaining tracks (Music, Music Video, etc.). So, here's the whole algorithm:

1. Prepare all tracks to by synced.
2. Calculate size of all files of Podcast, Audiobook, Video and TV types => (A)
3. Calculate empty space to be used as: Total device size (T) - (A) - reserve (R) = (E)
4. Make a random selection of tracks (Music, Classical, Music Video) to be synced up to the size of (E).

jiri

2011-01-25 13:24

administrator   ~0022614

Reminder sent to: rusty

Rusty, please review wording.

rusty

2011-01-25 19:29

administrator   ~0022624

How about:

[ ] Sync random subset of selected files up to device capacity
    [ ] Reserve _512_ MB of free space.

Note: in the future there's a good chance that we'll want to be able to set limits for Music, and Pictures, so it may be preferable to use wording that sets limits on the sync of a particular file type (vs. reserving free space).

Ludek

2011-02-10 13:25

developer   ~0023000

Fixed in build 1349.

lowlander

2011-02-16 19:56

developer   ~0023174

When reserving free space the To Sync size isn't updated to reflect this reserved space. It still shows the to sync size as if no free space is reserved.

Ludek

2011-02-17 13:45

developer   ~0023216

Fixed in build 1350.

lowlander

2011-02-22 00:48

developer   ~0023281

Verified in 1350.

rusty

2011-04-08 18:08

administrator   ~0024138

Re-opening, as a user did detailed testing of this and found numerous issues. See attached document.

Ludek

2011-04-11 23:48

developer   ~0024243

Last edited: 2011-04-13 13:51

Transferred from the attached document:

Using Build 1355
Device attached through the d_USBMass1.dll (Device is a mapped SMB share)
AutoSync set to not delete contents before sync

1.If you clear the value (in entry box not check box) it throws an error.

2.If you enter any non-numeric character (not 0-9) it throws an error.
 
3.Any number > the actual free space when the drive was scanned gets treated as the actual free space. (Sample below had 1000mg free)

4.When you change the values the “Apply” button does not activate (you have to uncheck/recheck one of the options to get it to activate. If you leave the screen without hitting “Apply” the value is not saved.

5.If the number is greater than the current available space on the device the entire device is filled.
a.Device was synced to reserve 950mb
b.Worked correctly.
c.Changed to not keep 960mb available (note unchecked/checked to allow “Apply”.
d.Even though the drive has less than the amount reserved available it creates a list and starts to fill the drive. See below that 771 files are queued to be sent. The same thing happens if a file was created by the device after the initial scan (fills the whole drive)

6.The capacity gauge seems to not reflect the settings/values correctly.
a.If the Capacity is 14.7GB how is 47.7GB shown as a small portion of the drive.
b.In the case above the 13.4GB listed as other are actually the Audio files that MM synced to the drive.
c.The reserved space seems to be listed as the “Free” space. If you change the reserved the “Free” changes in the gauge.

Ludek

2011-04-13 13:52

developer   ~0024292

Fixed in build 1364.

lowlander

2011-04-29 21:47

developer   ~0024594

1) fixed

2) fixed

3 & 6) Capacity gauge now only shows current state, preferably it would show before & after (in Playlist sync)

6a) Gauge still shows current, but Audio shows 462GB for a 2GB device when Music Collection is set to be synced)

7) Free space settings not available for Playlists, Video, TV Shows, Audiobooks and Podcast. Reserve free space should be global in my opinion.

8) Enter large number resets to 0, should instead disable entering more numbers

9) After sync the Capacity Gauge updates, but Summary tab stats don't. But for some reason it shows most content as Other, which it doesn't on reload of Device node.

10) After sync Playlists, Now Playing, Classical Music (not Music though) nodes keep showing Device Profile in Tracklisting instead of corresponding tracks. Switching to other portable device in tree fixes this.

11) Removing old content leaves folders with cover art if cover art was synced as image file.

stephen_platt

2011-05-16 00:02

developer   ~0025284

is there a reason that the reserved space and random subset options are hidden when Playlist node is selected?

rusty

2011-05-16 05:24

administrator   ~0025313

3/6) Showing before/after is a nice idea, but probably as a feature request for a future version.

6a) I think that it's correct to show the amount that the user selected to sync. Perhaps it would be worthwhile to highlight in Red any values for which not all selected content will be synced (and maybe show a tooltip in the future).

7) The reason it isn't global is because it's difficult to cut a playlist without affecting it's integrity (e.g. if tracks for a Party playlist are removed at random, the playlist is no longer the playlist it was intended to be). If needed, we can review this in the future.

8-9) to fix

10) I don't quite understand, but sounds like a new bug
11) Please enter new bug with a bit more detail

Stephen, see my comment re. item 7)

lowlander

2011-05-16 16:33

developer   ~0025339

Last edited: 2011-05-16 16:35

7) This is a very important feature to have. I see no issue as Playlists already get cut when they're bigger than device capacity. Merely reducing the available sync space doesn't change this.
10) No longer present in 1375
11) Added here: http://www.ventismedia.com/mantis/view.php?id=7824

Ludek

2011-05-24 08:53

developer   ~0025604

Last edited: 2011-05-24 08:56

Issues 8-9 fixed in build 1379.

Re 7): I agree with Rusty that it is difficult to cut a playlist without affecting it's integrity and there are some others problems. For example an auto-playlist can have random sort order which would result in reordering device tracks on every sync (some tracks would be deleted and some would be added) which would look strange too. Also for some devices we are syncing playlists (in m3u form or to iPod database) and we would need to remove the dead-links in such a case. Nevertheless there is a workaround for gold-users: They can create new collection and define its rules to include rule 'Playlist is' and tick all the desired playlists.

On the other hands I agree with Martin that current implementation is a bit strange, because user can define amout of MBs to reserve for each non-sequential collection and the resulted amount of space to reserve is sum of the amounts for the individual collections. So I think that a global option would be more logical.

The question is where to put the global option and whether the target version should be 4.0 ?

jiri

2011-05-24 09:52

administrator   ~0025607

7) I would keep this option under [] Sync random subset (i.e. only for applicable collections), since it makes most sense there and without this option its implementation would be a little questionable (decision what to sync and what to leave out).

That said, I think that the current implementation has a flaw: it doesn't make any sense to reserve some space under Music Collection and another space under Classical Music Collection. I'd say that that status of the check box and the value of MB to reserve must be shared among all applicable Collections.

Discussed with Ludek over IM, leaving to Rusty to confirm.

rusty

2011-05-24 16:22

administrator   ~0025619

Last edited: 2011-05-24 19:49

Confirmed. 'Sync random subset...', 'Sync higher rated tracks more often', should be Collection-specific, while 'Reserve xMB free space' should be common to all of the Collections to which 'Sync random subset' applies.

And it only only applies _after_ playlists and podcasts have been synced.

[Edited by rusty]

Ludek

2011-05-25 10:38

developer   ~0025635

Fixed in build 1380.

lowlander

2011-05-30 18:59

developer   ~0025773

I see no problem with reserving free space with AutoPlaylists. The "problems" Ludek mentions already exist when the user syncs a random AutoPlaylist that is larger than device capacity. It means that on each sync a different subset is synced (and this is very desirable). Adding reserved space would still have things working the same way as it currently does.
In my opinion reserved space should be a global device option and all it does is reducing the device capacity. The effect would be the same as syncing to smaller capacity device. This is a much cleaner solution than forcing the user to recreate AutoPlaylists and/or Collections per device capacity to be able to leave free space on the device.
It makes no sense to me that it isn't global. If I wanted to reserve free space on a device (for documents or other stuff) I would always want that amount of free space reserved and not have to fiddle with playlists to make sure it remains reserved.

peke

2011-09-17 22:58

developer   ~0027796

Verified 1433