View Issue Details

IDProjectCategoryView StatusLast Update
0004651MMW v4Now Playingpublic2008-05-09 16:38
Reporterrusty Assigned To 
PriorityurgentSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version3.0 
Fixed in Version3.0 
Summary0004651: Playback behavior isn't consistent between NP and Other Nodes
DescriptionIf Playback is paused:
-Double click in any node --> resume playback
-Double click in NP --> nothing happens

If Track is playing:
-Double click in any node --> restart track
-Double click in NP --> nothing happens

Kind of annoying--I've noticed this as well, but never realized that it was inconsistent between nodes.
Additional InformationRaised by Bex at:
http://www.mediamonkey.com/forum/viewtopic.php?t=25828
TagsNo tags attached.
Fixed in build1169

Activities

petr

2008-05-08 17:37

developer   ~0013907

Fixed in 1168

Ludek

2008-05-09 00:52

developer   ~0013922

Last edited: 2008-05-09 00:55

I have just found a kind of regression:

If user set up Double-click action to Play Last then this action is applied also in the dockable NP window and playback cannot be started, as I remember from MM 2.5 we wanted so that Double-click action would not be applied in case of the dockable NP. Do you remember, Rusty? This was ok in previous builds, but is not in 1168.

Btw. Something similar is mentioned here:
http://www.mediamonkey.com/forum/viewtopic.php?t=25828
by Teknojnky, he would prefer another behaviour.

Assigned to Rusty for revision.

rusty

2008-05-09 02:03

administrator   ~0013923

Last edited: 2008-05-09 03:09

So the implementation prior to build 1168 is:

1) Tracklist:
a) -Adheres to Default Double-click Rules (Play Now, Play next, Play last, Edit)
b) -Adhere to 'Play Now' rules

2) Now Playing Node:
a) -Adheres to Default Double-click Rules (Play Now, Play next, Play last, Edit)--e.g. it is possible to double-click a track to add it to the end of the list, although it's debatable as to whether this is desirable.
b) -Doesn't Adhere to 'Play Now' rules--it triggers playback of whatever track is clicked without changing the NP list EXCEPT when a track is paused or when the currently playing track is double-clicked, in which case nothing happens.

3) Now Playing Window:
a) -Doesn't adhere to Default Double-click Rules
b) -Doesn't adhere to 'Play Now' rules
It always starts playback of whatever track is double-clicked without changing the NP list EXCEPT when a track is paused or when the currently playing track is double-clicked, in which case nothing happens.

4) Party Mode:
It could work similarly, but it's a little more complicated due to the option to: Disable Player controls and Track reordering, and a suboption to enable Play/Pause. I would suggest discussing with Ludek, but if I remember correctly, the gotchas are:
-If Player Controls/Track Re-ordering are disabled Double clicking to play a track in NP should work _initially_ (i.e. only if MM isn't playing).
-If the Play/Pause override is enabled, then Double-clicking in the NP node/window should unpause a paused track, but not restart a track that's playing.

--------------------

The intended change with this bug was to eliminate the EXCEPTION in case 2b) and 3) but nothing else. In other words:
-if the track wasn't playing, MM should start playing it
-if it was paused, MM should resume playing
-if MM was already playing it, it should start playing from the begining (i.e. Ludek correctly pointed out a bug that 3a was changed to adhere to the Default Double-click rules when it shouldn't).

Teknojnky added another point in his comment that he would prefer that the Now Playing node should be made to work exactly like the Now Playing Window (3). This might make sense, but it's probably too risky at this point.

The approach we take ultimately depends on the level of risk. My hope is that we can at least fix the issue that Ludek raised, and defer Tekno's suggestion and related Party Mode changes to 3.1. But if even that is too high risk, we can just undo the changes made to-date.

petr

2008-05-09 12:50

developer   ~0013930

Will be in 1169.

rusty

2008-05-09 16:38

administrator   ~0013936

Verified 1169.