View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004408 | MMW v4 | DB/FileMonitor | public | 2008-02-19 14:29 | 2008-12-03 23:04 |
| Reporter | jiri | Assigned To | |||
| Priority | immediate | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.0 | ||||
| Fixed in Version | 3.1 | ||||
| Summary | 0004408: Improve Album Art scanning (only add art if all tracks in a dir have similar Album fields) | ||||
| Description | Currently there are some requirements for tracks in order to assign album art to them during folder scan. For example they are required to be from the same album. While this is quite a logical requirement, it causes that album art isn't often assigned to tracks and users see this as a bug. We should try to somehow relax the conditions, for example if there is folder.jpg file present in a folder, it should be _always_ assigned to tracks in that folder. | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1191 | ||||
|
|
Fixed in build 1141. - I made several improvements, mainly 'folder.jpg' is always assigned as album art, but there are other minor tweaks in order to scan album art in as user friendly way as possible. - It's covered by regression testing now. |
|
|
Verified 1142 |
|
|
Are you sure that this is better? Now I have all sorts of albums that have _incorrect_ album art, rather than missing album art. So now instead of just having to add art, I need to delete and add art. |
|
|
Well, it depends on how the folder where an incorrect album art was assigned looks like. To explain the algorithms: Original: MM accepted only images in folder where only tracks from one album were present (i.e. it depended on how well tags were filled in, e.g. one typo in one track caused AA to not be imported). New: There is almost no limitation, images in folder are generally assigned to tracks. Certainly there is some sorting made, so that folder.jpg is preferred over other images. We can certainly try to tweak it, but I'd need to know more details about content of folders that aren't scanned well. Simple directory listing would be fine. |
|
|
e.g. /Downloads/Beatles-She Loves You /Downloads/U2 - Joshua Tree - Desire /Downloads/U2 - Rattle and Hum - All I Want is You /Downloads/folder.jpg /Downloads/.... My understanding is that in this case, folder.jpg will get applied to all of the tracks. Am I misunderstanding? |
|
|
As discussed over IM, we'll wait and see what users prefer more. Until then we can possibly close this. |
|
|
example of a problem this is causing: http://www.mediamonkey.com/support/staff/index.php?_m=tickets&_a=viewticket&ticketid=1225 |
|
|
no_hitter indicated that this issue is causing a lot of confusion. Elevating this to 'immediate'--the previous behaviour seems to have been better. |
|
|
Fixed in build 1191. - I didn't completely revent the code, because we would have the same problems as previously. I rather slightly improved the original algorithm so that now Album Art from files will be automatically linked with tracks from the same folder in case Album field is the same or at least similar for all tracks in the folder. I.e. when albums are: - 'Waterloo', '', Waterloo 2', 'Watrlo' - folder.jpg file will be used - 'Waterloo', 'One', 'Hello' - folder.jpg won't be used |
