View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003085 | MMW v4 | Synchronization | public | 2007-06-02 10:54 | 2007-06-22 15:52 |
| Reporter | jiri | Assigned To | |||
| Priority | urgent | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 3.0 | ||||
| Fixed in Version | 3.0 | ||||
| Summary | 0003085: Tweaks in synchronization of album art (new fatures in MM 3.0) | ||||
| Description | While fixing 0003084, I found some problems/unclear things in the new synchronization code. I have already fixed some small issues, but there are some remaining: 1. In DoAlbumArtManagement() when SaveAAToFolder is set, there is '.png' extension fixed. Shouldn't is be based on extension of album art stored in tag? Or, if fixed, it should be always converted in jpeg (if not already in jpeg). 2. Or even better, in future user could set that album art should be synchronized in a specified format (default jpeg, but png or gif could be selectable). This isn't necessary, but would be a nice feature. 3. When SaveAAToTag is set, again, ConvertToPNG method is always used. As in 1., it should rather be jpeg, but again, as described in 2., it could be user selectable. 4. I haven't tried it, but I suspect that it doesn't work well with autoconversion, does it? The workflow should be then: A. MM converts track to a temporary folder. B. AA management adds/removes AA as necessary directly in the temporary folder. C. Track is normally synchronized. | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1042 | ||||
|
|
4) is fixed in build 1040. |
|
|
Also 1) and 3) is fixed in build 1040, i.e. AA is always converted to JPEG for now. |
|
|
Perhaps I'm misunderstanding what is supposed to happen, but I performed the following test with 1041 and here's the result: 1) associate folder.png with an album of OGG files 2) include the OGG files in the autosync profile to an MTP device, and configure the sync profile to save all album art to track folders (as 'folder.jpg'). 3) sync the files -->they autoconvert to the MP3 device -->folder1.png is copied to the device! Shouldn't folder.jpg have ended up on the device? |
|
|
Thank you Rusty! I forgot for this case. I had fixed tag->folder, folder->tag, but I forgot for folder->folder. Thank you, it is fixed in build 1042. |
|
|
Tested 1044 and it seems that there's some sort of regression. a) Linked xxx.png to mp3 track . iPod: synch without any options checked off: OK . iPod: browse device: FAILED -- cannot see AA from MM . mtp: synch option to include art in folder: OK . mtp: synch option to tag: OK b) Tagged png on MP3 track . iPod: synch without any options checked off: OK . iPod: browse device: OK . mtp: synch option to include art in folder: OK . mtp: synch option to tag: OK Everything seems to work correctly, except: a) browsing the iPod doesn't work as expected b) I wonder why the conversion is implemented only for tracks being synced. i.e. why not do this for any track when the artwork is being added to the library? Requesting feedback of Jiri, since I don't expect that these issues are directly related to what Ludek fixed. |
|
|
a) It can't be fixed, at least until we store links to external files to mp3 tags (which we possibly eventually will). b) Certainly we could add a special option to convert tracks to jpeg on adding to Library, but it doen't fully solve the problem of synchronization for various reasons (the option would be turned off by many users, ...) |
|
|
Closing (and opening lower priority bugs to track the remaining issues). |
