View Issue Details

IDProjectCategoryView StatusLast Update
0020223MMW 5Main Panelpublic2024-03-25 12:48
ReporterLudek Assigned To 
PriorityurgentSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version5.1 
Target Version5.1Fixed in Version5.1 
Summary0020223: Intensive artwork searching in Album grid can result in heap overflow
DescriptionMediaMonkey Exception Log - v.ID: 46B40000 v.5.1.0.2814
[Ticket # 6257]

In the log V8 there javascript OOM (Reached heap limit) as there are many initiated artwork image searches at once.
URLs like https://www.gstatic.com/_/mss/boq-search/_/js/k=boq-search.VisualFronten....

We should rate limit images being downloaded at once
Additional Informationhttps://www.mediamonkey.com/forum/viewtopic.php?t=105524
TagsNo tags attached.
Fixed in build2830

Relationships

related to 0020536 closedLudek MM crashes in some specific views 

Activities

michal

2023-09-09 15:56

developer   ~0072751

We already queue image search requests, they are made one by one, in the log we can see, that one file is downloaded and next search began.
All the links including gstatic.com are part of Google image search result page (one such page is created by many sub-scripts). I am afraid the problem could be in Google scripts we cannot affect.

michal

2023-09-09 16:20

developer   ~0072752

But I found a possible problem, if this queue is too long, it can probably cause this error after some time. Will rework the handling.

michal

2023-09-10 09:49

developer   ~0072753

Fixed in build 2815.

peke

2023-09-19 09:58

developer   ~0072814

Verified 2815

Tested like user on 3k+ Artist images search.

peke

2023-12-31 00:18

developer   ~0073974

Reopen It happens again after MM use for few days.

https://www.mediamonkey.com/forum/viewtopic.php?t=105524

michal

2024-01-03 10:46

developer   ~0073986

Last edited: 2024-01-03 10:46

Even though the ID is the same, the crash seems to be completely different (no heap overflow), the cause will be elsewhere, seems to be some different problem unrelated to this issue.

michal

2024-01-03 13:15

developer   ~0073987

It seems the crash happened inside Chromium during opening Google page with results, currently no idea what could cause this.

michal

2024-01-04 14:28

developer   ~0073989

Found the cause, it could happen in case downloading of artworks failed many times.

peke

2024-03-25 12:48

developer   ~0074785

Verified 3007

Unable to replicate

TEST NOTE: Used manual unplug of LAN cable (50-100 fails) during download to simulate fail download.