View Issue Details

IDProjectCategoryView StatusLast Update
0010616MMW v4Properties/Auto-Toolspublic2013-09-24 22:53
Reporterrusty Assigned To 
PriorityurgentSeverityfeatureReproducibilityalways
Status closedResolutionfixed 
Product Version4.1 
Target Version4.1Fixed in Version4.1 
Summary0010616: Lyrics lookup
DescriptionFor MediaMonkey 4.1, we should consider adding lyrics lookup functionality as in MMA/MM8. This should minimally consist of auto-lookup via the Properties dialog, and auto-lookup via the auto-tag dialog. Suggested implementations are:

1) [Lookup lyrics] button in the Properties dialog that allows the user to edit track properties individually. It could use the same icon as auto-tag from Web, and it could appear to the right of the 'Track lyrics' panel.

Pressing the button would cause the Lyrics panel to be overwritten with lyrics that are looked up. In the event that the lyrics are inaccurate, the user can either press the button again to look up from a different source, or press 'Cancel' in order to not save the change.

2) Lookup function in the AutoTag from Web function. It also makes sense to add lyrics lookup to this tool because lookup functionality should be unified. This would require some modification to the tool so that it can apply different attributes to different tracks (i.e. Lyrics 1 for Track 1, Lyrics 2 for track 2, etc..).

The simplest approach would be to add per-track Lyrics to the bottom of the 'web' box (i.e. the 'Select which fields to use' box e.g.
[ ] Comments: <Comments>
[ ] Lyrics:
<#> <Title>
<Lyrics>

<#> <Title>
<Lyrics>
...
...
...

'The Select which files to update:' area can be left as is (it would be nice to allow the user to edit lyrics in place, but I don't think that's possible unless we completely change the layout of this dialog to something like:
Select which files to update:
[ ] . . . Current . . . . . . . Proposed
[ ] Filename: <Filename>
 . . Track: <Track> . . . . . . . <Track>
 . . Title: <Title> . . . . . . <Title new>
 . . Artist: <Artist> . . . . . <Artist new>
 . . Album: <Album> . . . . . . <Album new>
 . . Album Artist: <Alb Artist> . <Album Artist>
 . . Genre: <Genre> . . . . . . . <Genre>
 . . Date: <Date> . . . . . . . . <Date>
 . . Lyrics: <Lyrics> . . . . . . <Lyrics>
 [ ] Filename: <Filename>
 . . Track: <Track> . . . . . . . <Track>
 . . Title: <Title> . . . . . . <Title new>
 . . Artist: <Artist> . . . . . <Artist new>
 . . Album: <Album> . . . . . . <Album new>
 . . Album Artist: <Alb Artist> . <Album Artist>
 . . Genre: <Genre> . . . . . . . <Genre>
 . . Date: <Date> . . . . . . . . <Date>
 . . Lyrics: <Lyrics> . . . . . . <Lyrics>
 ...
 ...
 ...
 
Note: this set of functionality isn't that useful for editing track properties during playback unless we add a mode to the Properties panel that advances the panel in sync with playback whenever edits haven't been made; nor is it useful for editing tracks en masse (i.e. lookups of lyrics for tracks spanning multiple albums). These features can be considered in the future.

TagsNo tags attached.
Attached Files
Skins.jpg (107,387 bytes)   
Skins.jpg (107,387 bytes)   
lyrics_lookup_malformatted.jpg (132,655 bytes)   
lyrics_lookup_malformatted.jpg (132,655 bytes)   
Fixed in build1660

Relationships

related to 0000085 assignedjiri MMW v4 Searching for Tag info doesn't yield expected results 
related to 0001656 feedbackrusty MMW v4 Basic Auto-tagging functionality via Album Browser (Amazon window) 
related to 0010558 closedmartin MMA Lyrics search 
related to 0010350 closedLudek MMW v4 JScripts are not executed correctly 
related to 0010736 closedLudek MMW v4 Lyrics UI handling improvements 
related to 0010755 closedLudek MMW v4 Art and Details panel should be editable 
related to 0010792 closedpeke MMW v4 AA and Details: Layout still have artifacts 
parent of 0010801 closedLudek MMW v4 Art & Details Artwork covered by Fields, shows greyed out (regression) 
has duplicate 0000692 new MMW v4 Add Lyrics Lookup (like Evil Lyrics) to MM 
related to 0010914 closedLudek MMW v4 Add automatic artwork lookup 
related to 0011090 newLudek MMW v4 Album Art Search Missing from Art and Details 

Activities

Ludek

2013-03-19 14:31

developer   ~0035426

Re: 2)
What about just to add simple
[x] Lyrics
checkbox to the web panel.

And leave lyrics listed in the file listing as is (similar like the current attributes), but editing (e.g. F2 hit) would open new modal window to edit the lyrics?


3) We should also consider adding automatic lyrics lookup on the background (similar to Lyricator script)

gege

2013-03-19 15:22

reporter   ~0035427

As the author of Lyrics Viewer add-on, I welcome this feature. Here are my two (in fact three) cents:

1) It would be great to have both approaches: batch lookup AND individual song lookup;

2) Regardless the approach taken, users should be able to easily EDIT lyrics before actually saving to tag;

3) It would be nice if individual lookup could be invoked by scripts. Shameless selfish use case: Lyrics Viewer could automatically show a 'Lookup Lyrics' button for songs without lyrics.

rusty

2013-03-19 15:39

administrator   ~0035428

2) The reason I didn't add a global [x] Lyrics checkbox (that applies to all tracks) is for cases where the user won't want to include lyrics for a particular track because they're not a good/correct match. But perhaps that case can be dealt with via a combination of:
a) the fact that the user can choose to disable metadata for a particular track
b) the fact that the user can edit the metadata (or delete the metadata for a particular track)

So I think your recommendation makes sense. We should just be careful to somehow present the editable Lyrics metadata in the grid in a manner that looks ok.

3) We had discussed using an approach similar to that used in MMA/MM8 (in which lyrics can be automatically looked up during playback / optionally automatically saved to tags at that time.

The reason why I didn't include it in the bug is because currently MM's properties dialog doesn't have a means of keeping in sync with the currently playing track (or the associated logic that would be required to handle cases where the user is editing properties of a track when the Properties dialog is locked to the Now Playing track--see 0001432).

But perhaps that's complicating things too much. Maybe a much simpler approach would be to how the Properties editor behave as it does today, but allow automated lookups to appear only in the Art & Details window. e.g. Art & Details could show 'Lyrics', and if they're missing, automatically look them up, but don't save them. Once they appear, the user could either a) automatically save them or b) manually save them (e.g. a button to 'Save updates') depending upon configuration.

Ludek

2013-03-26 16:45

developer   ~0035488

Last edited: 2013-03-27 09:40

- Item 1)
is implemented in build 1630.

- Item 2)
There are some problems that we needs to take into account:
a) For non-popular albums the lyrics lookup can take minutes. If the lyrics cannot be found on one source server then it continues searching on the others servers. For album with 16 tracks it can be:
6 servers mult. by 16 tracks = 96 HTTP requests (usually takes more than one minute).

Thus clicking [x] Lyrics checkbox in the web panel wouldn't show anything until the lyrics search is finished.
Therefore it could be reasonable to add [Search Lyrics] button next to the [Undo] button and the lyrics lookup would run on background (for selected tracks only?) - continually updating the results/progress in the file listing panel.

b) if user changes the album in the selection box above then lyrics search needs to be restarted, because [artist, title] could be changed by this operation.

- Item 3)
I guess we would need to change layout of the "Art & Details" window. So that instead of current [Now Playing] and [Selected] tabs we could rather show [Artwork] and [Details] tabs. Where on the [Details] tab we would show current details (Title, Artist, Ablum, Track) + Lyrics box.

- Item 4)
I think that kind of batch lookup (like Lyricator) should be taken into account.
Maybe just checkbox
[ ] Automatically lookup missing lyrics on background
that would run background thread (like in case of Volume Analyze or background Auto-organize)

Ludek

2013-04-05 12:06

developer   ~0035540

Last edited: 2013-04-05 12:06

Re: Gege's suggestion "It would be nice if individual lookup could be invoked by scripts"

yes it can, because the lookup function is part of JS script, all is just about calling function SearchLyrics( Artist, Title) from file /Scripts/lyricsSearch.js
If it is called again, the function returns lyrics from another source (if exists) otherwise returns the same lyrics (if only one source server includes the lyrics)

Ludek

2013-04-11 18:30

developer   ~0035608

Last edited: 2013-04-12 16:47

All items have been discussed offline in a greater details (with Rusty and Jiri).

Items 1,2,3 are implemented in build 1631.

Re 2) '[x] Lyrics' checkbox was added to the web panel (for consistency)

Re 3) Lyrics panel was added to "Art & Details" window and these new configs were added to the Options -> Library panel:

[ ] Search for missing lyrics automatically
    [ ] Save missing lyrics automatically


Item 4 is postponed to the next version when we want to introduce general metadata batch lookup (not just lyrics).

rusty

2013-04-16 03:53

administrator   ~0035635

Last edited: 2013-04-16 13:31

I tested build 1631, and would suggest some basic changes to improve the look and feel + accessibility. Specific issues are:
a) the text background doesn't mesh nicely with the UI
b) the lyrics text color/font doesn't mesh with the UI
c) the titbar doesn't mesh with the UI
d) the margin of the scrollbar isn't aligned with that of the Now Playnig list above

I would suggest that:
i) If it appears in conjunction with track metadata, then the text font and background should match that of the Art&Details.
ii) At the same time, I think that it might be preferable to allow the user to toggle between different Art&Detail information just by double-clicking it.
e.g. state a: show Artwork and basic metadata
 state b: show lyrics
This would mean that double-clicking the Artwork/Lyrics would no longer serve to Pause/Play, but I think that switching views would be more useful. Definetly worth beta testing though...

Edit: note that for videos, double-click should continue to work as it does today (i.e. change between A&D video and Full Window video).

iii) the titlebar shouldn't be used by default
iv) The scrollbar should be fixed so that it's the same as the NP scrollbar

Ludek

2013-04-16 12:08

developer   ~0035642

Assigned to Petr,
per IM discussion with Jiri/Petr the Lyrics should be displayed similarly like in MMA (overlay the cover image)

petr

2013-04-16 21:27

developer   ~0035649

Lyrics overlay implemented

Ludek

2013-04-17 20:09

developer   ~0035653

Fixed in build 1632.

Also properties are overlayed now.

rusty

2013-04-19 04:47

administrator   ~0035680

The overlay is a good idea, but there are some usability problems with the implementation:

a) The overlay doesn't look great when lyrics aren't available. This can be easily fixed by having it cover the entire A&D panel
b) the text on the overlay isn't visible esp. on dark skins. This can be fixed by having the text and perhaps the color of the overlay configurable.
c) There's no way of looking up medatada from the overlay. This can be fixed by having a button e.g. in the upper right corner of the overlay.
d) There's no way to easily switch between AA and overlay (afaik). This can be switched by having it toggle via double-click (only for audio files)

Ludek

2013-04-19 09:28

developer   ~0035683

Last edited: 2013-04-19 16:30

Re: a) & b)
IMHO it looks great, see the attached screenshot (tested Eclipse and ND3_red dark skins), you problably just tested a dark skin that hasn't the prop. text color configured?

Re: c) Which text the button should include? "Search" ? I am afaid that it wouldn't be obvious that only lyrics will be looked up, I would pobably just let the automatic lyrics lookup in MMW. Manual lookup can be performed via properties, i.e. if user double-click the cover properties.

d) This can be done via context menu (both '[x] Image' and '[x] Show file details' can be disabled).
Or you can make the A&D window higher and the props will be above the artwork.

We also discussed with Jiri that:
- if window is higher, the AA should be at the bottom margin and props above
- if window is wide enough, the AA should be on the right and props on the left
(this has been implemented, will be in the next build - 1633)

e) Shouldn't be the Options -> Library -> [x] Search for missing lyrics automatically' a gold feature like in MMA/MM8? If yes, which text the gold prompt should contain?

f) I guess that '[x] Show Lyrics' checkbox in the context menu should be moved to 'Choose fields' in the context menu. But I am not 100% sure, because it will be quite hidden there. Especially because lyrics should be the last checkbox there (therefore hidden :-( )

rusty

2013-04-19 16:35

administrator   ~0035687

a) I disagree--I think that the overlay looks strange when it covers part of the artwork. I think that it would look a lot cleaner if it covered the entire image, rather than just used the space required by the text (i.e. the overlay should be fully active or not, but not half active)

b) ok

c) ok. I wish it could work similarly to MMA/MM8, but I see why this might not make sense with the current UI if other metadata isn't editable as well. As a long term direction, I'd love to see all visible properties be editable within A&D. Added at 0010755

d) I find that in MMA, it's so convenient to be able to quickly switch between views by swiping. The context menu isn't quite as trivial an action, which is why I was thinking that a double-click to the A&D window would be a nice way of toggling between Overlay/Non-overlay modes (and the 'Show lyrics' config can be eliminated--it would just be another field in the field chooser).

And to edit properties, a single click can be used. Note: Ideally if the user clicks a particular field, then the Properties dialog should open with that field highlighted.

e) Yes--Here's some text:
New:"For automated lookup functionality, please upgrade to MediaMonkey Gold!"
Existing:"To upgrade or to learn more about MediaMonkey Gold, click the 'Upgrade' button."
Existing"[Upgrade] [OK]"

f) Assuming we don't take the approach suggest in d), then Yes, 'Show lyrics' and 'Choose fields' should be near each other. Note that 'Show details' should also be proximal e.g.

Edit Artwork Properties
Add Image
Paste
Remove Image
-----------------
[x] Image X: Cover
-----------------
View >
> [ ] Show Titlebar (move window)
> [x] Show File details
> [x] Show Lyrics
> [x] Lock aspect ratio
> Choose fields
> ___________________
...

Ludek

2013-04-19 19:45

developer   ~0035690

Last edited: 2013-04-19 19:53

Fixed issues a,e,f + other tweaks in build 1633.

Only d) remains to add, but I am not sure about this, double-click is mostly used for opening something, not for switching.
Maybe single click would fit better for switching between the layers? But it could probably look strange too.

jiri

2013-04-20 17:04

administrator   ~0035698

d) I think that it could work as:
 - one click - turn metadata overlay on/off
 - double click - edit Properties (preferably with the correct sheet shown, like Lyrics sheet when Lyrics is double-clicked).

f) I would rather move Lyrics to Choose fields dialog as previously suggested. I don't think that it's a big deal that it's hidden there, particularly if we make it enabled by default.

g) We currently don't show anything when Lyrics is enabled, but missing. I.e., user without any lyrics in library doesn't even know about this feature and about the lyrics look-up in general. I think that same text like 'Lyrics missing. Search?' should be shown. Clicking it would start lyrics look-up.

jiri

2013-04-20 17:11

administrator   ~0035699

h) The overlaid text is often hard to read - in most skins it's black and so it's hard to read when AA has black parts. I think that it should work as in MMA, i.e. to make the background a little darker and always use a white font (regardless the skin used).

Ludek

2013-04-22 11:22

developer   ~0035723

Last edited: 2013-04-22 11:23

Re: h) I think this is not a good idea, it would look terribly on white skins, see this screengrab: http://img10.rajce.idnes.cz/d1001/7/7921/7921002_db0d3f8c81a578cd9641e996e0a3e609/images/Darkbackground.jpg

Could you attach a screenshot when the text is not readable? Isn't it rather a skin issue? I tested several skins and I haven't observed any such issue, the overlay is always in color of the background (defined by the skin). If background and text colors are different enough then this shouldn't be an issue.

jiri

2013-04-22 15:20

administrator   ~0035724

h) Ok, you are right. That said, the contrast isn't great for reading. I wonder, whether making the overlay a little less transparent wouldn't help?

rusty

2013-04-23 19:30

administrator   ~0035736

Last edited: 2013-04-23 21:31

re. d) sounds good (note: in the future we may want the one-click to be a toggle i) no details ii) details iii) lyrics iv) details & lyrics, but we'll see).

f) ok. I'll have a look at the implementation in 1633

g) ok

i) Suggested by frank via e-mail: use a line to visually separate lyrics and other metadata (to help make it look better since lyrics are centered, whereas other metadata isn't).

Ludek

2013-04-24 14:39

developer   ~0035755

Last edited: 2013-04-25 11:10

d, f, g) - Fixed in 1635

h) OK, although I haven't experienced the issue even with black cover I suppose it is either dependednt on skin you used or HW (e.g. LCD panel used), I have made it little less transparent in build 1635.

i) In 1633 I added the 'Lyrics:' line on the left (to be consistent with the others properties), so I guess that the separator is no longer needed.

rusty

2013-05-03 14:36

administrator   ~0035911

c) Currently double-clicking lyrics --> Properties dialog opens. Would it be possible for the properties dialog to open with focus on the Lyrics?

Similarly, if the user double-clicks another field in the overlay, would it be possible for the Properties Editor to open with focus on that field?

d) this is more a comment re. future directions. Single click to change mode works well, however, we may want single clicks of a field to eventually work in the same manner as it does in MM8 (shortcut to find more from same). If we go that route, then we may want to add a [details] toggle button at the upper right portion of the dialog. No change required right now unless we feel an urgent need to implement 'find more from same' now.

g) Lyrics search works nicely, but the functionality should be more discrete. i.e. just show:
Lyrics: Not available. _Search_ ('Search' is underlined. Note also, that this text shouldn't be center-justified--only actual lyrics should appear center-justified)
 
i) The configuration in the Options menu is confusing (my fault). The problem is that the Library sheet in which it appear is prefaced with 'When adding files to the library:', however, automatic search/save of lyrics has nothing to do with adding the files to the library--it occurs when they're played!

Thus, we may want to add a 'Metadata lookup' entry now, even though ATM it would only include:

When playing files:
 [ ] Search for missing lyrics automatically
 . . [ ] Save missing lyrics automatically
 
j) It seems that lyrics are saved even when 'Save missing lyrics automatically' is disabled. How is this supposed to work?

Aside: this works excellently. It would be amazing if it could be applied in similar fashion for Album Art ;-)

Ludek

2013-05-03 17:39

developer   ~0035913

Last edited: 2013-05-03 17:41

Re i)
I think that it would look strange if the 'Metadata lookup' panel in Options would contain only Lyrics options. Especially if we actually supports all metadata lookup via 'Auto-tag from Web'. I would suggest to be consistent with 'Auto-tag from Web' where all the options are part of the dialog. So it would make sense to add the lyrics lookup options directly to the context menu of the A&D window. It would be also much easier to find.

Re j)
Currently lyrics are looked up, but are saved to DB/Tag only when the 'Save missing lyrics automatically' is enabled. But probably you mean that user can manually save them if he edits the track later? So the question is how it should work? Should it look up the lyrics and only present them in A&D panel, but not in Properties->Lyrics so that user couldn't save them manually?

rusty

2013-05-03 19:17

administrator   ~0035914

Re. i) It would look strange, but it really belongs there; Auto-tag from web options are specific to that dialog. Automated metadata lookup is a global function--i.e. lyrics happen to be displayed in the A&D dialog, but they also appear in the properties dialog (even if A&D dialog is hidden).

The only other option I can think of is to keep it in the Library options, but figure out a way of including the header above the 2 options (i.e. either below the entire section of 'when adding files' options, or perhaps to the side):
 
When playing files:
 [ ] Search for missing lyrics automatically
 . . [ ] Save missing lyrics automatically

Re j) My confusion stems from the fact that if automated lookup is enabled, and I play track A, then switch to track B, and then return to play Track A, the lyrics are there (i.e. they seem to have been saved)! If they haven't been saved, then why are they there--are they cached in some way?

Ludek

2013-05-06 21:10

developer   ~0035938

Last edited: 2013-05-06 22:17

Items c) & g) are fixed in build 1637 as suggested.

+ fixed: k) when you select a track with large lyrics in file listing and immediatelly press down arrow to select the next track, the UI freezes for half a second

Re i)
OK, so in this case I would prefer to add the new 'Metadata lookup' entry, because the main 'Library' entry include too many options now. Where the new 'Metadata lookup' entry should be placed? Just below the 'Library' -> 'Search' entry?

BTW. it is saying "When playing files", but currently the lyrics are auto-looked up only when A&D window is visible and user focus a track. Should I enhance it and look the lyrics also when a file is just played even if A&D window is hidden? It doesn't make much sense especially if '[ ] Save missing lyrics automatically' is disabled.

Re j) Yes, they are cached, but are not auto-saved to DB/tag. Is this unexpected? How would you like it to work?

rusty

2013-05-07 15:22

administrator   ~0035964

i) I'd suggest just below Library > 'Tags & Playlists'

j) Yes--it's unexpected because there's no way to distinguish caching from saving to the db. Here's an example of what I mean:

1 configure auto lyric lookup
2 play track a so that lyrics are lookup up
3 play track b
4 right-click on track a and view properties
--> Lyrics appear to have been saved to the DB!
5 close MM and restart
6 view properties for track a
--> Lyrics have disappeared from the DB!

Also, there's another bug:
l) Manually accepting 'cached' lyrics doesn't save them. e.g.

7 right-click on track a and view properties
--> Lyrics appear to have been saved to the DB.
8 click OK on the properties dialog to save the lyrics
9 close MM and restart
10 view properties for track a
--> Lyrics have disappeared from the DB, even though the user apparently saved them!

The problem with both of these issues is that there's no way to represent a cached/unsaved state, however, it's not clear that removing the lyrics from the properties dialog would be a better solution since there'd be no mechanism to manually save the lyrics. In MMA/MM8 this problem is avoided by having a 'Save' button directly on the Lyrics panel.

In MMW, the issues could be resolved by:
a) Continuing to cache content, but displaying cached content in the Properties dialog slightly differently. AND, when the user clicks OK, ensuring that cached content is saved. In terms of displaying cached content 'differently', possible approaches are:
 i) use greyed out text. Downside is that users won't know what it means.
 ii) don't display cached content immediately. Instead, when the user clicks the lyrics tab, flash 'loading search results...' within the Lyrics property for 2 seconds so that it's clear to the user that the content isn't saved in the DB

b) Getting rid of cached content entirely, and only transfer lyrics to the Properties dialog if the user double clicks on lyrics in A&D, which 'pastes' them to the Properties dialog, and save them only when the user clicks 'OK' in the dialog. BUT this isn't a great solution since it would still result in confusion as to whether content has been saved or not.

c) Getting rid of cached content entirely, and only transfer lyrics to the Properties dialog if the user clicks a 'Save' button in the A&D window / context menu. BUT this isn't a great solution because it clutters the window.

I think that a ii) might be the best solution.

Ludek

2013-05-08 13:23

developer   ~0035979

i) You haven't replied this:
BTW. it is saying "When playing files", but currently the lyrics are auto-looked up only when A&D window is visible and user focus a track. Should I enhance it and look the lyrics also when a file is just played even if A&D window is hidden? It doesn't make much sense especially if '[ ] Save missing lyrics automatically' is disabled.
I think that it makes sense to look them up only when A&D window is visible and the file is selected. Then it implies that "When playing files" is inaccurate.

j) what about just to change the leading text on the Lyrics tab (of the Properties dialog) from "Track Lyrics:" -> "Track Lyrics: (unsaved)" ?
This is similar to ii) but more clear

rusty

2013-05-08 14:45

administrator   ~0035983

l) per discussion, there's another problem: If lyrics are cached, and auto-save is disabled, how does the user explicitly accept them? i.e. the Properties dialog is designed so that whenever the user clicks OK, all items are saved. But in the case of cached=unsaved lyrics, if the trigger to save them is clicking 'OK' then they'll be saved even if the user hasn't seen them.

The proposed solution to this is that 'cached' lyrics should only be saved if the user clicks OK in the properties dialog after at some point having viewed them in the lyrics tab.

j) Good idea

i) Given the changes discussed at j) and l), per IM discussion we should just support lyrics lookup anytime they're missing from the active view (i.e. for Playing track in A&D, for selected track in A&D, for selected track in Properties dialog > Lyrics tab). With this change in mind, the header can be:

When viewing lyrics:
 [ ] Search for missing lyrics automatically
 . . [ ] Save missing lyrics automatically

Ludek

2013-05-08 22:44

developer   ~0035993

Fixed in build 1637.

peke

2013-06-21 22:46

developer   ~0036606

Verified 1644

stephen_platt

2013-07-20 15:08

developer   ~0036940

Reopening based on this comment:
http://www.mediamonkey.com/forum/viewtopic.php?f=6&t=72071#p371157

(...if the metadata overlay is off, then the double click action should be that the full sized art is displayed.)

Ludek

2013-07-21 09:53

developer   ~0036943

Sounds good, added in build 1651.

peke

2013-07-23 00:11

developer   ~0036954

Last edited: 2013-07-23 00:51

Reopen, Found Lirics are not saved in either Library nor tags after search from Art & Details

Steps:
1. Play some track from Library
2. Set Art & Details to Now Playing
3. Search Missing Lyrics
4. After Lyrics are found
5. close MMW
6. Open MMW Lyrics are missing

Workaround 1:
7. Repeat Steps 2-4
8. Right Click On Track -> Properties -> Lyrics -> OK
9. File Gets Tagged and Lyrics gets persistant.

Workaround 2:
1. Go To tools -> Options -> Libary -> metadata lookup
2. Enable Search for missing lyrics Automatically
3. Enable Save Missing Lyrics Automatically
4. Disable Search for missing lyrics Automatically (Save Missing Lyrics Automatically is still enabled but Grayed and working)

Solution:
Arrange Metadata Lookup This Way where both Options would be selectable:
When Viewing Lyrics:
___[x] Save Searched Lyrics Automatically
___[ ] Search for missing lyrics Automatically

Ludek

2013-07-23 09:28

developer   ~0036956

Last edited: 2013-07-23 09:30

I like the Peke's solution proposal:

When viewing lyrics:
___[x] Save searched lyrics automatically
___[ ] Search for missing lyrics automatically

I am just not sure about the defaults, maybe both checkboxes should be disabled by default and both should be gold feature? Or probably only the second checkbox (auto-search) should be gold feature?

Rusty, what do you think?

peke

2013-07-23 10:23

developer   ~0036957

I like proposal that both should be disabled by default.

lowlander

2013-09-15 03:42

developer   ~0037534

It would be useful that the Status bar indicates how many files still need lyrics tagging if user has many files in queue.

rusty

2013-09-16 15:47

administrator   ~0037560

Last edited: 2013-09-16 15:51

l) I'm not sure I understand why any change is required to the UI. i.e. the intent of the config option is re. automatic lyrics lookup only.

Manual lookup should presumably always be saved.

m) As far as defaults: sure--we can leave them disabled by default

e) Re. Gold: I think auto-lookup should be gold (and auto-save is by virtue of it being a child). See 0010616:0035687 re. strings.

n) I haven't been testing MMW much, but when I tried out manually clicking the "Lyrics: Not available. Search" text in the A&D window, all that happens is that the window switches to AA only view.

o) I suggest changing the text to the shorter/simpler:
"Lookup lyrics"

Ludek

2013-09-17 13:30

developer   ~0037577

Last edited: 2013-09-17 13:32

All fixed in build 1659 according to 0010616:0037560

Re n) I cannot replicate, for me the _Search_ link has always worked, give a try with the new _Lookup_lyrics_ link in build 1659.

peke

2013-09-18 22:30

developer   ~0037601

Verified 1659

rusty

2013-09-22 18:12

administrator   ~0037634

n) This is still occurring in build 1659 for me. The only effect of clicking 'Lookup lyrics' is that the Artwork window switches between Artwork/Lyrics and Artwork only modes.

Upon further testing, it appears that this is triggered by disabling all fields except Lyrics in the Art&Details window.

p) Upon clicking the AA window, the formatting gets messed up--see attached image. This is dependent on the width of the NP Column, and seems to occur in the same circumstances as item n) i.e. when only the Lyrics field is enabled in A&D window.

Ludek

2013-09-23 10:54

developer   ~0037643

Item n) fixed in build 1660.

Re item p) - this is not a bug, A&D auto-switch to non-overlayed mode whenever there is enough room for this, i.e. if the window is wide enough to show all text properties on the left, then all text properties are shown on the left and artwork on the right.

peke

2013-09-24 22:53

developer   ~0037658

Verified 1660

I also do not find p) as a bug.