View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0017638 | MMW 5 | Other | public | 2021-03-08 00:36 | 2024-06-21 17:48 |
| Reporter | rusty | Assigned To | |||
| Priority | urgent | Severity | feature | Reproducibility | always |
| Status | closed | Resolution | reopened | ||
| Product Version | 5.0 | ||||
| Target Version | 5.1 | Fixed in Version | 5.1 | ||
| Summary | 0017638: Allow non user-initiated traffic to be disabled | ||||
| Description | Users at different times have raised the issue that mm communicates over the network even if the user doesn't use any network-related functionality (UPnP / Wi-Fi Sync / Casting). This is an issue for: - users that are very privacy-conscious - users running MM in a locked-down environment (where network traffic isn't allowed) Wouldn't it make sense that if: - Player > streaming > [ ] Accept input/control of MediaMonkey player via UPnP/DLNA is disabled - Media Sharing > [ ] MediaMonkey Library is disabled - General > [ ] Check for updates (when connected) is disabled ...and if we added: Player > streaming > Play to > [ ] Allow playback to other devices (which would disable any option other than Internal player) ...that MM would never automatically generate traffic nor connect to other devices in the background? | ||||
| Additional Information | https://www.mediamonkey.com/forum/viewtopic.php?f=33&t=98563 | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 3021 | ||||
| related to | 0017644 | closed | Ludek | Crashlog F1FF000 on startup |
| related to | 0019253 | closed | michal | Album art lookup is still executed on album nodes even it is disabled in Options |
| related to | 0019145 | feedback | rusty | Musicbrainz error is displayed when internet access is disabled |
| related to | 0020489 | feedback | rusty | Option to disable online accesses |
| related to | 0021048 | closed | Ludek | YouTube tab shows no results when Info Panel lookup is disabled |
|
|
I think that currently there is still bunch of further related auto-requests, e.g.: 1) Auto-lookup of image in the Artist's browser view (and Artist description from Wikipedia), the same goes fro Albums, Genres in Browser view 2) Auto-lookup of lyrics in the Playing > Lyrics view 3) Servers are auto-looked up on MM5 start to find MMS instances on the network 4) Servers are auto-looked up when accessing 'Devices & Services' and 'Folders' nodes to list available servers => this could be resolved by removing media servers from the Folders node and having an option to remove available servers from 'Devices & Services' node too Note though that all of these adds unnecessary complexity to the configuration that users won't be aware of anyway. Therefore I think that having a single checkbox for whatever network access is a better choice. e.g. something like: [x] Enable offline mode (no network traffic) -- in this mode MM won't access any network and internet resources, futher explanation bla bla.... And when this mode is enabled then it makes sense to: - make the cast button on the player disabled: For easier toubleshooting whenever the user enabled the offline mode - hide the 'Media Servers' and 'Storage & Serives' sections in the 'Devices & Services' view + indicate that the offline mode is enabled - no 'Lookup lyrics' and 'Lookup artwork' links around the UI - trying to initiate Auto-tag would show a dialog that offline mode is enabled and needs to be disabled at first, or just disable Auto-tag action? - remove [Online] tab from Browser views - supress Podcast downloading / disable Podcast update actions, etc. |
|
|
I think an Offline Mode checkbox could be an effective solution. If we do, we'll probably need an additional "offline" icon to display in places such as Album Art Lookup. So in place of the loading icon, there would be an icon indicating that MM is offline, with text like "Offline mode is enabled." |
|
|
1/2) Re. auto-lookup of Artist image/lyrics: shouldn't that be disabled if the user disables background metadata lookup for: [ ] Artist images [ ] Artwork [ ] Lyrics 3) Shouldn't MMS servers only be looked up when the user initiates an MMS lookup via 'Add location'? 4) The main issue isn't that MM connects to the network--it's that MM connects to the network _without the user initiating any such activitity_. In other words, if a user attempts to browse for www content/network location/media servers or play online radio, it is expected that MM will connect to the network. The issue that most users are concerned with is when MM connects without the user enabling the services or initiating the connection. There is a secondary usecase for some to completely disable/prevent network connectivity, but I think that's a lower priority usecase. So from my perspective, the primary requirement is that: - users should be able to disable any services that connect without user-initiated activity (which afaik is limited to Player > streaming > Play to > [ ] Allow playback to other devices ) - any existing config options related to this functionality should work in a manner that matches their wording (i.e. items 1/2 above -- if the UI implies that background lookup is disabled, it should be consistently disabled). The benefits of this approach are that changes would be minimal (afaik, at least), and it would limit UI conflicts (e.g. features shown as enabled in one location but not working due to the 'no-network' mode). |
|
|
1/2) Yes, I think that auto-lookups should be supressed when configured so, but AFAIK there is no option to supress the artist/album info description fetched from Wikipedia? 3) That's a question, currently it is there to auto-detect MMS on network and add this dialog/migraiton wizard: https://www.dropbox.com/s/5r511j8qn6oq4db/Screenshot%202021-03-08%2017.50.10.png?dl=0 But meaybe we could either: a) run the auto-detection only when the 'Devices & Services' node is accessed by the user b) manually via the (+) button next to the 'Storages and Services' ? (requires new strings) I think 3a) might work fine as by accessing 'Devices & Services' the other media servers are looked up anyway (to list them). -------------------------------------------------------------------------- As for the manually initiated activity, what is manually initiated activity: A) is accessing 'Devices & Services' or 'Folders' node manually initiated activity for MM5 to auto-discover media servers on the network ? B) What is point of adding Player > streaming > Play to > [ ] Allow playback to other devices ) ??? I don't see it, because playback to other devices needs to be manually initiated by user anyway, either via the 'Play to' menu or by clicking the Cast icon on the player and select a device, so the checkbox is just redundant IMO |
|
|
1/2) User can disable the Info-panel to prevent lookups 3) I suppose that this is similar to detection of UPnP servers which I'd neglected to mention/discuss. For both the servers are auto-detected and subsequently always display (Devices & Services / Folders). a) I like the idea of running auto-detection when Devices & Services (or Folders) is accessed, as it would be expected that checking for devices and services would check for them. But this won't satisfy users who want to access Devices or Folders without accessing the network. TBD. Re. the question of 'what is manually initiated activity?', the idea is that it's ok for MM to access the network whenever the the user launches an action that would be expected to access the network. A) 'Devices & Services': as described above, accessing 'Services' would be expected to access the network, though there may be users who want to access devices without accessing the network. B) Player > Streaming > Play to > [ ] Allow playback to other devices . You're right--if discovery of other devices only occurs when the user clicks the 'Cast' button, this isn't required (I thought that discovery was ongoing). |
|
|
3a) is fixed in 2321, i.e. servers aren't looked up until 'Devices & Services' node is accessed |
|
|
Setting to 'resolved' to trigger testing. The issue should subsequently be re-opened since only a minor portion has been fixed. |
|
|
Reopened for other fixes 3a) Verified 2321 no traffic is generated till 'Devices & Services' is clicked. |
|
|
Based on Peke's testing, the current status seems to be that the only 'unexpected' lookups that occur are when: 1/2) the user opens a view containing an Info-panel 5a) the user inserts a CD triggering a lookup 5b) the user rips a CD triggering an AccurateRip lookup 6) The other related issue is that users would benefit from greater transparency by making it clearer what connections are being made / what data is being shared. This is already done for Lyrics (for which users can configure sources), but isn't the case for Artist images, Artwork, Related Artists) Possible solutions: 1/2) LL suggested modifying Options > Metadata looup > Background metadata lookup to include new option(s) for View Elements. e.g.: [ ] Artist images [ ] Artwork [ ] Lyrics [ ] Info panel If Info Panel is disabled, then MM would display local content instead of downloading content. i.e. - Downloaded or cached artwork (if Absent in should allow for manual lookups like the Preview Window: Artwork: _lookup_ / Image: _lookup_) - Comment: (editable) {this would be the Artist or Album comment field from MM4, depending on the view) - WikiPedia: _lookup_ 5a) In the Audio CD metadata lookup settings, add an option: None 5b) In the next major release post 5.1, change 'Verify ripped tracks' --> 'Verify ripped tracks online' Please comment/triage Note: if this is too much work/risk for the 5.1 release, I would suggest that we clearly document the above limitations along with what the various connections are to. |
|
|
Fixed in 3015 |
|
|
Verified on 3015, options are implemented and working. Leaving for Peke to do in-depth confirmation of no outgoing traffic. |
|
|
7) On CD insert with CD Lookup set to none it shows looking up CD in Statusbar and CD not found message afterwards, Instead this should be a: A) lookup disabled message (preferred) B) no message, as lookup is disabled by user 8) Manual lookup remains available in Context Menus. This should either: A) Perform the CD lookup, as user initiated it, overriding the setting (seems more consistent) B) Show disabled when CD lookup is set to none |
|
|
7A) How about using the following 3 strings which already exist: Warning: Lookup Audio CD metadata -- Disabled! BUT: I wouldn't show this more than once or once per session since it could get very annoying very fast. 8) I don't think any change is required since this is not a case of an 'unexpected' lookup. |
|
|
7A) fixed in 3021 |
|
|
Verified 7a in build 3021. |
