| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0020351 | MMW 5 | Other | public | 2023-11-10 17:53 | 2024-05-20 18:34 |
| Reporter | zvezdan | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | reopened | ||
| Target Version | 5.1 | Fixed in Version | 5.1 | ||
| Summary | 0020351: Too much empty space on the add-on's installation dialog box | ||||
| Description | There is too much empty space between "You should only install..." text and the Install Now/Cancel buttons. It appears both when the License box is displayed or not. | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 3022 | ||||
|
|
Fixed in 5.1.0.2827 |
|
|
Verified on 2827. |
|
|
Not perfect. It is ok with addons without license or with the narrowly formatted license text, but still has empty space with the wide license text. The screenshot follows... |
|
|
Fixed in 2828 |
|
|
Verified 2828 |
|
|
It seems to me having the same size. It is really not a big deal, but it would be nice if you can make it better. |
|
|
This is the default on the default Material Design skin (which is fine IMO): image.png (78,223 bytes) |
|
|
This is not fine IMO. The screenshot will follow, with the default Material Design skin, just another color theme. By the way, I didn't mention that I am talking about default window size, i.e. what you get immediately after dropping the add-on on the player, without any manual resizing. |
|
|
Here it is: Addon installation dialog box 3.png (157,171 bytes) |
|
|
Are you sure that it is the default size of the dialog? Did you delete persistent.json file before the test? Note that the last size of this resizeable dialog is restored, so you probably resized the initial default? |
|
|
No, I didn't delete persistent.json file. In my opinion the program should not remember the size of that dialog box, but it should recalculate its size every time when it is opened based on the displayed/contained controls, to fill it properly, at least it should do that for the height. Currently, if I install one add-on with a really big license file and I enlarge that dialog to see it better, then I close it (either by Install now or Cancel), and then when I want to install another add-on that has a much smaller license file I will get the size of the previously enlarged window, as it was the case on the previous screenshot. I think the program already has some dialog boxes that are automatically resized on their opening based on their displayed content. You should just implement the same thing with this dialog. |
|
|
Hmm, I still cannot replicate with D&D a MMIP onto the player, it is shown in its default size.. Could you please share the testing mmip that you used in your last test? |
|
|
You could find the test addon several posts above: https://www.ventismedia.com/mantis/view.php?id=20351#c73889 This happens with any addon with the license text. It is not shown in its default size, but the last size of the dialog box is restored, just as you mentioned in your previous note. In my opinion, neither of these two solutions shouldn't be applied. It would be better if the program could detect the length of the license text and automatically resize the dialog box based on that, making its text box large enough to show text without scrollbars, but also without any extra empty space. I described the steps to reproduce the problem: - open any addon with the license text and enlarge its dialog box vertically to cover the screen; - cancel its installation; - open any addon with the license text -> it will have the previously enlarged size, even if it has smaller (shorter) license text. |
|
|
Thanks, fixed in 3022 |
