View Issue Details

IDProjectCategoryView StatusLast Update
0001714MMW v4DB/FileMonitorpublic2005-01-04 04:12
Reporterrusty Assigned To 
PriorityimmediateSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Fixed in Version2.3 
Summary0001714: When upgrading from MM 2.2 to MM 2.3, Album Art isn't correctly scanned
DescriptionIf the user upgrades from MM 2.2 to MM 2.3 and Album Art exists in tracks, then MM 2.3 shows them, but isn't aware of the fact that the art exists (evidenced by the fact that the tracks' Album Art appears, but at the same time, the tracks appear in the Unknown Album Art node).

I'm not sure what the best way of solving this is, but what should happen is that if a user upgrades to MM 2.3, the stats in the Unknown Album Art node should be correct. If this requires a complete rescan of all tracks, we could prompt users with something along the lines of 'MediaMonkey 2.3 now supports Album Art. Would you like MediaMonkey to re-scan your collection for Album Art? [Yes] [No]

Note: obviously, such a scan would have to ignore configuration settings that limit scans to files with new timestamps. Also, this is only required for users that are installing MM 2.3 and a DB already exists.
Additional InformationSeveral users brought this up at: http://www.mediamonkey.com/forum/viewtopic.php?t=3037

I'd thought that it was a problem with earlier betas, but based on recent tests, it's related to the fact that MM never forces a rescan for album art.
TagsNo tags attached.
Fixed in build828

Activities

jiri

2005-01-02 13:03

administrator   ~0005078

I agree that Unknown Album Art node doesn't work properly in case user has already images in tags. However, I rather wouldn't implement new upgrade strategies that would take time to implement and could introduce some bugs, etc. I'd rather document this in release notes.

rusty

2005-01-03 00:38

administrator   ~0005085

As discussed over IM:

Rusty: I think it's ok if we have the bug, and require users to simply rescan their libraries to correct the problem, however, I think it's not satisfactory if we require users to delete their libraries in order to solve the problem.

Jirka: That's what I think should work, i.e. images are scanned regardless of timestamps.

Rusty: Ok, retested and found that:
1) Installed MM 2.2 and scanned
2) Installed MM 2.3 --> 1753 Unknown Album Art
3) Rescanned drive -->1463 Unknown Album Art, HOWEVER, of those 1463 a significant proportion do have Album Art (Note: all the files that have Album Art even though they're in the 'Unknown Album Art' node are MP3 files which to my knowledge all have the artwork embedded in tags.)
4) Clear the library and scan it from scratch --> only 989 files are in the 'Unknown Album Art' node!! (implying that close to 500 tracks were incorrectly placed in the Unknown Album Art node in step 3).

Note: I'm saying that linked .jpg images _are_ detected on rescan (for both MP3 and OGG files), but that MP3 files that have album art embedded in the tag appear in the Unknown Album Art node even on rescanning the library.

jiri

2005-01-03 09:15

administrator   ~0005087

Ok, now I understand, MM doesn't rescan tags because timestamp hasn't changed (which isn't important for scanning external jpegs).

Providing that it can cause problems only in Unknown Album Art node I would prefer implementing some special handling of this issue because for majority of users it wouldn't be anything useful. Therefore I would prefer to document that in order to pick up covers from tags user must turn off Library|Only for files with changed timestamp or size.

rusty

2005-01-03 13:25

administrator   ~0005089

Last edited: 2005-01-03 13:26

OK, so I tried the procedure that you suggested i.e.:
5) Take the database from step 3). Disable [ ] Library|Only for files with changed timestamp or size, and rescan library
-->1463 files in the Unknown Album Art dialog!!

This implies that something isn't working correctly with this functionality in terms of updating changes to tracks involving Album Art (i.e. one would have expected 989 files to show up in 'Unknown Album Art').

jiri

2005-01-03 20:57

administrator   ~0005093

Fixed in build 828.
 - The scanning logic was modified so that images in tags are really scanned in this case.

rusty

2005-01-04 04:12

administrator   ~0005099

Verified in 828 (the number of files in the unknown album art node goes down to 989).

I updated the readme with:

b) If you had a previous version of MediaMonkey installed, it is recommended that you rescan your
   drives for any Album Art. To do so, press <Insert> to get to the 'Add Tracks' dialog. Press the
   'Options' button and uncheck 'Only for files with changed timestamp or file size', and then
   select all your drives and click 'Ok' to rescan them. After you're done, re-enable the
   'Only for files with changed timestamp or file size' option for better performance.