View Issue Details

IDProjectCategoryView StatusLast Update
0018300MMW 5Extensions frameworkpublic2021-11-29 21:09
ReporterLudek Assigned To 
PriorityurgentSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version5.0 
Target Version5.0.2Fixed in Version5.0.2 
Summary0018300: Add Promise.finally() as replacement of Promise.then1()
DescriptionPer IM discussion we should add also 'finally' (as replacement of then1) and replace it in code (though keeping then1 still available just in case any addon uses it).

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/finally
TagsNo tags attached.
Fixed in build2503

Relationships

related to 0018271 closedjiri No way to create folder using app.filesystem 

Activities

Ludek

2021-09-14 19:33

developer   ~0064621

Last edited: 2021-09-14 19:34

Added Promise.finally() method (as duplicate of then1 and used already in some parts of code), but seeing that we are using 'then1' on many places in code -- and I am afraid that bulk replacing would require quite extensive test coverage to be sure that there are no regressions. So I am still leaving 'then1' as alternative (to be replaced by 'finally' in the future versions/code).

peke

2021-09-17 23:30

developer   ~0064743

Verified function in 2503

Not closed till Deprecation of Then1 is documented in API so that it is only provided for compatibility reasons and that Finally should be used, because it will be removed in future versions.

Ludek

2021-09-20 10:44

developer   ~0064761

Assigned back to me to update the docs.

Ludek

2021-09-27 17:04

developer   ~0064880

Promise class documented , assigned to Jiri to update the docs on the web ( https://www.mediamonkey.com/docs/api/ )

jiri

2021-09-29 06:55

administrator   ~0064898

Uploaded updated docs.

peke

2021-10-02 18:14

developer   ~0064959

Verified 2507

Verified API