View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0017196 | MMW 5 | Now Playing | public | 2020-12-08 17:32 | 2022-09-13 20:04 |
| Reporter | rusty | Assigned To | |||
| Priority | urgent | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | reopened | ||
| Product Version | 5.0 | ||||
| Target Version | 5.0.1 | Fixed in Version | 5.0.1 | ||
| Summary | 0017196: Playing status not shown (tracks/time remaining + auto-dj status) | ||||
| Description | Drakinite brought up the fact that users can easily become confused by the Auto-DJ's behavior if they forget that it's on. Additionally, build 2281 doesn't indicate how many tracks / how much time remains in the NP list (although this does appear for Ludek as in previous builds). i.e. Intended header was: Playing x/y (mm:ss) but the Current header is: Playing list Proposed solutions: 1) Change the header slightly: - If Auto-DJ hasn't added tracks: Playing ( y |mm:ss]) = (remaining tracks | remaining time) since x in the originally intended header can easily be seen as soon as there's a track transition and y can be seen by selecting the tracks, and since total time remaining is what is most relevant in this context. - If Auto-DJ has added tracks: Playing (Auto-DJ) -- since remaining tracks and time is effectively infinite (and the metrics above are irrelevant). Michal suggested that Auto-DJ would take up too much space, but I don't think so since it replaces 'y | mm:ss). 2) Jiri suggested: to instead show a Toast message when auto-dj adds tracks, but this would pop a toast on every track transition which might be a bit annoying. But it could work if closing the toast caused it to not appear for the duration of the current auto-dj 'session'. 3) Drakinite suggested: to instead add an Auto-DJ toggle to the Player. It could: - have 3 states [off / on / on-flash] with the flash state used to indicate a track being added - be right-clickable to allow the user to configure the auto-dj Downside of this approach is that it adds another button to the player (which I'd prefer not to). I think that all of these proposals are good but that: - 2) is preferable to 3) because many would prefer to not have another button (note though that both 2) and 3) could be implemented with toasts hidden if the Auto-DJ button is enabled) - if we implement 2) or 3), there's still the matter of whether the status indicator for the 'Playing' list should be displayed once the auto-dj is adding tracks. | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 2405 | ||||
|
|
Note: this could be pushed to 5.0.1 if non-trivial. |
|
|
IMHO soltion 1) makes perfect sense to me (and should be trivial to implement for 5.0) |
|
|
Fixed in build 2402. Used solution 1). |
|
|
Tested 2404. A couple of improvements should be made to the current implementation: a) Disabling Auto-DJ via the Playing menu's checkbox doesn't update the status (it should immediately stop showing 'Auto-DJ') b) When auto-DJ is enabled, it would be preferable if the status doesn't completely hide the number of tracks in the list. i.e.: i) 'Playing x/y (Auto-DJ)' when the manually selected tracks are playing ii) 'Playing (Auto-DJ)' once the manually selected tracks have completed playing |
|
|
a) fixed in build 2405 b) I do not see any reason for this, it won't be correct, once Audo-DJ is on, number of tracks in NP list is infinitive, no matter how the tracks were added and which tracks are currently playing. |
|
|
b) Pasted from discussion with Michal offline: The reason is so that users are aware that there are many tracks before the Auto-DJ is active. But you're right that it could appear inconsistent to the user and therefore confusing. Perhaps the simplest is to always show 'Playing (x/y)' (and calculate x/y with Auto-DJ changes) and whenever Auto-DJ is active, replace the time remaining with 'Auto-DJ'). That would eliminate user confusion, make things consistent, and hopefully be simpler from an implementation perspective. |
|
|
Fixed in build 2405. |
|
|
Functionality Verified in 2405 As made currently for me (Auto DJ) is replacing (Total Time) when Active so this is fixed. I noted that there is no progress/indication that AutoDJ is active and calculating tracks. May I suggest to be even more clear I would suggest changing this to 'Playing (x/y) (TOTALTIME) (AutoDJ)' and just 'Playing (x/y) (AutoDJ Calculating)' during time AutoDJ is Adding Tracks? |
|
|
Re-resolving. The current design is working well and seem to be simple/clear about whether auto-dj is enabled or not. |
|
|
MartinW raised the issue that for the status: Playing (x/y) (hh:mm:ss), the hh:mm:ss = Total Time, rather than time remaining. Is this a trivial fix? If not, we can resolve this bug, and open a new one to track that issue. |
|
|
I am not sure, it is good to place there time remaining, this is changing every second during playback, so the status would be sent and header repainted very often... Anyway closing this issue, it cannot be done easily and needs discussion I think. |
|
|
Verified on 2410 |
